-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish the \a escape sequence #6221
Conversation
spec/compiler/lexer/lexer_spec.cr
Outdated
@@ -231,8 +231,8 @@ describe "Lexer" do | |||
it_lexes_number :i8, ["0i8", "0"] | |||
|
|||
it_lexes_char "'a'", 'a' | |||
it_lexes_char "'\\a'", 7.chr | |||
it_lexes_char "'\\b'", 8.chr | |||
it_lexes_char "'\\a'", '\u{7}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not '\a'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this because p 7.chr
gives '\u{7}'
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@r00ster91 can you change the \u{7}
to \a
and also use \b
in the following spec to keep it consistent with the rest of the suite.
spec/compiler/lexer/lexer_spec.cr
Outdated
@@ -231,8 +231,8 @@ describe "Lexer" do | |||
it_lexes_number :i8, ["0i8", "0"] | |||
|
|||
it_lexes_char "'a'", 'a' | |||
it_lexes_char "'\\a'", 7.chr | |||
it_lexes_char "'\\b'", 8.chr | |||
it_lexes_char "'\\a'", '\u{7}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@r00ster91 can you change the \u{7}
to \a
and also use \b
in the following spec to keep it consistent with the rest of the suite.
For reference, this is a follow up of #5864 |
Okay changed it. |
You should also add |
That Travis CI failed is just a runtime error I think |
No description provided.