Finish the \a escape sequence #6221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spec/compiler/lexer/lexer_spec.cr
Outdated
| @@ -231,8 +231,8 @@ describe "Lexer" do | |||
| it_lexes_number :i8, ["0i8", "0"] | |||
|
|
|||
| it_lexes_char "'a'", 'a' | |||
| it_lexes_char "'\\a'", 7.chr | |||
| it_lexes_char "'\\b'", 8.chr | |||
| it_lexes_char "'\\a'", '\u{7}' | |||
There was a problem hiding this comment.
I did this because p 7.chr gives '\u{7}'.
There was a problem hiding this comment.
@r00ster91 can you change the \u{7} to \a and also use \b in the following spec to keep it consistent with the rest of the suite.
bcardiff
requested changes
Jun 21, 2018
spec/compiler/lexer/lexer_spec.cr
Outdated
| @@ -231,8 +231,8 @@ describe "Lexer" do | |||
| it_lexes_number :i8, ["0i8", "0"] | |||
|
|
|||
| it_lexes_char "'a'", 'a' | |||
| it_lexes_char "'\\a'", 7.chr | |||
| it_lexes_char "'\\b'", 8.chr | |||
| it_lexes_char "'\\a'", '\u{7}' | |||
There was a problem hiding this comment.
@r00ster91 can you change the \u{7} to \a and also use \b in the following spec to keep it consistent with the rest of the suite.
|
For reference, this is a follow up of #5864 |
|
Okay changed it. |
|
You should also add |
|
That Travis CI failed is just a runtime error I think |
bcardiff
approved these changes
Jun 22, 2018
RX14
approved these changes
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.