Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mill build tool #42240

Closed
wants to merge 4 commits into from

Conversation

scalavision
Copy link
Contributor

@scalavision scalavision commented Jun 19, 2018

Motivation for this change

Mill is a very nice tool for building java and scala projects. It is easier to learn than sbt, maven and gradle for beginners in Scala.

I lack a maintainer. I guess it needs to be one of the main contributors to the nixpkgs or can I put myself in there ? I could be a maintainer on bioinformatic tools and scala tools if you need one, depending a bit on how much work such an effort would require, in addition to skillset. I am more into development than operations.

I have used mill locally for a while on my Nixos 18.03 distribution. It seems to work very well!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [ x] Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member

dtzWill commented Jun 23, 2018

You can absolutely be a maintainer -- in fact that would be rather appreciated! If you'd like to add yourself as maintainer for other things please make a PR doing so and we'd be happy for the help :).

Not sure if there's official documentation of what the role entails but generally means:

  • help deal with breakage involving the package or issues users have
  • Maybe updating, although working is more important (and the update bot does much of the legwork here these days)

Doesn't mean you're on your own, it's an informal commitment from you as well as marker of who to thank :).

Mostly I wanted to say please add yourself or file a PR adding yourself to packages that you're interested/willing to (help) maintain! Thanks!

@scalavision
Copy link
Contributor Author

Thank you dtzWill !

I will get back to this when I am back from vacation (approx. 10 days from now) :-)

@scalavision scalavision deleted the adding-mill-build-tool branch November 27, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants