Add missing JSON field to docs generator output for constants #6218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhass
approved these changes
Jun 19, 2018
|
@straight-shoota Could you point where the id read and missing? |
|
crystal/src/compiler/crystal/tools/doc/html/js/_search.js Lines 128 to 139 in ee71f88 |
bcardiff
approved these changes
Jun 21, 2018
|
Great! thanks for clarifying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6202
The
idfield was missing in the JSON serialization of constants, resulting in anundefinedvalue when using it to generate link targets for search results.I added
Constant#idand used this in the template as well, instead of reusingConstant#nameto be more explicit (although both methods return the same value) and to have a consistent interface like the other classes whereidandnameare usually different.