Change const
use to var
for Safari 9 (on iOS)
#2430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari 9 in iOS does not support the use of
const
in strict mode. Unfortunately, some of us are stuck with Safari 9 due to not being able to upgrade.I am a big fan of progressive enhancement, but because all javascript code is packed together and sent off to the client, this small incompatibility breaks all javascript for safari 9 browsers. Switching these two keywords makes everything work again.
There are no other uses of
const
in the codebase as far as I can find. This change has little to no impact on anything else, but slighlty extends the range of supported browsers.(I could not find a specific listing of supported browsers on https://www.dokuwiki.org/browser. While I agree that Safari 9 is not exactly "an up-to-date version", it seems to me that this was an accidental incompatibility.)