fix runtime fn ptr equality codegen

andrewrk · andrewrk · commit 55193cb13bbc · 2018-06-20T06:46:53.000-04:00
closes #1140
diff --git a/src/codegen.cpp b/src/codegen.cpp
@@ -2246,12 +2246,12 @@ static LLVMValueRef ir_render_bin_op(CodeGen *g, IrExecutable *executable,
             } else if (type_entry->id == TypeTableEntryIdInt) {
                 LLVMIntPredicate pred = cmp_op_to_int_predicate(op_id, type_entry->data.integral.is_signed);
                 return LLVMBuildICmp(g->builder, pred, op1_value, op2_value, "");
-            } else if (type_entry->id == TypeTableEntryIdEnum) {
-                LLVMIntPredicate pred = cmp_op_to_int_predicate(op_id, false);
-                return LLVMBuildICmp(g->builder, pred, op1_value, op2_value, "");
-            } else if (type_entry->id == TypeTableEntryIdErrorSet ||
+            } else if (type_entry->id == TypeTableEntryIdEnum ||
+                    type_entry->id == TypeTableEntryIdErrorSet ||
                     type_entry->id == TypeTableEntryIdPointer ||
-                    type_entry->id == TypeTableEntryIdBool)
+                    type_entry->id == TypeTableEntryIdBool ||
+                    type_entry->id == TypeTableEntryIdPromise ||
+                    type_entry->id == TypeTableEntryIdFn)
             {
                 LLVMIntPredicate pred = cmp_op_to_int_predicate(op_id, false);
                 return LLVMBuildICmp(g->builder, pred, op1_value, op2_value, "");
diff --git a/test/cases/misc.zig b/test/cases/misc.zig
@@ -701,3 +701,8 @@ test "comptime cast fn to ptr" {
     const addr2 = @ptrCast(*const u8, emptyFn);
     comptime assert(addr1 == addr2);
 }
+
+test "equality compare fn ptrs" {
+    var a = emptyFn;
+    assert(a == a);
+}

Original file line number	Diff line number	Diff line change
`@@ -701,3 +701,8 @@ test "comptime cast fn to ptr" {`
`701`	`701`	`const addr2 = @ptrCast(*const u8, emptyFn);`
`702`	`702`	`comptime assert(addr1 == addr2);`
`703`	`703`	`}`
	`704`	`+`
	`705`	`+test "equality compare fn ptrs" {`
	`706`	`+ var a = emptyFn;`
	`707`	`+ assert(a == a);`
	`708`	`+}`