Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fcitx-qt5: fix build with Qt 5.11 #42297

Merged
merged 1 commit into from Jun 20, 2018
Merged

fcitx-qt5: fix build with Qt 5.11 #42297

merged 1 commit into from Jun 20, 2018

Conversation

mnacamura
Copy link
Contributor

Motivation for this change

See fcitx/fcitx-qt5#34

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jun 20, 2018

Can you apply a patch with fetchpatch instead? fcitx/fcitx-qt5@af033e3

Then we know when to drop the patch on updates.

@mnacamura
Copy link
Contributor Author

Changed it accordingly.

@Mic92 Mic92 merged commit d91c701 into NixOS:master Jun 20, 2018
@Mic92
Copy link
Member

Mic92 commented Jun 20, 2018

Thanks!

@mnacamura mnacamura deleted the fcitx-qt5 branch June 21, 2018 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mnacamura @Mic92 @GrahamcOfBorg