Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pdfx: init at 1.3.1 #42815

Merged
merged 1 commit into from Jul 13, 2018
Merged

pythonPackages.pdfx: init at 1.3.1 #42815

merged 1 commit into from Jul 13, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jun 30, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner June 30, 2018 12:00
dotlambda
dotlambda requested changes Jun 30, 2018
View reviewed changes
pkgs/development/python-modules/pdfx/default.nix Outdated
};

prePatch = ''
sed -i -e "s|pdfminer2|pdfminer.six|" setup.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should package pdfminer2 instead of using an old version.

Copy link
Member

@dotlambda dotlambda Jun 30, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't pdfminer.six explicitly replaced in metachris/pdfx@cee76e1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't pdfminer.six explicitly replaced in metachris/pdfx@cee76e1?

I didn't knew that, but seems that there is no significant changes in pdfminer2 pdfminer/pdfminer.six@master...metachris:master.
pdfx works with pdfminer.six, but i can package pdfminer2 if you prefer it

Copy link
Member

@dotlambda dotlambda Jul 1, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's first wait for the maintainer's answer to metachris/pdfx#28.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the package seems unmaintained, I'd say we just go with your change. However, please add a link to your PR as a comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I've added a comment with the link

pkgs/development/python-modules/pdfx/default.nix
pname = "pdfx";
version = "1.3.1";

src = fetchFromGitHub {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have opened metachris/pdfx#29 so that fetchPypi can be used.

dotlambda
dotlambda reviewed Jul 13, 2018
View reviewed changes
pkgs/development/python-modules/pdfx/default.nix Outdated

meta = with stdenv.lib; {
inherit (src.meta) homepage;
description = "Extract references (pdf, url, doi, arxiv) and metadata from a PDF.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no full stop: https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed :)

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.pdfx python3.pkgs.pdfx

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.pdfx, python3.pkgs.pdfx

Partial log (click to expand)

platform linux2 -- Python 2.7.15, pytest-3.6.2, py-1.5.3, pluggy-0.6.0
rootdir: /build/source, inifile:
collected 3 items

tests/test_cli.py .                                                      [ 33%]
tests/test_pdfx.py ..                                                    [100%]

=========================== 3 passed in 6.05 seconds ===========================
/nix/store/3k8cjmw12sqs508ckm5g5idimqv3f01q-python2.7-pdfx-1.3.1
/nix/store/f6qw8q4a2chxy5mzkzpdcw2q8lpalryq-python3.6-pdfx-1.3.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.pdfx, python3.pkgs.pdfx

Partial log (click to expand)


tests/test_cli.py .                                                      [ 33%]
tests/test_pdfx.py ..                                                    [100%]

========================== 3 passed in 25.42 seconds ===========================
tests/test_pdfx.py ..                                                    [100%]

========================== 3 passed in 28.00 seconds ===========================
/nix/store/7pkwbj705xvhhmf59jn0k8m0kzxi5hwh-python2.7-pdfx-1.3.1
/nix/store/jvjq98mh0znq3l6whzgih05ambzzvrbp-python3.6-pdfx-1.3.1

@dotlambda dotlambda merged commit 90959f8 into NixOS:master Jul 13, 2018
@marsam marsam deleted the feature/init-pdfx branch July 13, 2018 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @dotlambda @GrahamcOfBorg