Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.pybrowserid: move expression and 0.9.2 -> 0.14.0 #42814

Merged
merged 1 commit into from Jun 30, 2018
Merged

python.pkgs.pybrowserid: move expression and 0.9.2 -> 0.14.0 #42814

merged 1 commit into from Jun 30, 2018

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Some cleaning

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace requested a review from FRidh as a code owner June 30, 2018 11:58
@worldofpeace
Copy link
Contributor Author

cc @dotlambda ?

xeji
xeji reviewed Jun 30, 2018
View reviewed changes
pkgs/development/python-modules/pybrowserid/default.nix Outdated

propagatedBuildInputs = [ requests ];

buildInputs = [ mock ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this rather be checkInputs ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, yeah.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected.

@xeji
Copy link
Contributor

xeji commented Jun 30, 2018

@GrahamcOfBorg build python27Packages.pybrowserid python36Packages.pybrowserid python27Packages.syncserver

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.pybrowserid, python36Packages.pybrowserid

The following builds were skipped because they don't evaluate on x86_64-darwin: python27Packages.syncserver

Partial log (click to expand)

test_verification_of_oldstyle_dummy_assertion (browserid.tests.test_verifiers.TestWorkerPoolVerifier) ... ok
test_verification_of_untrusted_issuer (browserid.tests.test_verifiers.TestWorkerPoolVerifier) ... ok
test_verification_of_valid_dummy_assertion (browserid.tests.test_verifiers.TestWorkerPoolVerifier) ... ok

----------------------------------------------------------------------
Ran 111 tests in 5.402s

OK (skipped=5)
/nix/store/p1ig36brf4linqrnxlxrh8qhyafds0as-python2.7-PyBrowserID-0.14.0
/nix/store/rb1fcrb851nm195bzmk45i47h4bc02lm-python3.6-PyBrowserID-0.14.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.pybrowserid, python36Packages.pybrowserid

The following builds were skipped because they don't evaluate on x86_64-linux: python27Packages.syncserver

Partial log (click to expand)

test_loading_from_pem_data (browserid.tests.test_jwt.TestRS64KeyPair) ... ok
test_loading_from_pem_data_filename (browserid.tests.test_jwt.TestRS64KeyPair) ... ok
test_verification (browserid.tests.test_jwt.TestRS64KeyPair) ... ok

----------------------------------------------------------------------
Ran 111 tests in 5.059s

OK (skipped=5)
/nix/store/5h2w5f5ah6kddpnsh82hlaphnjc9md39-python2.7-PyBrowserID-0.14.0
/nix/store/1i4dxmmqkjclkqfz6dvhhpq4ynwrd739-python3.6-PyBrowserID-0.14.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.pybrowserid, python36Packages.pybrowserid

The following builds were skipped because they don't evaluate on aarch64-linux: python27Packages.syncserver

Partial log (click to expand)

test_loading_from_pem_data (browserid.tests.test_jwt.TestRS64KeyPair) ... ok
test_loading_from_pem_data_filename (browserid.tests.test_jwt.TestRS64KeyPair) ... ok
test_verification (browserid.tests.test_jwt.TestRS64KeyPair) ... ok

----------------------------------------------------------------------
Ran 111 tests in 37.485s

OK (skipped=5)
/nix/store/gpkdhnn5nc5qfk17m5fyqgf9cvbfr3dv-python2.7-PyBrowserID-0.14.0
/nix/store/040xs7ca3xjwr37w8wl8bzknyjnhlcjp-python3.6-PyBrowserID-0.14.0

@xeji xeji merged commit bae87d5 into NixOS:master Jun 30, 2018
@worldofpeace worldofpeace deleted the pybrowserid-refresh branch June 30, 2018 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @xeji @GrahamcOfBorg