Improve error reports to the user for spotify imports #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Tell the user if their account is inactive i.e we aren't importing their listens. * Show errors that occured during their imports. * Show times when listens were imported last.
mayhem
approved these changes
Jul 2, 2018
|
|
||
| {% if account.error_message %} | ||
| <h3>Import Errors</h3> | ||
| <p>There was an error while importing listens from your Spotify account.</p> |
| {% endif %} | ||
|
|
||
| {% if not account.last_updated %} | ||
| <p>We haven't gotten around to importing your listens yet, please come back later!</p> |
There was a problem hiding this comment.
nitpick: please check back later.
| {% if not account.last_updated %} | ||
| <p>We haven't gotten around to importing your listens yet, please come back later!</p> | ||
| {% else %} | ||
| <p>We imported your listens <abbr class="timeago" title="{{last_updated}}">{{last_updated}}</abbr> and the last song we imported was listened to <abbr class="timeago" title="{{latest_listened_at}}">{{latest_listened_at}}</abbr>.</p> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
We saved error messages for users in the db but didn't display them.
Solution
Improve error reporting and information given to user.
importing their listens.