Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clightning: init at 0.6rc1 #42318

Closed
wants to merge 1 commit into from
Closed

clightning: init at 0.6rc1 #42318

wants to merge 1 commit into from

Conversation

jb55
Copy link
Contributor

@jb55 jb55 commented Jun 21, 2018

c-lightning is a standard compliant implementation of the Lightning
Network protocol. The Lightning Network is a scalability solution for
Bitcoin, enabling secure and instant transfer of funds between any two
parties for any amount.

Motivation for this change

c-lightning is a bit more stable now, figured it was a good time to package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jb55 jb55 mentioned this pull request Jun 21, 2018
Closed
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: clightning

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: clightning

Partial log (click to expand)

gcc -DBINTOPKGLIBEXECDIR='"'../libexec/c-lightning'"' -Werror -Wall -Wundef -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wold-style-definition -std=gnu11 -g -fstack-protector -I ccan -I external/libsodium/src/libsodium/include -I external/libwally-core/include/ -I external/libwally-core/src/secp256k1/include/ -I external/jsmn/ -I external/libbase58/ -I external/libbacktrace/ -I external/libbacktrace-build -I . -I/usr/local/include    -DSHACHAIN_BITS=48 -DJSMN_PARENT_LINKS  -DCOMPAT_V052=1 -c -o ccan-tal-str.o ccan/ccan/tal/str/str.c
gcc -DBINTOPKGLIBEXECDIR='"'../libexec/c-lightning'"' -Werror -Wall -Wundef -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wold-style-definition -std=gnu11 -g -fstack-protector -I ccan -I external/libsodium/src/libsodium/include -I external/libwally-core/include/ -I external/libwally-core/src/secp256k1/include/ -I external/jsmn/ -I external/libbase58/ -I external/libbacktrace/ -I external/libbacktrace-build -I . -I/usr/local/include    -DSHACHAIN_BITS=48 -DJSMN_PARENT_LINKS  -DCOMPAT_V052=1 -c -o ccan-tal.o ccan/ccan/tal/tal.c
gcc -DBINTOPKGLIBEXECDIR='"'../libexec/c-lightning'"' -Werror -Wall -Wundef -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wold-style-definition -std=gnu11 -g -fstack-protector -I ccan -I external/libsodium/src/libsodium/include -I external/libwally-core/include/ -I external/libwally-core/src/secp256k1/include/ -I external/jsmn/ -I external/libbase58/ -I external/libbacktrace/ -I external/libbacktrace-build -I . -I/usr/local/include    -DSHACHAIN_BITS=48 -DJSMN_PARENT_LINKS  -DCOMPAT_V052=1 -c -o ccan-time.o ccan/ccan/time/time.c
gcc -DBINTOPKGLIBEXECDIR='"'../libexec/c-lightning'"' -Werror -Wall -Wundef -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wold-style-definition -std=gnu11 -g -fstack-protector -I ccan -I external/libsodium/src/libsodium/include -I external/libwally-core/include/ -I external/libwally-core/src/secp256k1/include/ -I external/jsmn/ -I external/libbase58/ -I external/libbacktrace/ -I external/libbacktrace-build -I . -I/usr/local/include    -DSHACHAIN_BITS=48 -DJSMN_PARENT_LINKS  -DCOMPAT_V052=1 -c -o ccan-timer.o ccan/ccan/timer/timer.c
tools/generate-wire.py hsmd/gen_hsm_client_wire.h hsm_client_wire_type< hsmd/hsm_client_wire_csv > hsmd/gen_hsm_client_wire.c
/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/bash: tools/generate-wire.py: /usr/bin/env: bad interpreter: No such file or directory
make: *** [hsmd/Makefile:64: hsmd/gen_hsm_client_wire.c] Error 126
make: *** Waiting for unfinished jobs....
builder for '/nix/store/hkjqd540hrskila10byby7lbyihy894h-clightning-0.6rc1.drv' failed with exit code 2
error: build of '/nix/store/hkjqd540hrskila10byby7lbyihy894h-clightning-0.6rc1.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: clightning

Partial log (click to expand)

gcc -DBINTOPKGLIBEXECDIR='"'../libexec/c-lightning'"' -Werror -Wall -Wundef -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wold-style-definition -std=gnu11 -g -fstack-protector -I ccan -I external/libsodium/src/libsodium/include -I external/libwally-core/include/ -I external/libwally-core/src/secp256k1/include/ -I external/jsmn/ -I external/libbase58/ -I external/libbacktrace/ -I external/libbacktrace-build -I . -I/usr/local/include    -DSHACHAIN_BITS=48 -DJSMN_PARENT_LINKS  -DCOMPAT_V052=1 -c -o ccan-timer.o ccan/ccan/timer/timer.c
tools/generate-wire.py hsmd/gen_hsm_client_wire.h hsm_client_wire_type< hsmd/hsm_client_wire_csv > hsmd/gen_hsm_client_wire.c
tools/generate-wire.py common/gen_status_wire.h status < common/status_wire.csv > common/gen_status_wire.c
/nix/store/23kq49wszxq7k41dqfk82q5vqwlq5sww-bash-4.4-p19/bin/bash: tools/generate-wire.py: /usr/bin/env: bad interpreter: No such file or directory
/nix/store/23kq49wszxq7k41dqfk82q5vqwlq5sww-bash-4.4-p19/bin/bash: tools/generate-wire.py: /usr/bin/env: bad interpreter: No such file or directory
make: *** [hsmd/Makefile:64: hsmd/gen_hsm_client_wire.c] Error 126
make: *** Waiting for unfinished jobs....
make: *** [common/Makefile:75: common/gen_status_wire.c] Error 126
builder for '/nix/store/hi6lph1rfwpqlxd0fngrclimjnhjknjg-clightning-0.6rc1.drv' failed with exit code 2
error: build of '/nix/store/hi6lph1rfwpqlxd0fngrclimjnhjknjg-clightning-0.6rc1.drv' failed

@Mic92
Copy link
Member

Mic92 commented Jun 21, 2018

tools/generate-wire.py needs to be patched with patchShebangs

@jb55
Copy link
Contributor Author

jb55 commented Jun 21, 2018

really weird that I don't get this issue when compiling on master, even with sandbox 🤔

@jb55
clightning: init at 0.6rc1
d220803 
c-lightning is a standard compliant implementation of the Lightning
Network protocol. The Lightning Network is a scalability solution for
Bitcoin, enabling secure and instant transfer of funds between any two
parties for any amount.
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: clightning

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: clightning

Partial log (click to expand)

shrinking /nix/store/rq0gzk0qfamyiz4cvj8v5vdmf8yvaj64-clightning-0.6rc1/libexec/c-lightning/lightning_hsmd
shrinking /nix/store/rq0gzk0qfamyiz4cvj8v5vdmf8yvaj64-clightning-0.6rc1/libexec/c-lightning/lightning_gossipd
shrinking /nix/store/rq0gzk0qfamyiz4cvj8v5vdmf8yvaj64-clightning-0.6rc1/bin/lightning-cli
shrinking /nix/store/rq0gzk0qfamyiz4cvj8v5vdmf8yvaj64-clightning-0.6rc1/bin/lightningd
gzipping man pages under /nix/store/rq0gzk0qfamyiz4cvj8v5vdmf8yvaj64-clightning-0.6rc1/share/man/
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rq0gzk0qfamyiz4cvj8v5vdmf8yvaj64-clightning-0.6rc1/libexec  /nix/store/rq0gzk0qfamyiz4cvj8v5vdmf8yvaj64-clightning-0.6rc1/bin
patching script interpreter paths in /nix/store/rq0gzk0qfamyiz4cvj8v5vdmf8yvaj64-clightning-0.6rc1
checking for references to /build in /nix/store/rq0gzk0qfamyiz4cvj8v5vdmf8yvaj64-clightning-0.6rc1...
/nix/store/rq0gzk0qfamyiz4cvj8v5vdmf8yvaj64-clightning-0.6rc1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: clightning

Partial log (click to expand)

shrinking /nix/store/5mm0jlgflfk9zmn97my6h7xjp682jyx9-clightning-0.6rc1/libexec/c-lightning/lightning_closingd
shrinking /nix/store/5mm0jlgflfk9zmn97my6h7xjp682jyx9-clightning-0.6rc1/libexec/c-lightning/lightning_channeld
shrinking /nix/store/5mm0jlgflfk9zmn97my6h7xjp682jyx9-clightning-0.6rc1/bin/lightningd
shrinking /nix/store/5mm0jlgflfk9zmn97my6h7xjp682jyx9-clightning-0.6rc1/bin/lightning-cli
gzipping man pages under /nix/store/5mm0jlgflfk9zmn97my6h7xjp682jyx9-clightning-0.6rc1/share/man/
strip is /nix/store/min150lkigznaayzpwvf8d4jdl1dqvx6-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5mm0jlgflfk9zmn97my6h7xjp682jyx9-clightning-0.6rc1/libexec  /nix/store/5mm0jlgflfk9zmn97my6h7xjp682jyx9-clightning-0.6rc1/bin
patching script interpreter paths in /nix/store/5mm0jlgflfk9zmn97my6h7xjp682jyx9-clightning-0.6rc1
checking for references to /build in /nix/store/5mm0jlgflfk9zmn97my6h7xjp682jyx9-clightning-0.6rc1...
/nix/store/5mm0jlgflfk9zmn97my6h7xjp682jyx9-clightning-0.6rc1

@jb55
Copy link
Contributor Author

jb55 commented Jun 21, 2018

@Mic92 fixed

@jb55 jb55 closed this Jun 25, 2018
@jb55
Copy link
Contributor Author

jb55 commented Jun 25, 2018

closing since 0.6 is released now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jb55 @GrahamcOfBorg @Mic92