Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shadowfox-updater: init at 1.5.2 #42313

Merged
merged 1 commit into from Jun 27, 2018
Merged

shadowfox-updater: init at 1.5.2 #42313

merged 1 commit into from Jun 27, 2018

Conversation

infinisil
Copy link
Member

Motivation for this change

This adds the ShadowFox updater, which is used to install ShadowFox: https://github.com/overdodactyl/ShadowFox/, a full black theme for firefox.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member Author

@GrahamcOfBorg build shadowfox

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: shadowfox

Partial log (click to expand)

shrinking /nix/store/0vc23w545x8fm35y79dqqp1zbqw72lh1-shadowfox-updater-1.5.2-bin/bin/shadowfox-updater
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0vc23w545x8fm35y79dqqp1zbqw72lh1-shadowfox-updater-1.5.2-bin/bin
patching script interpreter paths in /nix/store/0vc23w545x8fm35y79dqqp1zbqw72lh1-shadowfox-updater-1.5.2-bin
checking for references to /build in /nix/store/0vc23w545x8fm35y79dqqp1zbqw72lh1-shadowfox-updater-1.5.2-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/2yvk99srfgb6wii1mfs1sd7g66z84si9-shadowfox-updater-1.5.2
strip is /nix/store/4mf2xm9p32lzrim927yk92xhx35yaz62-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2yvk99srfgb6wii1mfs1sd7g66z84si9-shadowfox-updater-1.5.2
checking for references to /build in /nix/store/2yvk99srfgb6wii1mfs1sd7g66z84si9-shadowfox-updater-1.5.2...
/nix/store/0vc23w545x8fm35y79dqqp1zbqw72lh1-shadowfox-updater-1.5.2-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: shadowfox

Partial log (click to expand)

shrinking /nix/store/rr11czqpn13r67ahk5ngiamv90z46g0h-shadowfox-updater-1.5.2-bin/bin/shadowfox-updater
strip is /nix/store/min150lkigznaayzpwvf8d4jdl1dqvx6-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rr11czqpn13r67ahk5ngiamv90z46g0h-shadowfox-updater-1.5.2-bin/bin
patching script interpreter paths in /nix/store/rr11czqpn13r67ahk5ngiamv90z46g0h-shadowfox-updater-1.5.2-bin
checking for references to /build in /nix/store/rr11czqpn13r67ahk5ngiamv90z46g0h-shadowfox-updater-1.5.2-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/ijys8p55bq67k6rpg39b9s66wx07j4l2-shadowfox-updater-1.5.2
strip is /nix/store/min150lkigznaayzpwvf8d4jdl1dqvx6-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/ijys8p55bq67k6rpg39b9s66wx07j4l2-shadowfox-updater-1.5.2
checking for references to /build in /nix/store/ijys8p55bq67k6rpg39b9s66wx07j4l2-shadowfox-updater-1.5.2...
/nix/store/rr11czqpn13r67ahk5ngiamv90z46g0h-shadowfox-updater-1.5.2-bin

xeji
xeji reviewed Jun 24, 2018
View reviewed changes
pkgs/tools/networking/shadowfox/default.nix Outdated
{ fetchFromGitHub, buildGoPackage }:

buildGoPackage rec {
name = "shadowfox-updater-${version}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package in all-packages.nix is called shadowfox. It should have the same name here to avoid confusion (not shadowfox-updater).

@infinisil
Copy link
Member Author

@xeji Fixed that, also added meta.

@xeji
Copy link
Contributor

xeji commented Jun 27, 2018

@GrahamcOfBorg build shadowfox

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: shadowfox

Partial log (click to expand)

shrinking /nix/store/ffwl7w9vk3jwdpzhkqc1lg6hfa2h5h8a-shadowfox-1.5.2-bin/bin/shadowfox-updater
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ffwl7w9vk3jwdpzhkqc1lg6hfa2h5h8a-shadowfox-1.5.2-bin/bin
patching script interpreter paths in /nix/store/ffwl7w9vk3jwdpzhkqc1lg6hfa2h5h8a-shadowfox-1.5.2-bin
checking for references to /build in /nix/store/ffwl7w9vk3jwdpzhkqc1lg6hfa2h5h8a-shadowfox-1.5.2-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/zi827z26ikivqycbsv8g5dkbns32p20r-shadowfox-1.5.2
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/zi827z26ikivqycbsv8g5dkbns32p20r-shadowfox-1.5.2
checking for references to /build in /nix/store/zi827z26ikivqycbsv8g5dkbns32p20r-shadowfox-1.5.2...
/nix/store/ffwl7w9vk3jwdpzhkqc1lg6hfa2h5h8a-shadowfox-1.5.2-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: shadowfox

Partial log (click to expand)

shrinking /nix/store/r042m0n1a2bmwm79zgd652wkxsnji99a-shadowfox-1.5.2-bin/bin/shadowfox-updater
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r042m0n1a2bmwm79zgd652wkxsnji99a-shadowfox-1.5.2-bin/bin
patching script interpreter paths in /nix/store/r042m0n1a2bmwm79zgd652wkxsnji99a-shadowfox-1.5.2-bin
checking for references to /build in /nix/store/r042m0n1a2bmwm79zgd652wkxsnji99a-shadowfox-1.5.2-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/d55zszy3lqw2zixj9ivwcac7p6hr74mm-shadowfox-1.5.2
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/d55zszy3lqw2zixj9ivwcac7p6hr74mm-shadowfox-1.5.2
checking for references to /build in /nix/store/d55zszy3lqw2zixj9ivwcac7p6hr74mm-shadowfox-1.5.2...
/nix/store/r042m0n1a2bmwm79zgd652wkxsnji99a-shadowfox-1.5.2-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: shadowfox

Partial log (click to expand)

installing
/private/tmp/nix-build-shadowfox-1.5.2.drv-0/go /private/tmp/nix-build-shadowfox-1.5.2.drv-0
/private/tmp/nix-build-shadowfox-1.5.2.drv-0
post-installation fixup
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ma3pwzbghmd972v581mwn3326ybgvacj-shadowfox-1.5.2-bin/bin
patching script interpreter paths in /nix/store/ma3pwzbghmd972v581mwn3326ybgvacj-shadowfox-1.5.2-bin
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/brg43f9q0jjzrlvn9zgx1393gayry6mm-shadowfox-1.5.2
/nix/store/ma3pwzbghmd972v581mwn3326ybgvacj-shadowfox-1.5.2-bin

@xeji xeji merged commit ed533ba into NixOS:master Jun 27, 2018
@yesbox
Copy link
Contributor

yesbox commented Jun 28, 2018

I disagree about this package being categorized under "networking". Mind moving it to "misc" or possibly "package-management"?

@xeji
Copy link
Contributor

xeji commented Jun 28, 2018

Good point. misc/themes could be a suitable location.

@infinisil
Copy link
Member Author

I've been thinking and bringing this up for a while now: The directory-based categories are inherently flawed because of constant ambiguity, lots of packages somewhat belong into multiple directories. I hope to eventually bring a tagging system to nixpkgs which could solve that problem.

Anybody with commit rights feel free to move the package, I won't open a PR for that, it's such a minor thing and doesn't matter much anyways imo.

@infinisil infinisil deleted the add/shadowfox branch June 30, 2018 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@infinisil @GrahamcOfBorg @xeji @yesbox