clementine: add gst_plugins to buildInputs so setup hooks work #42314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the build was refactored in ef5e212, this was lost. a4ba8c6 got most of it back, but missed the addition of gst_plugins to buildInputs. fixes NixOS#39960
Ma27
reviewed
Jun 21, 2018
|
so, I built your branch locally and your change seems reasonable and functional. Are there any additional issues that neeed to be solved otherwise I'd merge this tomorrow :) |
|
No issues here -- I've been running with this patch since I submitted the PR. :) |
Ma27
approved these changes
Oct 17, 2018
|
thanks a lot for the fix @jerith666 and sorry for the delay I caused! |
|
also backported in 41905d6 as this is certainly a bugfix which also affects 18.09. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the build was refactored in ef5e212, this was lost. a4ba8c6
got most of it back, but missed the addition of gst_plugins to
buildInputs.
fixes #39960
cc @Ma27 @peterhoeg
I don't claim to really understand what's going on in the setup-hooks that makes this necessary, I'm just glad the comment was there in the parent of ef5e212 :)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)