Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

burp: 2.1.32 -> 2.2.4 #46298

Closed
wants to merge 1 commit into from
Closed

burp: 2.1.32 -> 2.2.4 #46298

wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Sep 7, 2018

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/burp/versions.

meta.description for burp is: '"BURP - BackUp and Restore Program"'.

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
  • built on NixOS
  • /nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4/bin/vss_strip passed the binary check.
  • /nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4/bin/bedup passed the binary check.
  • Warning: no invocation of /nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4/bin/bsigs had a zero exit code or showed the expected version
  • /nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4/bin/bsparse passed the binary check.
  • /nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4/bin/burp passed the binary check.
  • /nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4/bin/burp_ca passed the binary check.
  • 5 of 6 passed binary check by having a zero exit code.
  • 3 of 6 passed binary check by having the new version present in output.
  • found 2.2.4 with grep in /nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4
  • directory tree listing: https://gist.github.com/737184302d7306cb9b6aa070b190fb13
  • du listing: https://gist.github.com/d35c566ed9ca306868e55fc20bb1b9dd
Instructions to test this update (click to expand)

One-time optional setup to skip building using Cachix:

  1. Install cachix from https://cachix.org/
  2. Use r-ryantm's cache: 
    cachix use r-ryantm

Test this update by entering a nix shell, seeing what is inside the
result, and if applicable, running some binaries:

nix-shell --pure -I nixpkgs=https://github.com/r-ryantm/nixpkgs/archive/1f94d92553f04805d1f2ef5b276bf8e7d4deab03.tar.gz -p burp
ls -la /nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4

cc @tokudan for testing.

burp: 2.1.32 -> 2.2.4
1f94d92 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/burp/versions
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: burp

Partial log (click to expand)

patching script interpreter paths in /nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4
/nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4/share/burp/scripts/timer_script: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4/share/burp/scripts/notify_script: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4/share/burp/scripts/summary_script: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4/share/burp/scripts/ssl_extra_checks_script: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4/share/burp/scripts/backup_tool_script: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4/sbin/burp_ca: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4...
moving /nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4/sbin/* to /nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4/bin
/nix/store/dg5mzh1zl0s8nb4x4psaxr17d5rz9qgr-burp-2.2.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: burp

Partial log (click to expand)

patching script interpreter paths in /nix/store/5r49xnq8ybx50sdqsmfxx2399v3k5m3q-burp-2.2.4
/nix/store/5r49xnq8ybx50sdqsmfxx2399v3k5m3q-burp-2.2.4/share/burp/scripts/ssl_extra_checks_script: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/5r49xnq8ybx50sdqsmfxx2399v3k5m3q-burp-2.2.4/share/burp/scripts/notify_script: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/5r49xnq8ybx50sdqsmfxx2399v3k5m3q-burp-2.2.4/share/burp/scripts/timer_script: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/5r49xnq8ybx50sdqsmfxx2399v3k5m3q-burp-2.2.4/share/burp/scripts/backup_tool_script: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/5r49xnq8ybx50sdqsmfxx2399v3k5m3q-burp-2.2.4/share/burp/scripts/summary_script: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/5r49xnq8ybx50sdqsmfxx2399v3k5m3q-burp-2.2.4/sbin/burp_ca: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/5r49xnq8ybx50sdqsmfxx2399v3k5m3q-burp-2.2.4...
moving /nix/store/5r49xnq8ybx50sdqsmfxx2399v3k5m3q-burp-2.2.4/sbin/* to /nix/store/5r49xnq8ybx50sdqsmfxx2399v3k5m3q-burp-2.2.4/bin
/nix/store/5r49xnq8ybx50sdqsmfxx2399v3k5m3q-burp-2.2.4

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: burp

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/p5209azm4xiih8560763m6cdbncgii3i-burp-2.2.4/bin  /nix/store/p5209azm4xiih8560763m6cdbncgii3i-burp-2.2.4/sbin
patching script interpreter paths in /nix/store/p5209azm4xiih8560763m6cdbncgii3i-burp-2.2.4
/nix/store/p5209azm4xiih8560763m6cdbncgii3i-burp-2.2.4/sbin/burp_ca: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/p5209azm4xiih8560763m6cdbncgii3i-burp-2.2.4/share/burp/scripts/backup_tool_script: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/p5209azm4xiih8560763m6cdbncgii3i-burp-2.2.4/share/burp/scripts/notify_script: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/p5209azm4xiih8560763m6cdbncgii3i-burp-2.2.4/share/burp/scripts/ssl_extra_checks_script: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/p5209azm4xiih8560763m6cdbncgii3i-burp-2.2.4/share/burp/scripts/summary_script: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/p5209azm4xiih8560763m6cdbncgii3i-burp-2.2.4/share/burp/scripts/timer_script: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
moving /nix/store/p5209azm4xiih8560763m6cdbncgii3i-burp-2.2.4/sbin/* to /nix/store/p5209azm4xiih8560763m6cdbncgii3i-burp-2.2.4/bin
/nix/store/p5209azm4xiih8560763m6cdbncgii3i-burp-2.2.4

@tokudan
Copy link
Contributor

tokudan commented Sep 7, 2018

Version 2.1.32 is still considered the stable version of burp.
I'm against merging.

@xeji
Copy link
Contributor

xeji commented Sep 7, 2018

I agree that we this is a backup software, and we only have one version in nixpkgs, this should be the stable version. We might consider adding an extra package burp-latest.

History/Changelog: https://burp.grke.org/news.html and https://burp.grke.org/changelog.html

@ryantm is there a way for auto-update to select the stable version only?

@xeji xeji closed this Sep 7, 2018
@tokudan
Copy link
Contributor

tokudan commented Sep 7, 2018

Considering that the "latest" version is published once a month, there is no real point in having that anywhere besides master. As soon as a NixOS/Nixpkgs release is split off and released after about a month's work, it's already an old version.
As far as I know the NixOS/Nixpkgs-releases take the whole master and not just a selection of packages, so we'd have to remove burp-latest from every release to avoid including the old version.

@xeji
Copy link
Contributor

xeji commented Sep 7, 2018 •
edited

Well that's a general issue with all packages in branched-off releases...
We could still include the newer version in nixpkgs and name it burp-unstable to prevent users from thinking they really have the latest version. We use that wording a lot in nixpkgs.

But this is just a suggestion, we don't need to add it at all unless there's clear user demand...

@ryantm ryantm mentioned this pull request Sep 7, 2018
Closed
@ryantm
Copy link
Member

ryantm commented Sep 7, 2018 •
edited

@xeji Yes, we can add Repology rules that indicate which versions are stable. Unfortunately, it looks like the developer of burp is not following a versioning scheme that allows systematic indication of the stable release, so we'd have to do it on a case-by-case basis.

I've opened an issue on the burp repo asking them to consider adopting a version scheme that indicates stability, like the GNOME project.

@xeji
Copy link
Contributor

xeji commented Sep 7, 2018

Thanks!

@r-ryantm r-ryantm deleted the auto-update/burp branch September 20, 2018 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r-ryantm @GrahamcOfBorg @tokudan @xeji @ryantm