Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/networkd: support MULTICAST, fix RequiredForOnline and [Route] #46235

Merged
merged 3 commits into from
Sep 7, 2018
Merged

nixos/networkd: support MULTICAST, fix RequiredForOnline and [Route] #46235

merged 3 commits into from
Sep 7, 2018
+3 −3

Conversation

alexshpilkin
Copy link
Member

Introduces support for setting the MULTICAST flag via networkd, as introduced systemd/systemd#9118. Also fixes a long-standing typo in the name of RequiredForOnline and removes the check for Gateway= in [Route] sections (not required for routes via tunnel interfaces).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@alexshpilkin
nixos/networkd: support MULTICAST flag on links
423e46a 
Support Multicast= option in [Link] section of network units,
introduced in systemd/systemd#9118.
@alexshpilkin
nixos/networkd: fix handling of RequiredForOnline
8fdb6fb
@alexshpilkin
nixos/networkd: do not require gateway for routes
ecf7310 
A route via a tunnel interface does not require a gateway to be
specified, so do not check for the Gateway= field on routes at all.
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 6, 2018
@globin globin requested a review from fpletz September 7, 2018 02:46
@fpletz fpletz merged commit 48f2b0c into NixOS:master Sep 7, 2018
@alexshpilkin alexshpilkin deleted the networkd-link-multicast branch October 11, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexshpilkin @fpletz @GrahamcOfBorg