Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghostscript: include icc profile validation patch #46216

Closed
wants to merge 1 commit into from
Closed

ghostscript: include icc profile validation patch #46216

wants to merge 1 commit into from

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Sep 6, 2018 •
edited

Motivation for this change

So I don't get screwed with school because I can't print anything.

CUPS tested after patch (that totally wasn't stolen directly from arch packages) was applied and I can print once again. Issue apple/cups#5394.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@eadwu eadwu force-pushed the ghostscript/cups-profile-validation branch from d9c5c4b to 2aa7506 Compare September 6, 2018 21:59
@eadwu eadwu mentioned this pull request Sep 23, 2018
Closed
@bkchr
Copy link
Contributor

bkchr commented Sep 23, 2018

@viric ping, as you are listed as maintainer.

@flokli flokli mentioned this pull request Oct 5, 2018
Closed
9 tasks
flokli pushed a commit to flokli/nixpkgs that referenced this pull request Oct 5, 2018
@eadwu @flokli
ghostscript: include icc profile validation patch
9a57e00 
See apple/cups#5394

closes NixOS#47193, NixOS#46216

source url
http://git.ghostscript.com/?p=ghostpdl.git;a=patch;h=bc3df0773fcc
contains invalid characters, which is why we don't fetchpatch.

(cherry picked from commit 2aa7506)
@flokli flokli mentioned this pull request Oct 5, 2018
Merged
9 tasks
@andir
Copy link
Member

andir commented Oct 5, 2018

This should be obsolete with the merged PR #47903.

@andir andir closed this Oct 5, 2018
@eadwu eadwu deleted the ghostscript/cups-profile-validation branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eadwu @bkchr @andir @matthewbauer @GrahamcOfBorg