-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
watchexec: darwin support #46313
watchexec: darwin support #46313
Conversation
Thanks for the review @xeji. I hope I fixed all. One of them I don't know how I can do. |
|
||
src = fetchFromGitHub { | ||
owner = "watchexec"; | ||
repo = "watchexec"; | ||
rev = version; | ||
sha256 = "0zp5s2dy5zbar0virvy1izjpvvgwbz7rvjmcy6bph6rb5c4bhm70"; | ||
sha256 = "1jib51dbr6s1iq21inm2xfsjnz1730nyd3af1x977iqivmwdisax"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there something in the sources that results in a different hash on darwin because of case normalisation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like. When I try this locally on x86_64-linux (starting with an all-zeroes hash), I get the original hash "0zp5s...". So @LnL7 what do we do about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't reproduce this hash.
$ nix-build -A watchexec.src --check /src/nixpkgs
these paths will be fetched (0.02 MiB download, 0.11 MiB unpacked):
/nix/store/gh84q49b42kmj94290sswvgcxd648whn-source
copying path '/nix/store/gh84q49b42kmj94290sswvgcxd648whn-source' from 'https://cache.nixos.org'...
checking outputs of '/nix/store/lg5sa2bwasp43vhdxw5kaqav148gf3y6-source.drv'...
trying https://github.com/watchexec/watchexec/archive/1.9.0.tar.gz
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 126 0 126 0 0 115 0 --:--:-- 0:00:01 --:--:-- 115
100 30620 0 30620 0 0 12267 0 --:--:-- 0:00:02 --:--:-- 25537
unpacking source archive /private/tmp/nix-build-source.drv-0/1.9.0.tar.gz
warning: rewriting hashes in '/nix/store/gh84q49b42kmj94290sswvgcxd648whn-source'; cross fingers
fixed-output derivation produced path '/nix/store/7r3rf4dz5cx81qnaiybypbp9nwzcbp2n-source' with sha256 hash '0zp5s2dy5zbar0virvy1izjpvvgwbz7rvjmcy6bph6rb5c4bhm70' instead of the expected hash '1jib51dbr6s1iq21inm2xfsjnz1730nyd3af1x977iqivmwdisax'
error: build of '/nix/store/lg5sa2bwasp43vhdxw5kaqav148gf3y6-source.drv' failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, then let's keep the hash unchanged at 0zp5s2dy5zbar0virvy1izjpvvgwbz7rvjmcy6bph6rb5c4bhm70
because we both get that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose we keep the hash as is, otherwise the linux build might start to fail.
@GrahamcOfBorg build watchexec |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: watchexec Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: watchexec Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: watchexec Partial log (click to expand)
|
@nikitavoloboev somehow |
@xeji changed |
@GrahamcOfBorg build watchexec |
Success on aarch64-linux (full log) Attempted: watchexec Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: watchexec Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: watchexec Partial log (click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you run the same check command, I also get the original hash.
The rest should be good.
Is that okay? |
Hmm, any idea what could be different about your setup? Like a case sensitive filesystem. |
macOS is case insensitive and I am running macOS 10.13.6 Not really sure what can be different. |
You can explicitly install with a case sensitive filesystem if you want. 10.13 means you're probably using APFS, but I tested both that and HFS+ so I have no idea. |
Superseded by #49284 |
Motivation for this change
watchexec
wasn't building correctly on macOS. With help of @LnL7 it does.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)