watchexec: darwin support #46313

nikitavoloboev · 2018-09-07T12:31:42Z

Motivation for this change

watchexec wasn't building correctly on macOS. With help of @LnL7 it does.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

pkgs/tools/misc/watchexec/default.nix

nikitavoloboev · 2018-09-09T18:25:40Z

Thanks for the review @xeji. I hope I fixed all. One of them I don't know how I can do.

LnL7 · 2018-09-09T19:02:30Z

pkgs/tools/misc/watchexec/default.nix


  src = fetchFromGitHub {
    owner = "watchexec";
    repo = "watchexec";
    rev = version;
-    sha256 = "0zp5s2dy5zbar0virvy1izjpvvgwbz7rvjmcy6bph6rb5c4bhm70";
+    sha256 = "1jib51dbr6s1iq21inm2xfsjnz1730nyd3af1x977iqivmwdisax";


Is there something in the sources that results in a different hash on darwin because of case normalisation?

Looks like. When I try this locally on x86_64-linux (starting with an all-zeroes hash), I get the original hash "0zp5s...". So @LnL7 what do we do about it?

I can't reproduce this hash.

$ nix-build -A watchexec.src --check /src/nixpkgs these paths will be fetched (0.02 MiB download, 0.11 MiB unpacked): /nix/store/gh84q49b42kmj94290sswvgcxd648whn-source copying path '/nix/store/gh84q49b42kmj94290sswvgcxd648whn-source' from 'https://cache.nixos.org'... checking outputs of '/nix/store/lg5sa2bwasp43vhdxw5kaqav148gf3y6-source.drv'... trying https://github.com/watchexec/watchexec/archive/1.9.0.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 126 0 126 0 0 115 0 --:--:-- 0:00:01 --:--:-- 115 100 30620 0 30620 0 0 12267 0 --:--:-- 0:00:02 --:--:-- 25537 unpacking source archive /private/tmp/nix-build-source.drv-0/1.9.0.tar.gz warning: rewriting hashes in '/nix/store/gh84q49b42kmj94290sswvgcxd648whn-source'; cross fingers fixed-output derivation produced path '/nix/store/7r3rf4dz5cx81qnaiybypbp9nwzcbp2n-source' with sha256 hash '0zp5s2dy5zbar0virvy1izjpvvgwbz7rvjmcy6bph6rb5c4bhm70' instead of the expected hash '1jib51dbr6s1iq21inm2xfsjnz1730nyd3af1x977iqivmwdisax' error: build of '/nix/store/lg5sa2bwasp43vhdxw5kaqav148gf3y6-source.drv' failed

Well, then let's keep the hash unchanged at 0zp5s2dy5zbar0virvy1izjpvvgwbz7rvjmcy6bph6rb5c4bhm70 because we both get that.

I propose we keep the hash as is, otherwise the linux build might start to fail.

LnL7 · 2018-09-09T20:35:12Z

@GrahamcOfBorg build watchexec

GrahamcOfBorg · 2018-09-09T20:35:43Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: watchexec

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-09-09T20:38:32Z

Success on x86_64-linux (full log)

Attempted: watchexec

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5a9jh5d133drgkgllyb9brdy766mrg5a-watchexec-1.9.0
shrinking /nix/store/5a9jh5d133drgkgllyb9brdy766mrg5a-watchexec-1.9.0/bin/watchexec
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5a9jh5d133drgkgllyb9brdy766mrg5a-watchexec-1.9.0/bin
patching script interpreter paths in /nix/store/5a9jh5d133drgkgllyb9brdy766mrg5a-watchexec-1.9.0
checking for references to /build in /nix/store/5a9jh5d133drgkgllyb9brdy766mrg5a-watchexec-1.9.0...
/nix/store/5a9jh5d133drgkgllyb9brdy766mrg5a-watchexec-1.9.0

GrahamcOfBorg · 2018-09-09T20:42:42Z

Success on aarch64-linux (full log)

Attempted: watchexec

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/cfmdvyhd2gjyjddiya9hib7gb3k7q4qm-watchexec-1.9.0
shrinking /nix/store/cfmdvyhd2gjyjddiya9hib7gb3k7q4qm-watchexec-1.9.0/bin/watchexec
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cfmdvyhd2gjyjddiya9hib7gb3k7q4qm-watchexec-1.9.0/bin
patching script interpreter paths in /nix/store/cfmdvyhd2gjyjddiya9hib7gb3k7q4qm-watchexec-1.9.0
checking for references to /build in /nix/store/cfmdvyhd2gjyjddiya9hib7gb3k7q4qm-watchexec-1.9.0...
/nix/store/cfmdvyhd2gjyjddiya9hib7gb3k7q4qm-watchexec-1.9.0

xeji · 2018-09-09T20:45:45Z

@nikitavoloboev somehow meta platforms is back to platforms.linuxnow, so this won't evaluate on darwin. please set platforms to platforms.unix again.

nikitavoloboev · 2018-09-09T21:20:14Z

@xeji changed

xeji · 2018-09-09T21:21:02Z

@GrahamcOfBorg build watchexec

GrahamcOfBorg · 2018-09-09T21:21:33Z

Success on aarch64-linux (full log)

Attempted: watchexec

Partial log (click to expand)

/nix/store/cfmdvyhd2gjyjddiya9hib7gb3k7q4qm-watchexec-1.9.0

GrahamcOfBorg · 2018-09-09T21:27:25Z

Success on x86_64-darwin (full log)

Attempted: watchexec

Partial log (click to expand)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/4r2mxg1f43c78b06q7xs7k66wjh9kvp8-watchexec-1.9.0/bin
patching script interpreter paths in /nix/store/4r2mxg1f43c78b06q7xs7k66wjh9kvp8-watchexec-1.9.0
/nix/store/4r2mxg1f43c78b06q7xs7k66wjh9kvp8-watchexec-1.9.0

GrahamcOfBorg · 2018-09-09T21:28:00Z

Success on x86_64-linux (full log)

Attempted: watchexec

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5a9jh5d133drgkgllyb9brdy766mrg5a-watchexec-1.9.0
shrinking /nix/store/5a9jh5d133drgkgllyb9brdy766mrg5a-watchexec-1.9.0/bin/watchexec
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5a9jh5d133drgkgllyb9brdy766mrg5a-watchexec-1.9.0/bin
patching script interpreter paths in /nix/store/5a9jh5d133drgkgllyb9brdy766mrg5a-watchexec-1.9.0
checking for references to /build in /nix/store/5a9jh5d133drgkgllyb9brdy766mrg5a-watchexec-1.9.0...
/nix/store/5a9jh5d133drgkgllyb9brdy766mrg5a-watchexec-1.9.0

LnL7

Could you run the same check command, I also get the original hash.

The rest should be good.

nikitavoloboev · 2018-09-11T07:11:57Z

run the same check command

~/Documents/src/clones/nixpkgs watchexec
❯ nix-build -A watchexec.src --check
checking outputs of '/nix/store/lg5sa2bwasp43vhdxw5kaqav148gf3y6-source.drv'...

trying https://github.com/watchexec/watchexec/archive/1.9.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   126    0   126    0     0    142      0 --:--:-- --:--:-- --:--:--   142
100 30620    0 30620    0     0  20801      0 --:--:--  0:00:01 --:--:-- 20801
unpacking source archive /private/tmp/nix-build-source.drv-0/1.9.0.tar.gz
warning: rewriting hashes in '/nix/store/gh84q49b42kmj94290sswvgcxd648whn-source'; cross fingers
/nix/store/gh84q49b42kmj94290sswvgcxd648whn-source

Is that okay?

LnL7 · 2018-09-11T18:29:52Z

Hmm, any idea what could be different about your setup? Like a case sensitive filesystem.

nikitavoloboev · 2018-09-11T18:35:57Z

Like a case sensitive filesystem

macOS is case insensitive and I am running macOS 10.13.6

Not really sure what can be different.

LnL7 · 2018-09-11T18:54:37Z

You can explicitly install with a case sensitive filesystem if you want. 10.13 means you're probably using APFS, but I tested both that and HFS+ so I have no idea.

dywedir · 2019-05-29T07:41:22Z

Superseded by #49284

watchexec: darwin support

260b0f4

GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Sep 7, 2018

nikitavoloboev mentioned this pull request Sep 7, 2018

watchexec: darwin support #46311

Closed

9 tasks

GrahamcOfBorg added 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Sep 7, 2018

xeji reviewed Sep 7, 2018

View reviewed changes

watchexec: fix errors

e930eb7

LnL7 reviewed Sep 9, 2018

View reviewed changes

watchexec: fix errors

625643b

watchexec: fix

b3a2391

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 labels Sep 9, 2018

LnL7 reviewed Sep 10, 2018

View reviewed changes

dywedir closed this May 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

watchexec: darwin support #46313

watchexec: darwin support #46313

nikitavoloboev commented Sep 7, 2018

nikitavoloboev commented Sep 9, 2018

LnL7 Sep 9, 2018

xeji Sep 9, 2018

LnL7 Sep 10, 2018

xeji Sep 10, 2018

LnL7 Sep 12, 2018

LnL7 commented Sep 9, 2018

GrahamcOfBorg commented Sep 9, 2018

GrahamcOfBorg commented Sep 9, 2018

GrahamcOfBorg commented Sep 9, 2018

xeji commented Sep 9, 2018

nikitavoloboev commented Sep 9, 2018

xeji commented Sep 9, 2018

GrahamcOfBorg commented Sep 9, 2018

GrahamcOfBorg commented Sep 9, 2018

GrahamcOfBorg commented Sep 9, 2018

LnL7 left a comment

nikitavoloboev commented Sep 11, 2018

LnL7 commented Sep 11, 2018

nikitavoloboev commented Sep 11, 2018

LnL7 commented Sep 11, 2018

dywedir commented May 29, 2019

watchexec: darwin support #46313

watchexec: darwin support #46313

Conversation

nikitavoloboev commented Sep 7, 2018

Motivation for this change

Things done

nikitavoloboev commented Sep 9, 2018

LnL7 Sep 9, 2018

Choose a reason for hiding this comment

xeji Sep 9, 2018

Choose a reason for hiding this comment

LnL7 Sep 10, 2018

Choose a reason for hiding this comment

xeji Sep 10, 2018

Choose a reason for hiding this comment

LnL7 Sep 12, 2018

Choose a reason for hiding this comment

LnL7 commented Sep 9, 2018

GrahamcOfBorg commented Sep 9, 2018

GrahamcOfBorg commented Sep 9, 2018

GrahamcOfBorg commented Sep 9, 2018

xeji commented Sep 9, 2018

nikitavoloboev commented Sep 9, 2018

xeji commented Sep 9, 2018

GrahamcOfBorg commented Sep 9, 2018

GrahamcOfBorg commented Sep 9, 2018

GrahamcOfBorg commented Sep 9, 2018

LnL7 left a comment

Choose a reason for hiding this comment

nikitavoloboev commented Sep 11, 2018

LnL7 commented Sep 11, 2018

nikitavoloboev commented Sep 11, 2018

LnL7 commented Sep 11, 2018

dywedir commented May 29, 2019