Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gobject-introspection: Fix macos shared lib paths #46312

Closed
wants to merge 162 commits into from

Conversation

hamishmack
Copy link
Contributor

Fixes #40599. This is the similar to #46310, but updated for the gnome-3.30 branch.

I used cat $(nix-build ./default.nix -A atk.dev --system x86_64-darwin)/share/gir-1.0/Atk-1.0.gir | grep shared-library to confirm the issue was still present in the gnome-3.30 branch and to confirm that this patch fixes it.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Sep 10, 2018

@GrahamcOfBorg build gobject-introspection

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: gobject-introspection

Partial log (click to expand)

Cannot nix-instantiate `gobject-introspection' because:
error: attribute 'gobject-introspection' in selection path 'gobject-introspection' not found

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: gobject-introspection

Partial log (click to expand)

Cannot nix-instantiate `gobject-introspection' because:
error: attribute 'gobject-introspection' in selection path 'gobject-introspection' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gobject-introspection

Partial log (click to expand)

Cannot nix-instantiate `gobject-introspection' because:
error: attribute 'gobject-introspection' in selection path 'gobject-introspection' not found

@hamishmack
Copy link
Contributor Author

I have rebased this on latest gnome-3.30 branch.

@jtojnar
Copy link
Contributor

jtojnar commented Dec 1, 2018

#46310 is merged already.

@jtojnar jtojnar closed this Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants