Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libuv: Disable temperamental shutdown_close_pipe test on Aarch32. #46222

Merged
merged 1 commit into from Sep 10, 2018

Conversation

qolii
Copy link
Contributor

@qolii qolii commented Sep 6, 2018

Motivation for this change

One libuv test fails more often than not on my ARMv7 machine. I filed an upstream ticket, but it's not clear what the problem is, and it doesn't seem upstream is going to look at it. Since nobody else is complaining about this, I am assuming it is limited only to ARMv7, and have restricted the change to this arch. I also see that many tests are already disabled in libuv for spurious failures, so I'm hoping a change like this isn't too controversial.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

Yes this is probably harmless to do. It's interesting that it only would happen on aarch32 though? Most likely there is some underlying OS bug that is not closing things properly.

@matthewbauer matthewbauer merged commit bcee562 into NixOS:master Sep 10, 2018
@qolii
Copy link
Contributor Author

qolii commented Sep 10, 2018

Thanks @matthewbauer!

Yeah, I'm afraid I have no insight at all into the cause of this. I've just observed it happening.

I'm glad my "fix" is acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants