Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dde-api: init at 3.1.30 [WIP] #46833

Closed
wants to merge 2 commits into from
Closed

dde-api: init at 3.1.30 [WIP] #46833

wants to merge 2 commits into from

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Sep 18, 2018

Motivation for this change

Add dde-api (Go-lang bindings for dde-daemon).

This is working in progress. Any help with GO language packaging in nixpkgs is welcome.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@romildo
Copy link
Contributor Author

romildo commented Sep 18, 2018

The source distribution has makefiles to do the job. But I am not able to build the package as a go package. go build does not work directly.

I was not able to automatically generate deps.nix. I have handwritten it.

@romildo
Copy link
Contributor Author

romildo commented Sep 18, 2018

The deepin-api package for archlinux may give an idea on what maybe should be done.

@romildo
Copy link
Contributor Author

romildo commented Sep 18, 2018

The nix expression default1.nix is an attempt to do a standard package, instead of a go package.

But with this approach I am stuck at how to get the go library dependencies like gopkg.in/alecthomas/kingpin.v2, github.com/nfnt/resize, and github.com/cryptix/wav golang.org/x/net/context.

@romildo
Copy link
Contributor Author

romildo commented Sep 18, 2018 •
edited

haskell generic builder: enable benchmarks if doBenchmark is true was included by mistake. Sorry.

Maybe someone with the correct rights has to dismiss the requests for review from basvandijk, peti and ryantm as code owners.

@romildo romildo mentioned this pull request Sep 19, 2018
Closed
9 tasks
@romildo romildo closed this Oct 12, 2018
@romildo
Copy link
Contributor Author

romildo commented Oct 12, 2018

Closed in favor of #48262.

@romildo romildo deleted the upd.deepin branch October 12, 2018 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @GrahamcOfBorg