Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3167 — fix docinfo removal for sites that use reST docinfo #3168

Merged
merged 2 commits into from Sep 18, 2018

Conversation

Kwpolska
Copy link
Member

This fixes #3167. cc @gwax.

It seems to work properly now with my testing, but it would be good if someone else also tested it (in particular, title removal with reST docinfo metadata both on and off)

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added the bug label Sep 18, 2018
@Kwpolska Kwpolska requested a review from gwax September 18, 2018 11:55
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added this to the v8.0.1 milestone Sep 18, 2018
Copy link
Contributor

@gwax gwax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that this fixes the problem in my usage.

🚢

@Kwpolska Kwpolska merged commit 7a60483 into master Sep 18, 2018
@Kwpolska Kwpolska deleted the fix-3167 branch September 18, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pelican/Docinfo metadata not removed
2 participants