nixos/release.nix: disable tests.ec2-config #46830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test doesn't work in a sandbox and never succeeded on Hydra. It simulates an EC2 instance reconfiguring itself at runtime, which needs network access.
|
Oh, I didn't realize it was failing. It has passed in the past but I can't look at it right now so disabling it is probably best. |
xeji
added a commit
that referenced
this pull request
Sep 18, 2018
This test doesn't work in a sandbox and never succeeded on Hydra. It simulates an EC2 instance reconfiguring itself at runtime, which needs network access. (cherry picked from commit a83d61b)
|
backported; bc7ec9b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ZHF #45960 , please backport.
This test doesn't work in a sandbox and never succeeded in available Hydra history.
It simulates an EC2 instance reconfiguring itself at runtime with userdata, which apparently needs network access. I tried to fix it by adding missing
system.extraDependenciesbut was unable to get it to work entirely without accessing the network.This disables the test on Hydra.
It can still be run manually and succeeds with sandboxing turned off.
cc @copumpkin who originally wrote the test