adafruit-ampy: Init at 1.0.5 #46836
Closed
adafruit-ampy: Init at 1.0.5 #46836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
Sep 18, 2018
| @@ -0,0 +1,29 @@ | |||
| { stdenv, fetchFromGitHub, buildPythonPackage, pythonPackages }: | |||
There was a problem hiding this comment.
Don't pass in pythonPackages. Instead pass in the individual dependencies.
| pname = "python-dotenv"; | ||
| version = "0.9.1"; | ||
|
|
||
| src = fetchFromGitHub { |
There was a problem hiding this comment.
Is it possible to fetch from Pypi?
| meta = with stdenv.lib; { | ||
| homepage = https://github.com/theskumar/python-dotenv; | ||
| description = "Reads the key,value pair from .env file and adds them to environment variable"; | ||
| platforms = platforms.all; |
There was a problem hiding this comment.
Don't set platforms, it's set already.
| description = "Reads the key,value pair from .env file and adds them to environment variable"; | ||
| platforms = platforms.all; | ||
| license = licenses.bsd3; | ||
| maintainers = []; |
There was a problem hiding this comment.
are you going to maintain this package?
| description = "Utility to interact with a MicroPython board over a serial connection"; | ||
| homepage = https://github.com/adafruit/ampy; | ||
| license = stdenv.lib.licenses.mit; | ||
| maintainers = []; |
There was a problem hiding this comment.
are you going to maintain this package?
| homepage = https://github.com/adafruit/ampy; | ||
| license = stdenv.lib.licenses.mit; | ||
| maintainers = []; | ||
| platforms = stdenv.lib.platforms.unix; |
|
This pull request has been mentioned on Nix community. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adafruit MicroPython Tool (ampy) - Utility to interact with a MicroPython board over a serial connection.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)