Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.JuicyPixels: re-enable Haddock #46837

Merged
merged 1 commit into from Sep 18, 2018
Merged

haskellPackages.JuicyPixels: re-enable Haddock #46837

merged 1 commit into from Sep 18, 2018

Conversation

Taneb
Copy link
Contributor

@Taneb Taneb commented Sep 18, 2018 •
edited

Motivation for this change

This was made to avoid an issue which was fixed in 3.2.9.3 EDIT: 3.2.9.4. The version currently in nixpkgs 18.03 is 3.2.9.4, which includes this fix.

This was confusing us at work!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Taneb
haskellPackages.JuicyPixels: re-enable Haddock
d6dc561 
This was made to avoid an issue which was fixed in `3.2.9.3`. The version currently in `nixpkgs 18.03` is `3.2.9.4`, which includes this fix.
@peti
Copy link
Member

peti commented Sep 18, 2018

@GrahamcOfBorg build haskellPackages.JuicyPixels

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.JuicyPixels

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: haskellPackages.JuicyPixels

Partial log (click to expand)

checking whether we are using the GNU C compiler... yes
checking whether /nix/store/2gdwhdzhy4iwkp7fh8v6gy6nxj1zi9pv-clang-wrapper-5.0.2/bin/cc accepts -g... yes
checking for /nix/store/2gdwhdzhy4iwkp7fh8v6gy6nxj1zi9pv-clang-wrapper-5.0.2/bin/cc option to accept ISO C89... none needed
building of '/nix/store/46rw2p73p964nspa3w3hxl0h1wk72m51-ghc-8.4.3.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/rlnbmqlfsk22cgj3h9k8f9jz4rv1fg0y-hscolour-1.24.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/lx9pm67d9yj4ir9sql2ya5bdpb3mlsj4-primitive-0.6.3.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/7x4l5wqpdk2fv2n29q91zw0y59d7pc1n-zlib-0.6.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/bwfskkw4cgzbj4jzywhcihmqam2nwn1z-vector-0.12.0.1.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/ckgf3h7ib7s1yymnglyzkv4wmk1x879f-JuicyPixels-3.2.9.5.drv': 5 dependencies couldn't be built
error: build of '/nix/store/ckgf3h7ib7s1yymnglyzkv4wmk1x879f-JuicyPixels-3.2.9.5.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: haskellPackages.JuicyPixels

Partial log (click to expand)

"inplace/bin/ghc-stage1" -hisuf p_hi -osuf  p_o -hcsuf p_hc -static -prof -eventlog  -H32m -O -Wall   -Iincludes -Iincludes/dist -Iincludes/dist-derivedconstants/header -Iincludes/dist-ghcconstants/header   -this-unit-id ghc-8.4.3 -hide-all-packages -i -icompiler/backpack -icompiler/basicTypes -icompiler/cmm -icompiler/codeGen -icompiler/coreSyn -icompiler/deSugar -icompiler/ghci -icompiler/hsSyn -icompiler/iface -icompiler/llvmGen -icompiler/main -icompiler/nativeGen -icompiler/parser -icompiler/prelude -icompiler/profiling -icompiler/rename -icompiler/simplCore -icompiler/simplStg -icompiler/specialise -icompiler/stgSyn -icompiler/stranal -icompiler/typecheck -icompiler/types -icompiler/utils -icompiler/vectorise -icompiler/stage2/build -Icompiler/stage2/build -icompiler/stage2/build/./autogen -Icompiler/stage2/build/./autogen -Icompiler/. -Icompiler/parser -Icompiler/utils -Icompiler/../rts/dist/build -Icompiler/stage2 -Icompiler/stage2/build/. -Icompiler/stage2/build/parser -Icompiler/stage2/build/utils -Icompiler/stage2/build/../rts/dist/build -Icompiler/stage2/build/stage2   -optP-DGHCI -optP-include -optPcompiler/stage2/build/./autogen/cabal_macros.h -package-id base-4.11.1.0 -package-id deepseq-1.4.3.0 -package-id directory-1.3.1.5 -package-id process-1.6.3.0 -package-id bytestring-0.10.8.2 -package-id binary-0.8.5.1 -package-id time-1.8.0.2 -package-id containers-0.5.11.0 -package-id array-0.5.2.0 -package-id filepath-1.4.2 -package-id template-haskell-2.13.0.0 -package-id hpc-0.6.0.3 -package-id transformers-0.5.5.0 -package-id ghc-boot-8.4.3 -package-id ghc-boot-th-8.4.3 -package-id ghci-8.4.3 -package-id unix-2.7.2.2 -package-id terminfo-0.4.1.1 -Wall -Wno-name-shadowing -Wnoncanonical-monad-instances -Wnoncanonical-monadfail-instances -Wnoncanonical-monoid-instances -this-unit-id ghc -XHaskell2010 -XNoImplicitPrelude -optc-DTHREADED_RTS -DGHCI_TABLES_NEXT_TO_CODE -DSTAGE=2 -Rghc-timing -O2 -Wcpp-undef  -no-user-package-db -rtsopts       -Wnoncanonical-monad-instances  -odir compiler/stage2/build -hidir compiler/stage2/build -stubdir compiler/stage2/build    -c compiler/prelude/KnownUniques.hs -o compiler/stage2/build/KnownUniques.p_o -dyno compiler/stage2/build/KnownUniques.dyn_o
<<ghc: 354170888 bytes, 58 GCs, 9277005/27007544 avg/max bytes residency (6 samples), 57M in use, 0.000 INIT (0.000 elapsed), 0.300 MUT (0.559 elapsed), 0.196 GC (0.217 elapsed) :ghc>>
"inplace/bin/ghc-stage1" -hisuf p_hi -osuf  p_o -hcsuf p_hc -static -prof -eventlog  -H32m -O -Wall   -Iincludes -Iincludes/dist -Iincludes/dist-derivedconstants/header -Iincludes/dist-ghcconstants/header   -this-unit-id ghc-8.4.3 -hide-all-packages -i -icompiler/backpack -icompiler/basicTypes -icompiler/cmm -icompiler/codeGen -icompiler/coreSyn -icompiler/deSugar -icompiler/ghci -icompiler/hsSyn -icompiler/iface -icompiler/llvmGen -icompiler/main -icompiler/nativeGen -icompiler/parser -icompiler/prelude -icompiler/profiling -icompiler/rename -icompiler/simplCore -icompiler/simplStg -icompiler/specialise -icompiler/stgSyn -icompiler/stranal -icompiler/typecheck -icompiler/types -icompiler/utils -icompiler/vectorise -icompiler/stage2/build -Icompiler/stage2/build -icompiler/stage2/build/./autogen -Icompiler/stage2/build/./autogen -Icompiler/. -Icompiler/parser -Icompiler/utils -Icompiler/../rts/dist/build -Icompiler/stage2 -Icompiler/stage2/build/. -Icompiler/stage2/build/parser -Icompiler/stage2/build/utils -Icompiler/stage2/build/../rts/dist/build -Icompiler/stage2/build/stage2   -optP-DGHCI -optP-include -optPcompiler/stage2/build/./autogen/cabal_macros.h -package-id base-4.11.1.0 -package-id deepseq-1.4.3.0 -package-id directory-1.3.1.5 -package-id process-1.6.3.0 -package-id bytestring-0.10.8.2 -package-id binary-0.8.5.1 -package-id time-1.8.0.2 -package-id containers-0.5.11.0 -package-id array-0.5.2.0 -package-id filepath-1.4.2 -package-id template-haskell-2.13.0.0 -package-id hpc-0.6.0.3 -package-id transformers-0.5.5.0 -package-id ghc-boot-8.4.3 -package-id ghc-boot-th-8.4.3 -package-id ghci-8.4.3 -package-id unix-2.7.2.2 -package-id terminfo-0.4.1.1 -Wall -Wno-name-shadowing -Wnoncanonical-monad-instances -Wnoncanonical-monadfail-instances -Wnoncanonical-monoid-instances -this-unit-id ghc -XHaskell2010 -XNoImplicitPrelude -optc-DTHREADED_RTS -DGHCI_TABLES_NEXT_TO_CODE -DSTAGE=2 -Rghc-timing -O2 -Wcpp-undef  -no-user-package-db -rtsopts       -Wnoncanonical-monad-instances  -odir compiler/stage2/build -hidir compiler/stage2/build -stubdir compiler/stage2/build    -c compiler/vectorise/Vectorise/Builtins/Base.hs -o compiler/stage2/build/Vectorise/Builtins/Base.p_o -dyno compiler/stage2/build/Vectorise/Builtins/Base.dyn_o
building of '/nix/store/v1xad1vxwicn2p30071ykqm1lp9xiskx-ghc-8.4.3.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/nlxvlmyl21ir14izjmg9ikddanzkqlc7-hscolour-1.24.4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/yra49ibxwkhrs72bvp0img73yz39qacj-primitive-0.6.3.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/2rsy9x6zwkssk3kygzgmidf5cmsng4lx-zlib-0.6.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/apmh28xmi0p83linhl1xylyx52bwjdvl-vector-0.12.0.1.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/5hml110ij8wx1j5yn8nhpnafvyb45svl-JuicyPixels-3.2.9.5.drv': 5 dependencies couldn't be built
error: build of '/nix/store/5hml110ij8wx1j5yn8nhpnafvyb45svl-JuicyPixels-3.2.9.5.drv' failed

@basvandijk basvandijk merged commit 8228c78 into NixOS:master Sep 18, 2018
@basvandijk
Copy link
Member

Builds on my machine. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Taneb @peti @GrahamcOfBorg @basvandijk @Janik-Haag