Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coreclr: update homepage #46821

Merged
merged 1 commit into from Sep 18, 2018
Merged

coreclr: update homepage #46821

merged 1 commit into from Sep 18, 2018

Conversation

adamtulinius
Copy link
Member

@adamtulinius adamtulinius commented Sep 18, 2018 •
edited

Repology reports the current homepage down for more than a month. Link to the GitHub repo instead.

Motivation for this change

Current homepage is 404'ing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@adamtulinius
coreclr: update homepage
b3bb82c 
Repology reports the current homepage down for more than a month. Link to the GitHub repo instead.
@srhb
Copy link
Contributor

srhb commented Sep 18, 2018

What about https://dotnet.github.io/ ?

@adamtulinius
Copy link
Member Author

Oh. Didn't even occur to me. I briefly looked through the readme on GitHub, and they didn't seem to link to anything there. I'll update it to https://dotnet.github.io/.

@srhb
Copy link
Contributor

srhb commented Sep 18, 2018 •
edited

Discussed out of band, it doesn't look like the homepage is getting regular updates. Link directly to github is great, since it contains further links to docs etc. and seems to be keep relatively up-to-date.

@srhb
Copy link
Contributor

srhb commented Sep 18, 2018

Thanks! Welcome as a contributor. 😄

@srhb srhb merged commit ffaaac7 into NixOS:master Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adamtulinius @srhb @GrahamcOfBorg @Janik-Haag