Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zita-njbridge: init at 0.4.4 #47382

Merged
merged 1 commit into from Oct 4, 2018
Merged

zita-njbridge: init at 0.4.4 #47382

merged 1 commit into from Oct 4, 2018

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Sep 26, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@globin
Copy link
Member

globin commented Sep 26, 2018

@GrahamcOfBorg builld zita-njbridge

@magnetophon
Copy link
Member Author

@globin any news?

@magnetophon magnetophon mentioned this pull request Oct 3, 2018
Merged
9 tasks
@peterhoeg
Copy link
Member

Looks good to me. I don't use jack so I cannot actually test it but as nothing depends on this, it should be safe to merge.

@peterhoeg peterhoeg merged commit 3f81cb1 into NixOS:master Oct 4, 2018
@magnetophon
Copy link
Member Author

Thanks!

@magnetophon magnetophon deleted the zita-njbridge branch October 4, 2018 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@magnetophon @globin @peterhoeg @GrahamcOfBorg