Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-compute-engine: 20180510 -> 20180905 #47372

Merged
merged 1 commit into from Sep 26, 2018
Merged

google-compute-engine: 20180510 -> 20180905 #47372

merged 1 commit into from Sep 26, 2018

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Sep 25, 2018

Motivation for this change

Fix the GCE daemons. There are still issues but it's better than before.

The google-ip-forwarding-daemon and google-network-setup have been merged to google-network-daemon.

Known issues:

  • The startup service is not executed during startup for some reason which prevents to execute the metadata script
  • SSH keys are not propagating
  • OSLogin isn't installed, this is a new way to authenticate
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@zimbatm
google-compute-engine: 20180510 -> 20180905
216f79d 
The list of corresponding NixOS services are also updated
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: google-compute-engine

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: google-compute-engine

Partial log (click to expand)

patching script interpreter paths in /nix/store/3305ljm7m7a6f1xxwszng5h8sfrkcyal-google-compute-engine-20180905
/nix/store/3305ljm7m7a6f1xxwszng5h8sfrkcyal-google-compute-engine-20180905/bin/optimize_local_ssd: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/3305ljm7m7a6f1xxwszng5h8sfrkcyal-google-compute-engine-20180905/bin/set_multiqueue: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/3305ljm7m7a6f1xxwszng5h8sfrkcyal-google-compute-engine-20180905...
wrapping `/nix/store/3305ljm7m7a6f1xxwszng5h8sfrkcyal-google-compute-engine-20180905/bin/google_metadata_script_runner'...
wrapping `/nix/store/3305ljm7m7a6f1xxwszng5h8sfrkcyal-google-compute-engine-20180905/bin/google_instance_setup'...
wrapping `/nix/store/3305ljm7m7a6f1xxwszng5h8sfrkcyal-google-compute-engine-20180905/bin/google_accounts_daemon'...
wrapping `/nix/store/3305ljm7m7a6f1xxwszng5h8sfrkcyal-google-compute-engine-20180905/bin/google_network_daemon'...
wrapping `/nix/store/3305ljm7m7a6f1xxwszng5h8sfrkcyal-google-compute-engine-20180905/bin/google_clock_skew_daemon'...
/nix/store/3305ljm7m7a6f1xxwszng5h8sfrkcyal-google-compute-engine-20180905

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: google-compute-engine

Partial log (click to expand)

patching script interpreter paths in /nix/store/lkbnci1mjy0s6dafsxm3ay036dk7hl1m-google-compute-engine-20180905
/nix/store/lkbnci1mjy0s6dafsxm3ay036dk7hl1m-google-compute-engine-20180905/bin/optimize_local_ssd: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/lkbnci1mjy0s6dafsxm3ay036dk7hl1m-google-compute-engine-20180905/bin/set_multiqueue: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/lkbnci1mjy0s6dafsxm3ay036dk7hl1m-google-compute-engine-20180905...
wrapping `/nix/store/lkbnci1mjy0s6dafsxm3ay036dk7hl1m-google-compute-engine-20180905/bin/google_clock_skew_daemon'...
wrapping `/nix/store/lkbnci1mjy0s6dafsxm3ay036dk7hl1m-google-compute-engine-20180905/bin/google_network_daemon'...
wrapping `/nix/store/lkbnci1mjy0s6dafsxm3ay036dk7hl1m-google-compute-engine-20180905/bin/google_metadata_script_runner'...
wrapping `/nix/store/lkbnci1mjy0s6dafsxm3ay036dk7hl1m-google-compute-engine-20180905/bin/google_instance_setup'...
wrapping `/nix/store/lkbnci1mjy0s6dafsxm3ay036dk7hl1m-google-compute-engine-20180905/bin/google_accounts_daemon'...
/nix/store/lkbnci1mjy0s6dafsxm3ay036dk7hl1m-google-compute-engine-20180905

@globin globin merged commit 9fb7986 into NixOS:master Sep 26, 2018
@zimbatm zimbatm deleted the google-compute-engine-20180905 branch October 4, 2018 09:33
@zimbatm
Copy link
Member Author

zimbatm commented Oct 4, 2018

cherry-picked to 18.09 as 6e0c9ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimbatm @GrahamcOfBorg @globin