boohu: init at 0.10.0 #47381

ghost · 2018-09-26T02:03:35Z

Motivation for this change

A new roguelike is here!

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

matthewbauer · 2018-09-29T01:57:45Z

@GrahamcOfBorg build boohu

GrahamcOfBorg · 2018-09-29T01:58:00Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: boohu

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-09-29T01:58:05Z

Success on aarch64-linux (full log)

Attempted: boohu

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/9bmc8h9a7k6h3i910l4qv1rm45ghkmag-boohu-0.10.0-bin
shrinking /nix/store/9bmc8h9a7k6h3i910l4qv1rm45ghkmag-boohu-0.10.0-bin/bin/boohu
cannot find section .dynamic
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9bmc8h9a7k6h3i910l4qv1rm45ghkmag-boohu-0.10.0-bin/bin
patching script interpreter paths in /nix/store/9bmc8h9a7k6h3i910l4qv1rm45ghkmag-boohu-0.10.0-bin
checking for references to /build in /nix/store/9bmc8h9a7k6h3i910l4qv1rm45ghkmag-boohu-0.10.0-bin...
cannot find section .dynamic
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
/nix/store/9bmc8h9a7k6h3i910l4qv1rm45ghkmag-boohu-0.10.0-bin

GrahamcOfBorg · 2018-09-29T01:58:48Z

Success on x86_64-linux (full log)

Attempted: boohu

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/l5n635sbmvj0gmhfidpwci6x3qc6jpkl-boohu-0.10.0-bin
shrinking /nix/store/l5n635sbmvj0gmhfidpwci6x3qc6jpkl-boohu-0.10.0-bin/bin/boohu
cannot find section .dynamic
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l5n635sbmvj0gmhfidpwci6x3qc6jpkl-boohu-0.10.0-bin/bin
patching script interpreter paths in /nix/store/l5n635sbmvj0gmhfidpwci6x3qc6jpkl-boohu-0.10.0-bin
checking for references to /build in /nix/store/l5n635sbmvj0gmhfidpwci6x3qc6jpkl-boohu-0.10.0-bin...
cannot find section .dynamic
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/l5n635sbmvj0gmhfidpwci6x3qc6jpkl-boohu-0.10.0-bin

ghost · 2018-10-02T19:45:05Z

@matthewbauer Is my pull request okay? 👽

kalbasit · 2018-10-02T20:47:44Z

pkgs/games/boohu/default.nix

+  goPackagePath = "git.tuxfamily.org/boohu/boohu.git";
+
+  src = fetchurl {
+    url = "https://download.tuxfamily.org/boohu/downloads/boohu-0.10.0.tar.gz";


can you replace 0.10.0 with ${version}?

kalbasit

LGTM, although I don't have permissions to merge it myself. ping @infinisil @xeji @Mic92.

kalbasit · 2018-10-02T23:37:41Z

pkgs/games/boohu/default.nix

+    '';
+    homepage = https://download.tuxfamily.org/boohu/index.html;
+    license = licenses.isc;
+    platforms = platforms.linux;


@freepotion this is a Go app, shouldn't be working on Mac as well? Maybe you should put platforms.unix here?

Done! Although I don't use a Mac, so I can't fully test the result.

Mic92 · 2018-10-03T11:27:09Z

pkgs/games/boohu/default.nix

@@ -0,0 +1,38 @@
+{stdenv, lib, fetchurl, buildGoPackage, ansiTag ? false}:


What does ansi do? And why do we need both versions in nixpkgs?

The basic version uses curses-like library termbox-go.
Ansi version does not need external dependencies. It is more portable and should work on all POSIX systems using stty.
This is similar to nethack and nethack-x11. Normal users don't have to deal with complicated things to build a package with this option. They'll just be able to choose boohu-ansi instead.
Perhaps I should remove platforms? The package seems to be very portable.

We can assume that cgo is present on all platforms we support. After all nix is also written in c++. That's why I would only include the version using tcell.

If we can remove platforms depends whether buildGoPackage sets a default value. Otherwise it will be not build on hydra.

I am still not convinced we need both versions.

Please decide on one. This is not like nethack where one has the choice between a headless version and a x11 version.

I agree with you. PR is here 😎

Mic92 · 2018-10-03T20:55:23Z

@GrahamcOfBorg build boohu boohu-ansi

GrahamcOfBorg · 2018-10-03T20:55:47Z

Success on x86_64-linux (full log)

Attempted: boohu, boohu-ansi

Partial log (click to expand)

shrinking /nix/store/3a5rf09x3qjkn4qmjhc7c3wjd44wsnix-boohu-ansi-0.10.0-bin/bin/boohu-ansi
cannot find section .dynamic
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3a5rf09x3qjkn4qmjhc7c3wjd44wsnix-boohu-ansi-0.10.0-bin/bin
patching script interpreter paths in /nix/store/3a5rf09x3qjkn4qmjhc7c3wjd44wsnix-boohu-ansi-0.10.0-bin
checking for references to /build in /nix/store/3a5rf09x3qjkn4qmjhc7c3wjd44wsnix-boohu-ansi-0.10.0-bin...
cannot find section .dynamic
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
/nix/store/3h184ffmf4h11zyx5ya223xgm72dhnh7-boohu-0.10.0-bin
/nix/store/3a5rf09x3qjkn4qmjhc7c3wjd44wsnix-boohu-ansi-0.10.0-bin

GrahamcOfBorg · 2018-10-03T20:55:48Z

Success on aarch64-linux (full log)

Attempted: boohu, boohu-ansi

Partial log (click to expand)

shrinking /nix/store/sy3f00h68xmikappr9sbnxkz5348b8la-boohu-0.10.0-bin/bin/boohu
cannot find section .dynamic
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sy3f00h68xmikappr9sbnxkz5348b8la-boohu-0.10.0-bin/bin
patching script interpreter paths in /nix/store/sy3f00h68xmikappr9sbnxkz5348b8la-boohu-0.10.0-bin
checking for references to /build in /nix/store/sy3f00h68xmikappr9sbnxkz5348b8la-boohu-0.10.0-bin...
cannot find section .dynamic
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
/nix/store/sy3f00h68xmikappr9sbnxkz5348b8la-boohu-0.10.0-bin
/nix/store/h15xf3k8y8jsi8b5xjvkl66igp5w9v06-boohu-ansi-0.10.0-bin

GrahamcOfBorg · 2018-10-03T20:56:02Z

Success on x86_64-darwin (full log)

Attempted: boohu, boohu-ansi

Partial log (click to expand)

find: '/nix/store/kd2m67by9vwzs680p2vn0sx9l594rb77-boohu-ansi-0.10.0': No such file or directory
find: '/nix/store/bdxf9fja44hkmpzhaxajs6h0rrqipz3a-boohu-0.10.0': No such file or directory
find: '/nix/store/bdxf9fja44hkmpzhaxajs6h0rrqipz3a-boohu-0.10.0': No such file or directory
find: '/nix/store/bdxf9fja44hkmpzhaxajs6h0rrqipz3a-boohu-0.10.0': No such file or directory
find: '/nix/store/bdxf9fja44hkmpzhaxajs6h0rrqipz3a-boohu-0.10.0': No such file or directory
find: '/nix/store/bdxf9fja44hkmpzhaxajs6h0rrqipz3a-boohu-0.10.0': No such file or directory
find: '/nix/store/bdxf9fja44hkmpzhaxajs6h0rrqipz3a-boohu-0.10.0': No such file or directory
find: '/nix/store/bdxf9fja44hkmpzhaxajs6h0rrqipz3a-boohu-0.10.0': No such file or directory
/nix/store/70pzms3gzlssfvrxl4lr4asblmlx94nv-boohu-0.10.0-bin
/nix/store/wpyb39bh7zyadawmspj56k27v81a6m6x-boohu-ansi-0.10.0-bin

ghost · 2018-10-10T02:02:32Z

@matthewbauer Thanks! 👽

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Sep 26, 2018

kalbasit requested changes Oct 2, 2018

View reviewed changes

kalbasit approved these changes Oct 2, 2018

View reviewed changes

kalbasit reviewed Oct 2, 2018

View reviewed changes

GrahamcOfBorg added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 labels Oct 3, 2018

boohu: init at 0.10.0

af08956

Mic92 reviewed Oct 3, 2018

View reviewed changes

matthewbauer merged commit 504953e into NixOS:master Oct 10, 2018

ghost mentioned this pull request Oct 10, 2018

boohu: leave one package #48138

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

boohu: init at 0.10.0 #47381

boohu: init at 0.10.0 #47381

ghost commented Sep 26, 2018

matthewbauer commented Sep 29, 2018

GrahamcOfBorg commented Sep 29, 2018

GrahamcOfBorg commented Sep 29, 2018

GrahamcOfBorg commented Sep 29, 2018

ghost commented Oct 2, 2018 •

edited by ghost

kalbasit Oct 2, 2018

ghost Oct 2, 2018

kalbasit left a comment

kalbasit Oct 2, 2018

ghost Oct 3, 2018

Mic92 Oct 3, 2018

ghost Oct 3, 2018

Mic92 Oct 3, 2018

Mic92 Oct 3, 2018

Mic92 Oct 10, 2018

Mic92 Oct 10, 2018

ghost Oct 10, 2018 •

edited by ghost

Mic92 commented Oct 3, 2018

GrahamcOfBorg commented Oct 3, 2018

GrahamcOfBorg commented Oct 3, 2018

GrahamcOfBorg commented Oct 3, 2018

ghost commented Oct 10, 2018

		@@ -0,0 +1,38 @@
		{stdenv, lib, fetchurl, buildGoPackage, ansiTag ? false}:

boohu: init at 0.10.0 #47381

boohu: init at 0.10.0 #47381

Conversation

ghost commented Sep 26, 2018

Motivation for this change

Things done

matthewbauer commented Sep 29, 2018

GrahamcOfBorg commented Sep 29, 2018

GrahamcOfBorg commented Sep 29, 2018

GrahamcOfBorg commented Sep 29, 2018

ghost commented Oct 2, 2018 • edited by ghost

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kalbasit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost Oct 10, 2018 • edited by ghost

Choose a reason for hiding this comment

Mic92 commented Oct 3, 2018

GrahamcOfBorg commented Oct 3, 2018

GrahamcOfBorg commented Oct 3, 2018

GrahamcOfBorg commented Oct 3, 2018

ghost commented Oct 10, 2018

ghost commented Oct 2, 2018 •

edited by ghost

ghost Oct 10, 2018 •

edited by ghost