Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken darwin packages (f) #47366

Merged
merged 3 commits into from Sep 28, 2018
Merged

broken darwin packages (f) #47366

merged 3 commits into from Sep 28, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Sep 25, 2018

Motivation for this change

Mark various packages linux only or broken on darwin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

    Undefined symbols for architecture x86_64:
      "_MPCreateSemaphore", referenced from:
          FX::FXSemaphore::FXSemaphore(int) in FXThread.o
          FX::FXSemaphore::FXSemaphore(int) in FXThread.o
      "_MPDeleteSemaphore", referenced from:
          FX::FXSemaphore::~FXSemaphore() in FXThread.o
          FX::FXSemaphore::~FXSemaphore() in FXThread.o
      "_MPSignalSemaphore", referenced from:
          FX::FXSemaphore::post() in FXThread.o
      "_MPWaitOnSemaphore", referenced from:
          FX::FXSemaphore::wait() in FXThread.o
          FX::FXSemaphore::trywait() in FXThread.o
    ld: symbol(s) not found for architecture x86_64

/cc ZHF NixOS#45961
Doesn't build on darwin and probably other platforms.

    GsWidget.H:26:3: error: 'Atom' does not name a type; did you mean 'tm'?
       Atom atoms[5];
       ^~~~
       tm
    GsWidget.cxx: In member function 'void GsWidget::setProps()':
    GsWidget.cxx:47:2: error: 'atoms' was not declared in this scope
      atoms[0] = XInternAtom(fl_display,"GHOSTVIEW" , false);
      ^~~~~

/cc ZHF NixOS#45961
Similar to some other builds, sdl-config gets stuck and times out.

    checking for sdl-config... /nix/store/q2hm1ka0qxs2gv5bmrxj7j80lygk4b5z-SDL-1.2.15-dev/bin/sdl-config
    building of '/nix/store/m2d7v0n5hd2498vfxp18i37p7r1lf76p-freedroidrpg-0.16.1' timed out after 7200 seconds of silence

/cc ZHF NixOS#45961
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: flpsed, fox, freedroidrpg

Partial log (click to expand)

copying path '/nix/store/nja6l8zjx7kyw8wq4f635iqplvj7931y-xlibs-wrapper' from 'https://cache.nixos.org'...
copying path '/nix/store/bzafv0iq6lldq0s53clzzxdpik2n0m6q-freeglut-3.0.0' from 'https://cache.nixos.org'...
copying path '/nix/store/3za4gzmhx7fgspnpr6rffl2fwfr2l8jz-fox-1.7.9' from 'https://cache.nixos.org'...
copying path '/nix/store/30876d8rkaasxgpip1yf4pjisqmmgra8-freedroidrpg-0.16.1' from 'https://cache.nixos.org'...
copying path '/nix/store/sdi935bws2b7nxjad1haswljl8lwc2rd-freeglut-3.0.0-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/nd09qf9rawgh368yz4m2y5c6fn29wj72-fltk-1.3.4' from 'https://cache.nixos.org'...
copying path '/nix/store/z6h7k9211vw7yaz02dbwy3di7r96l5zy-flpsed-0.7.3' from 'https://cache.nixos.org'...
/nix/store/z6h7k9211vw7yaz02dbwy3di7r96l5zy-flpsed-0.7.3
/nix/store/3za4gzmhx7fgspnpr6rffl2fwfr2l8jz-fox-1.7.9
/nix/store/30876d8rkaasxgpip1yf4pjisqmmgra8-freedroidrpg-0.16.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: flpsed, fox, freedroidrpg

Partial log (click to expand)

copying path '/nix/store/b1zsd324dd839wiwyqcff8jpi4x2v0qm-SDL-1.2.15-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/wvzb7q7hi2w7srf2804kb8bv6y8z31qk-SDL_gfx-2.0.26' from 'https://cache.nixos.org'...
copying path '/nix/store/z6qgjv0ml3v7x77sd5wi7g4210xfwd9a-SDL_image-1.2.12' from 'https://cache.nixos.org'...
copying path '/nix/store/k8cfd545vzm2rg7qr2gi1wvjnrqnsqjb-flpsed-0.7.3' from 'https://cache.nixos.org'...
copying path '/nix/store/286bm61w0vf2a0c88c703dnhpgxmlmri-smpeg-svn390' from 'https://cache.nixos.org'...
copying path '/nix/store/8fic4mmm96bdfh6wvzmpyi4qf24d1hzq-SDL_mixer-1.2.12' from 'https://cache.nixos.org'...
copying path '/nix/store/flf7l9sbb61hhwafsbw7sfpz3sicn4l9-freedroidrpg-0.16.1' from 'https://cache.nixos.org'...
/nix/store/k8cfd545vzm2rg7qr2gi1wvjnrqnsqjb-flpsed-0.7.3
/nix/store/pbmf470cdgrxsqjr0a8nx6ccnk35ir3c-fox-1.7.9
/nix/store/flf7l9sbb61hhwafsbw7sfpz3sicn4l9-freedroidrpg-0.16.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: freedroidrpg

The following builds were skipped because they don't evaluate on x86_64-darwin: flpsed, fox

Partial log (click to expand)

test -z "/nix/store/kd3v7cfm951n3bx9mr7y0vkygzw3hk2n-freedroidrpg-0.16.1/share/man/man6" || /nix/store/4x7dp4fkx81bf1iw4kphpbfpick844rs-coreutils-8.29/bin/mkdir -p "/nix/store/kd3v7cfm951n3bx9mr7y0vkygzw3hk2n-freedroidrpg-0.16.1/share/man/man6"
 /nix/store/4x7dp4fkx81bf1iw4kphpbfpick844rs-coreutils-8.29/bin/install -c -m 644 freedroidRPG.6 '/nix/store/kd3v7cfm951n3bx9mr7y0vkygzw3hk2n-freedroidrpg-0.16.1/share/man/man6'
make[2]: Leaving directory '/private/tmp/nix-build-freedroidrpg-0.16.1.drv-0/freedroidrpg-0.16.1'
make[1]: Leaving directory '/private/tmp/nix-build-freedroidrpg-0.16.1.drv-0/freedroidrpg-0.16.1'
post-installation fixup
gzipping man pages under /nix/store/kd3v7cfm951n3bx9mr7y0vkygzw3hk2n-freedroidrpg-0.16.1/share/man/
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/kd3v7cfm951n3bx9mr7y0vkygzw3hk2n-freedroidrpg-0.16.1/bin
patching script interpreter paths in /nix/store/kd3v7cfm951n3bx9mr7y0vkygzw3hk2n-freedroidrpg-0.16.1
/nix/store/kd3v7cfm951n3bx9mr7y0vkygzw3hk2n-freedroidrpg-0.16.1

@xeji xeji merged commit 75fd708 into NixOS:master Sep 28, 2018
@xeji
Copy link
Contributor

xeji commented Sep 28, 2018

backported: 3108f74..f5db056

@LnL7 LnL7 deleted the darwin-broken-f branch September 29, 2018 09:35
@@ -1,4 +1,4 @@
{stdenv, fetchurl, fltk13, ghostscript}:
{ stdenv, fetchurl, fltk13, ghostscript, xlibs }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xeji @LnL7
This breaks evaluation with allowAliases = false. For example,

nix-env -qa flpsed -f . --attr-path --arg config '{ allowAliases = false; }'

I'm also confused why this is here, because it's not being used in the derivation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #47700 by removing xlibs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants