Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-2fa: Init at 1.1.0 #47384

Merged
merged 1 commit into from Sep 26, 2018
Merged

go-2fa: Init at 1.1.0 #47384

merged 1 commit into from Sep 26, 2018

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Sep 26, 2018 •
edited

Motivation for this change

Added https://github.com/rsc/2fa

AFAIK Nix does not support attribute names starting with numerals, hence I named the attribute go-2fa, however the name of the "package" is 2fa.
Output of nix search:

Attribute name: nixpkgs.go-2fa
Package name: 2fa
Version: 1.1.0
Description: Two-factor authentication on the command line
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@globin
Copy link
Member

globin commented Sep 26, 2018

@GrahamcOfBorg build go-2fa

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: go-2fa

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/9jajrfkmv38vf12nc1p4j5989k6jksd3-2fa-1.1.0-bin
shrinking /nix/store/9jajrfkmv38vf12nc1p4j5989k6jksd3-2fa-1.1.0-bin/bin/2fa
cannot find section .dynamic
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9jajrfkmv38vf12nc1p4j5989k6jksd3-2fa-1.1.0-bin/bin
patching script interpreter paths in /nix/store/9jajrfkmv38vf12nc1p4j5989k6jksd3-2fa-1.1.0-bin
checking for references to /build in /nix/store/9jajrfkmv38vf12nc1p4j5989k6jksd3-2fa-1.1.0-bin...
cannot find section .dynamic
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
/nix/store/9jajrfkmv38vf12nc1p4j5989k6jksd3-2fa-1.1.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: go-2fa

Partial log (click to expand)

find: '/nix/store/33bqrcradq6kdn5993dnsimw0iciy2ay-2fa-1.1.0': No such file or directory
find: '/nix/store/33bqrcradq6kdn5993dnsimw0iciy2ay-2fa-1.1.0': No such file or directory
find: '/nix/store/33bqrcradq6kdn5993dnsimw0iciy2ay-2fa-1.1.0': No such file or directory
find: '/nix/store/33bqrcradq6kdn5993dnsimw0iciy2ay-2fa-1.1.0': No such file or directory
find: '/nix/store/33bqrcradq6kdn5993dnsimw0iciy2ay-2fa-1.1.0': No such file or directory
find: '/nix/store/33bqrcradq6kdn5993dnsimw0iciy2ay-2fa-1.1.0': No such file or directory
find: '/nix/store/33bqrcradq6kdn5993dnsimw0iciy2ay-2fa-1.1.0': No such file or directory
find: '/nix/store/33bqrcradq6kdn5993dnsimw0iciy2ay-2fa-1.1.0': No such file or directory
find: '/nix/store/33bqrcradq6kdn5993dnsimw0iciy2ay-2fa-1.1.0': No such file or directory
/nix/store/jdn83rf88yr1lsq1n3cwdkwc00jhnyi1-2fa-1.1.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: go-2fa

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/vdjijicfmyvqzn6n5g1phwav0ghsk4gz-2fa-1.1.0-bin
shrinking /nix/store/vdjijicfmyvqzn6n5g1phwav0ghsk4gz-2fa-1.1.0-bin/bin/2fa
cannot find section .dynamic
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vdjijicfmyvqzn6n5g1phwav0ghsk4gz-2fa-1.1.0-bin/bin
patching script interpreter paths in /nix/store/vdjijicfmyvqzn6n5g1phwav0ghsk4gz-2fa-1.1.0-bin
checking for references to /build in /nix/store/vdjijicfmyvqzn6n5g1phwav0ghsk4gz-2fa-1.1.0-bin...
cannot find section .dynamic
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/vdjijicfmyvqzn6n5g1phwav0ghsk4gz-2fa-1.1.0-bin

@globin globin merged commit eb7b217 into NixOS:master Sep 26, 2018
@rvolosatovs rvolosatovs deleted the pkg/2fa branch September 26, 2018 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvolosatovs @globin @GrahamcOfBorg