Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc: Sphinx is a build-time dependency #47363

Merged
merged 1 commit into from Sep 25, 2018
Merged

ghc: Sphinx is a build-time dependency #47363

merged 1 commit into from Sep 25, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Backport of #47362.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: ghc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ghc

Partial log (click to expand)

/nix/store/4rk1ny3wg3rf7bfa8wwc2vmpgdciqpff-ghc-8.4.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ghc

Partial log (click to expand)

/nix/store/n5i1zdpmk2b1s3z96649xh8f9kr3g96s-ghc-8.4.3

matthewbauer
matthewbauer reviewed Sep 25, 2018
View reviewed changes
pkgs/top-level/haskell-packages.nix Outdated
buildLlvmPackages = buildPackages.llvmPackages_37;
llvmPackages = pkgs.llvmPackages_37;
};
ghc822 = callPackage ../development/compilers/ghc/8.2.2.nix {
bootPkgs = packages.ghc821Binary;
sphinx = pkgs.python3Packages.sphinx;
inherit (buildPackages.python27Packages) sphinx;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for the python3 -> python2 change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, bad copy paste.

@Ericson2314 Ericson2314 merged commit 372d0cc into NixOS:release-18.09 Sep 25, 2018
@Ericson2314 Ericson2314 deleted the ghc-sphinx branch September 25, 2018 20:31
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: ghc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ghc

Partial log (click to expand)

/nix/store/4rk1ny3wg3rf7bfa8wwc2vmpgdciqpff-ghc-8.4.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ghc

Partial log (click to expand)

  /nix/store/wm8va53fh5158ipi0ic9gir64hrvqv1z-coreutils-8.29
copying path '/nix/store/wm8va53fh5158ipi0ic9gir64hrvqv1z-coreutils-8.29' from 'https://cache.nixos.org'...
copying path '/nix/store/9ls123vy8ng6dqw29jvgd7lysn381kma-ghc-8.4.3-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/rxaclc3vhxbzgfllv7601i85z854h48a-gmp-6.1.2' from 'https://cache.nixos.org'...
copying path '/nix/store/ipba8r4418ls0j55p5y5gi4zmg2kna5n-gmp-6.1.2-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/6yz7851vibc1xjxpiyfzqqi2ksbv6qah-binutils-wrapper-2.30' from 'https://cache.nixos.org'...
copying path '/nix/store/q9ajsngf2w3r10dg7b1148wzq1avp4gj-perl-5.28.0' from 'https://cache.nixos.org'...
copying path '/nix/store/iw94llkj05wgaz268mlzvgx8jkbi1ss0-gcc-wrapper-7.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/n5i1zdpmk2b1s3z96649xh8f9kr3g96s-ghc-8.4.3' from 'https://cache.nixos.org'...
/nix/store/n5i1zdpmk2b1s3z96649xh8f9kr3g96s-ghc-8.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @GrahamcOfBorg @matthewbauer