Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oraclejdk: remove version 10 #47375

Merged
merged 1 commit into from
Nov 1, 2018
Merged

oraclejdk: remove version 10 #47375

merged 1 commit into from
Nov 1, 2018
+0 −165

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Sep 25, 2018

Motivation for this change

Oracle JDK 10 is no longer supported in favor of JDK 11. Oracle JDK 11 is not free of charge (except for development, testing, prototyping, or demonstration), and free users are guided to use OpenJDK 11.

Alternative: #47321

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@globin
Copy link
Member

globin commented Sep 26, 2018 

error: while evaluating anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-1-lassulus.ewr1.nix.ci/.gc-of-borg-outpaths.nix:39:12, called from undefined position:
while evaluating 'g' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-1-lassulus.ewr1.nix.ci/lib/attrsets.nix:267:19, called from undefined position:
while evaluating anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-1-lassulus.ewr1.nix.ci/pkgs/top-level/release-lib.nix:121:38, called from undefined position:
while evaluating 'isDerivation' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-1-lassulus.ewr1.nix.ci/lib/attrsets.nix:296:18, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-1-lassulus.ewr1.nix.ci/pkgs/top-level/release-lib.nix:123:10:
while evaluating 'callPackageWith' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-1-lassulus.ewr1.nix.ci/lib/customisation.nix:108:35, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-1-lassulus.ewr1.nix.ci/pkgs/top-level/all-packages.nix:7992:17:
while evaluating 'makeOverridable' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-1-lassulus.ewr1.nix.ci/lib/customisation.nix:67:24, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-1-lassulus.ewr1.nix.ci/lib/customisation.nix:112:8:
undefined variable 'jdk10' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-1-lassulus.ewr1.nix.ci/pkgs/top-level/all-packages.nix:7995:14

@jbgi
Copy link
Contributor

jbgi commented Sep 27, 2018

Can we wait for openjdk11 to be packaged and merged (someone working on it?) before merging this one?

@taku0 taku0 force-pushed the remove_oraclejdk_10 branch from af662b8 to b683af4 Compare September 27, 2018 14:39
@taku0
Copy link
Contributor Author

taku0 commented Sep 27, 2018

eclipses and bazel_jdk10 depend on jdk10. Maybe we should wait for openjdk11 and/or mark jdk 10 as insecure (#47321) before merging this PR.

@jerith666
Copy link
Contributor

started hacking on openjdk11 at https://github.com/jerith666/nixpkgs/tree/jdk11; not building yet

@fpletz fpletz mentioned this pull request Oct 11, 2018
Merged
9 tasks
@NeQuissimus
Copy link
Member

@jerith666 I'd be very interested in JDK11. Can you make your progress a PR, so it's easier to review? I'll try to help where I can.

@taku0 taku0 mentioned this pull request Oct 13, 2018
Merged
9 tasks
@taku0
Copy link
Contributor Author

taku0 commented Oct 13, 2018

Added AdoptOpenJDK binary package (#48322).

@jerith666 how about using AdoptOpenJDK build script? https://github.com/AdoptOpenJDK/openjdk-build

@flokli
Copy link
Contributor

flokli commented Oct 13, 2018

jdk10 from all-packages is also set to oraclejdk10 on aarch32 and aarch64.

@jerith666
Copy link
Contributor

Okay, I've opened #48326 with what I have so far. It builds, but still has major TODOs associated with it. Any help is of course appreciated! :)

@fpletz fpletz force-pushed the remove_oraclejdk_10 branch from b683af4 to 15692e6 Compare November 1, 2018 11:39
@fpletz
Copy link
Member

fpletz commented Nov 1, 2018

Rebased on top of current master and fixed conflicts.

@fpletz fpletz added 1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: clean-up labels Nov 1, 2018
@fpletz
Copy link
Member

fpletz commented Nov 1, 2018

I'd say let's merge this into master but keep oraclejdk10 marked as vulnerable from #47321 in 18.09.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 1, 2018
@fpletz fpletz merged commit 68cf3df into NixOS:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@taku0 @globin @jbgi @jerith666 @NeQuissimus @flokli @fpletz @GrahamcOfBorg