Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perl-Module-Build-XSUtil: fix darwin build #46501

Merged
merged 2 commits into from Sep 11, 2018
Merged

perl-Module-Build-XSUtil: fix darwin build #46501

merged 2 commits into from Sep 11, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Sep 10, 2018

Motivation for this change

Fixes the darwin build.

While building the tests LD gets called with -mmacosx-version-min=10.10
which is a CC flag, causing the build to fail with LD=ld. This is
pretty common with perl packages.

/cc ZHF #45961

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
perl-Module-Build-XSUtil: fix darwin build
dc6b36b 
While building the tests LD gets called with -mmacosx-version-min=10.10
which is a CC flag, causing the build to fail with LD=ld.  This is
pretty common with perl packages.

/cc ZHF NixOS#45961
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Sep 10, 2018
@samueldr
Copy link
Member

Picking from here: https://gist.github.com/samueldr/6ffc78608006aa22a8d7de292d062cb1#problematic-dependencies

@GrahamcOfBorg build freecell-solver perl528Packages.HTMLFormHandler perl522Packages.TestMagpie perl526Packages.CatalystRuntime perl524Packages.NetCoverArtArchive

Mix and matched between perls, except for freecell-solver.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: freecell-solver, perl528Packages.HTMLFormHandler, perl522Packages.TestMagpie, perl526Packages.CatalystRuntime, perl524Packages.NetCoverArtArchive

Partial log (click to expand)

Moving /nix/store/3x8l8w9j48dpb42xzp2c322m38wyy7f4-perl5.26.2-Plack-Test-ExternalServer-0.02/share/man/man3 to /nix/store/zjg52gj13y9p5n2vi0ypx260ykxxzb8d-perl5.26.2-Plack-Test-ExternalServer-0.02-devdoc/share/man/man3
Removing empty /nix/store/3x8l8w9j48dpb42xzp2c322m38wyy7f4-perl5.26.2-Plack-Test-ExternalServer-0.02/share/man/ and (possibly) its parents
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/3x8l8w9j48dpb42xzp2c322m38wyy7f4-perl5.26.2-Plack-Test-ExternalServer-0.02/lib
patching script interpreter paths in /nix/store/3x8l8w9j48dpb42xzp2c322m38wyy7f4-perl5.26.2-Plack-Test-ExternalServer-0.02
gzipping man pages under /nix/store/zjg52gj13y9p5n2vi0ypx260ykxxzb8d-perl5.26.2-Plack-Test-ExternalServer-0.02-devdoc/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/zjg52gj13y9p5n2vi0ypx260ykxxzb8d-perl5.26.2-Plack-Test-ExternalServer-0.02-devdoc
cannot build derivation '/nix/store/rksmwaypaw3x4jg380kl6r6163z1dwjc-perl5.26.2-Catalyst-Runtime-5.90118.drv': 4 dependencies couldn't be built
error: build of '/nix/store/3i9qdmrj58xw8ig1j90lsl20z97q7lqk-perl5.22.4-Test-Magpie-0.11.drv', '/nix/store/64n655cag857bwhfsiyfsw4wk56ypins-perl5.28.0-HTML-FormHandler-0.40068.drv', '/nix/store/brdq6vgk3r5ik8znw03w93wmv8v9h308-freecell-solver-4.18.0.drv', '/nix/store/fs215izbyqyirh9c362ypnbqhfjia4fg-perl5.24.4-Net-CoverArtArchive-1.02.drv', '/nix/store/rksmwaypaw3x4jg380kl6r6163z1dwjc-perl5.26.2-Catalyst-Runtime-5.90118.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: freecell-solver, perl528Packages.HTMLFormHandler, perl522Packages.TestMagpie, perl526Packages.CatalystRuntime, perl524Packages.NetCoverArtArchive

Partial log (click to expand)

/nix/store/186wzz4r3i4rkai54cbqli1k5ymls1y8-freecell-solver-4.18.0/bin/fc_solve_find_index_s2ints.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python3"
/nix/store/186wzz4r3i4rkai54cbqli1k5ymls1y8-freecell-solver-4.18.0/bin/make_pysol_freecell_board.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python3"
/nix/store/186wzz4r3i4rkai54cbqli1k5ymls1y8-freecell-solver-4.18.0/bin/find-freecell-deal-index.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python3"
/nix/store/186wzz4r3i4rkai54cbqli1k5ymls1y8-freecell-solver-4.18.0/bin/transpose-freecell-board.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/186wzz4r3i4rkai54cbqli1k5ymls1y8-freecell-solver-4.18.0...
/nix/store/186wzz4r3i4rkai54cbqli1k5ymls1y8-freecell-solver-4.18.0
/nix/store/kn3g94dn8vqn97bi8d6wjf1jg2giz8zr-perl5.28.0-HTML-FormHandler-0.40068
/nix/store/5zmrv7q17af4x7v65v82vx09qm6iz1v5-perl5.22.4-Test-Magpie-0.11
/nix/store/chfr92xa4zjrld5psacbfx0z79yhv6cw-perl5.26.2-Catalyst-Runtime-5.90118
/nix/store/db1q3whxkswfbqgh6ac6vn4pq80b7ms8-perl5.24.4-Net-CoverArtArchive-1.02

@LnL7
Copy link
Member Author

LnL7 commented Sep 10, 2018

@GrahamcOfBorg build freecell-solver perl528Packages.HTMLFormHandler perl522Packages.TestMagpie perl526Packages.CatalystRuntime perl524Packages.NetCoverArtArchive

@LnL7
Copy link
Member Author

LnL7 commented Sep 10, 2018

Building perl packages is pretty quick so even tho this rebuilds a lot it's probably ok for master.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: freecell-solver, perl528Packages.HTMLFormHandler, perl522Packages.TestMagpie, perl526Packages.CatalystRuntime, perl524Packages.NetCoverArtArchive

Partial log (click to expand)

Moving /nix/store/q3gkp633ns6qjcrfq95k7fdslxp6v8x5-perl5.26.2-Catalyst-Runtime-5.90118/share/man/man3 to /nix/store/ljvx2yzsh95bzdkhsc30rcf22rcalcr1-perl5.26.2-Catalyst-Runtime-5.90118-devdoc/share/man/man3
rmdir: failed to remove '/nix/store/q3gkp633ns6qjcrfq95k7fdslxp6v8x5-perl5.26.2-Catalyst-Runtime-5.90118/share/man': Directory not empty
gzipping man pages under /nix/store/q3gkp633ns6qjcrfq95k7fdslxp6v8x5-perl5.26.2-Catalyst-Runtime-5.90118/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/q3gkp633ns6qjcrfq95k7fdslxp6v8x5-perl5.26.2-Catalyst-Runtime-5.90118/lib  /nix/store/q3gkp633ns6qjcrfq95k7fdslxp6v8x5-perl5.26.2-Catalyst-Runtime-5.90118/bin
patching script interpreter paths in /nix/store/q3gkp633ns6qjcrfq95k7fdslxp6v8x5-perl5.26.2-Catalyst-Runtime-5.90118
gzipping man pages under /nix/store/ljvx2yzsh95bzdkhsc30rcf22rcalcr1-perl5.26.2-Catalyst-Runtime-5.90118-devdoc/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/ljvx2yzsh95bzdkhsc30rcf22rcalcr1-perl5.26.2-Catalyst-Runtime-5.90118-devdoc
error: build of '/nix/store/7fr3asvzwy49gvlkklgg008g9in3vjd9-freecell-solver-4.18.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: freecell-solver, perl528Packages.HTMLFormHandler, perl522Packages.TestMagpie, perl526Packages.CatalystRuntime, perl524Packages.NetCoverArtArchive

Partial log (click to expand)

/nix/store/47lqv2zd9dflw2ar1w3gzqx2hfprj3w9-freecell-solver-4.18.0/bin/fc_solve_find_index_s2ints.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python3"
/nix/store/47lqv2zd9dflw2ar1w3gzqx2hfprj3w9-freecell-solver-4.18.0/bin/make_pysol_freecell_board.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python3"
/nix/store/47lqv2zd9dflw2ar1w3gzqx2hfprj3w9-freecell-solver-4.18.0/bin/find-freecell-deal-index.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python3"
/nix/store/47lqv2zd9dflw2ar1w3gzqx2hfprj3w9-freecell-solver-4.18.0/bin/transpose-freecell-board.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/47lqv2zd9dflw2ar1w3gzqx2hfprj3w9-freecell-solver-4.18.0...
/nix/store/47lqv2zd9dflw2ar1w3gzqx2hfprj3w9-freecell-solver-4.18.0
/nix/store/j4fi5xprkv2i6iyalp2vis30gpliz1ad-perl5.28.0-HTML-FormHandler-0.40068
/nix/store/q24g1vrbw197c94balfflk6xkgq00wgg-perl5.22.4-Test-Magpie-0.11
/nix/store/0ckz7hd7kr70m04zgf76hsp2g41297fj-perl5.26.2-Catalyst-Runtime-5.90118
/nix/store/ilydd9cl9wgvbrg8cjhvqavqwl7q5731-perl5.24.4-Net-CoverArtArchive-1.02

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: freecell-solver, perl528Packages.HTMLFormHandler, perl522Packages.TestMagpie, perl526Packages.CatalystRuntime, perl524Packages.NetCoverArtArchive

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/9610lzggfiipp8ga9nyl5cx41fjlyx9s-perl5.26.2-Catalyst-Runtime-5.90118-devdoc
gzipping man pages under /nix/store/9610lzggfiipp8ga9nyl5cx41fjlyx9s-perl5.26.2-Catalyst-Runtime-5.90118-devdoc/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/9610lzggfiipp8ga9nyl5cx41fjlyx9s-perl5.26.2-Catalyst-Runtime-5.90118-devdoc
checking for references to /build in /nix/store/9610lzggfiipp8ga9nyl5cx41fjlyx9s-perl5.26.2-Catalyst-Runtime-5.90118-devdoc...
/nix/store/m4m82gvihpdm5xz1rlidqi58ihin595j-freecell-solver-4.18.0
/nix/store/5fqa3dhszkfgbpdjp9s4bh5y9yk8nl7c-perl5.28.0-HTML-FormHandler-0.40068
/nix/store/04x7nxfhhbm8a5cgw7z655s1rj2fmhzr-perl5.22.4-Test-Magpie-0.11
/nix/store/lm01c8ysw2r7xpcpzm1p2nk0c4xzj43y-perl5.26.2-Catalyst-Runtime-5.90118
/nix/store/89s9zsxvvpj0kvw2cga39ddcgj0by3ip-perl5.24.4-Net-CoverArtArchive-1.02

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: freecell-solver, perl528Packages.HTMLFormHandler, perl522Packages.TestMagpie, perl526Packages.CatalystRuntime, perl524Packages.NetCoverArtArchive

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/ynfdglmnviirmn6d6371d7xdpsc9fnap-perl5.26.2-Catalyst-Runtime-5.90118-devdoc
gzipping man pages under /nix/store/ynfdglmnviirmn6d6371d7xdpsc9fnap-perl5.26.2-Catalyst-Runtime-5.90118-devdoc/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/ynfdglmnviirmn6d6371d7xdpsc9fnap-perl5.26.2-Catalyst-Runtime-5.90118-devdoc
checking for references to /build in /nix/store/ynfdglmnviirmn6d6371d7xdpsc9fnap-perl5.26.2-Catalyst-Runtime-5.90118-devdoc...
/nix/store/qw6h4i7gidizi7sg58jdhvgpmyhrsa2j-freecell-solver-4.18.0
/nix/store/2jy13sn2gxcp5xyzm8da2nc5avk4b882-perl5.28.0-HTML-FormHandler-0.40068
/nix/store/1r2i6n8nql5nfhr1a0pd5smqzf86if7y-perl5.22.4-Test-Magpie-0.11
/nix/store/2c7dlmnjv9wva2rwndpwl672p9kzdnf9-perl5.26.2-Catalyst-Runtime-5.90118
/nix/store/xkzjyhpnzjp04xi9sd463h5zdw38m7bv-perl5.24.4-Net-CoverArtArchive-1.02

@Mic92
Copy link
Member

Mic92 commented Sep 11, 2018

@samueldr how did you generate the report?

xeji
xeji approved these changes Sep 11, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this can go directly to master.

@samueldr
Copy link
Member

@Mic92 #45960 (comment)

Thing I literally wrote last week for ZHF, and keep making it better. I pledge (again) to get the code out by this week-end.

@samueldr samueldr merged commit 288f9c6 into NixOS:master Sep 11, 2018
@LnL7 LnL7 deleted the darwin-perl-Module-Build-XSUtil branch September 11, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LnL7 @samueldr @GrahamcOfBorg @Mic92 @xeji