Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/feedback request: add SSB tale:net #46521

Closed
wants to merge 3 commits into from

Conversation

cryptix
Copy link
Contributor

@cryptix cryptix commented Sep 11, 2018

Motivation for this change

Opening this as a source-version of #46062 and to gather feedback on the approach. I'm still fairly novice in writing nix expressions and derivations but @NinjaTrappeur suggested I take over patchwork since I'm familiar with the project as a whole and have built an electron client myself. @samueldr also suggested in this comment that a source version would be preferable.

tale:net is not http://github.com/ssbc/patchwork/ but very similar in architecture and spirit. They are both based on http://scuttlebutt.nz/ and are electron apps. Once I figure out the remaining questions, I can adapt the same recipe for patchwork and patchbay

Also: This depends on #45997 but could be decoupled. I thought it would just be easier to test this with both new packages present.

ps: See #46000 for two standalone tools without electron

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Question:

  • Is the node2nix sub package approach sane?

Previously, I just used this shell.nix to develop. In it, I can run npm i && npm run build (which is an alias for node .electron-vue/build.js && electron-builder) and run dev to make builts and development versions.

I discussed with @NinjaTrappeur that this invovles fetching a pre-built electron version from npmjs.com. I'd rather not do this.

In principle it is enough to run node .electron-vue/build.js && cd ./dist/electron && electron . and this can work on archlinux, when all the node and electron ABI versions correctly line up.

I'm having trouble understanding how to do the npm i && node .electron-vue/build.js with node2nix, though. I generated the env from the source package.json and made some changes to it so that it doesn't import nixpkgs twice. The output looks fine but I'm not sure yet how to copy node_modules into this out/ or if I should run the node .electron-vue/build.js in the embedded node env.

  • re systrayhelper: init at 0.0.3 #45997: is propagateBuildInputs the correct method to have this package as a runtime-dependency to talenet or should add something to the fixupPhase of the node-env?

offers a stdio json interface to create menu-items.
and send click events back over stdout.
(will squash these once review is done.)
let
# might become a problem with electron once this builds
# just a workaround anyway: https://github.com/svanderburg/node2nix/issues/106#issuecomment-418707444
nodejs = nodejs-6_x;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check if this has been solved?

Copy link
Contributor Author

@cryptix cryptix Dec 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried again with @svanderburg new version but still run into ENOTCACHED (ansi-styles).

My current WIP is here: talenet/talenet#35

@mmahut
Copy link
Member

mmahut commented Aug 25, 2019

Are there any updates on this pull request, please?

@cryptix
Copy link
Contributor Author

cryptix commented Oct 2, 2019

Sadly no. This project isn’t under active development currently.

@cryptix cryptix closed this Oct 2, 2019
@cryptix cryptix deleted the add/ssbtalenet branch January 12, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants