Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.03] firefox: provide clang configure flags on i686 #46511

Merged
merged 1 commit into from Sep 11, 2018

Conversation

andir
Copy link
Member

@andir andir commented Sep 11, 2018

Motivation for this change

With the upgrade to firefox 62 (and potentially before) clang flags are now required on i686.

This might just work as it is. I haven't had the time to run/check for rebuilds. I intend to do that in the evening / during the day.

It seems that this would also be required on stable and the 18.09 release branch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

With the upgrade to firefox 62 clang flags are now required on i686.
@andir andir changed the title [18.03] WIP: firefox: provide clang configure flags on i686 [18.03] firefox: provide clang configure flags on i686 Sep 11, 2018
@andir
Copy link
Member Author

andir commented Sep 11, 2018

Compiles and runs on my machine.

@andir andir merged commit dab31f2 into NixOS:release-18.03 Sep 11, 2018
@andir andir deleted the 18.03/firefox-i686 branch September 11, 2018 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants