Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-vault: 4.1.0 -> 4.3.0, pass linker flag for specifying app version #46503

Merged
merged 2 commits into from Sep 11, 2018
Merged

aws-vault: 4.1.0 -> 4.3.0, pass linker flag for specifying app version #46503

merged 2 commits into from Sep 11, 2018

Conversation

ento
Copy link
Contributor

@ento ento commented Sep 11, 2018

Motivation for this change

Among other things, brings in fixes for compilation issues:

  • v4.3.0

    Update go-keychain to resolve Go 1.11 compilation issue

  • v4.2.1

    compatibility with go 1.10

  • v4.2.0

The linker flag makes it so that you get back the correct version string when you specify --version:

$ aws-vault --version
v4.3.0
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Sep 11, 2018

@GrahamcOfBorg build aws-vault

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: aws-vault

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/x0q3ndacvbqs1wfjaw895dyv80n2f5qa-aws-vault-4.3.0-bin
shrinking /nix/store/x0q3ndacvbqs1wfjaw895dyv80n2f5qa-aws-vault-4.3.0-bin/bin/aws-vault
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/x0q3ndacvbqs1wfjaw895dyv80n2f5qa-aws-vault-4.3.0-bin/bin
patching script interpreter paths in /nix/store/x0q3ndacvbqs1wfjaw895dyv80n2f5qa-aws-vault-4.3.0-bin
checking for references to /build in /nix/store/x0q3ndacvbqs1wfjaw895dyv80n2f5qa-aws-vault-4.3.0-bin...
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
/nix/store/x0q3ndacvbqs1wfjaw895dyv80n2f5qa-aws-vault-4.3.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: aws-vault

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rfr19y9zmxwxj44m6lknma85lx5pipcx-aws-vault-4.3.0-bin
shrinking /nix/store/rfr19y9zmxwxj44m6lknma85lx5pipcx-aws-vault-4.3.0-bin/bin/aws-vault
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rfr19y9zmxwxj44m6lknma85lx5pipcx-aws-vault-4.3.0-bin/bin
patching script interpreter paths in /nix/store/rfr19y9zmxwxj44m6lknma85lx5pipcx-aws-vault-4.3.0-bin
checking for references to /build in /nix/store/rfr19y9zmxwxj44m6lknma85lx5pipcx-aws-vault-4.3.0-bin...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/rfr19y9zmxwxj44m6lknma85lx5pipcx-aws-vault-4.3.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: aws-vault

Partial log (click to expand)

find: '/nix/store/9r3nvi23algcla74qj72iqa2976rcjv4-aws-vault-4.3.0': No such file or directory
find: '/nix/store/9r3nvi23algcla74qj72iqa2976rcjv4-aws-vault-4.3.0': No such file or directory
find: '/nix/store/9r3nvi23algcla74qj72iqa2976rcjv4-aws-vault-4.3.0': No such file or directory
find: '/nix/store/9r3nvi23algcla74qj72iqa2976rcjv4-aws-vault-4.3.0': No such file or directory
find: '/nix/store/9r3nvi23algcla74qj72iqa2976rcjv4-aws-vault-4.3.0': No such file or directory
find: '/nix/store/9r3nvi23algcla74qj72iqa2976rcjv4-aws-vault-4.3.0': No such file or directory
find: '/nix/store/9r3nvi23algcla74qj72iqa2976rcjv4-aws-vault-4.3.0': No such file or directory
find: '/nix/store/9r3nvi23algcla74qj72iqa2976rcjv4-aws-vault-4.3.0': No such file or directory
find: '/nix/store/9r3nvi23algcla74qj72iqa2976rcjv4-aws-vault-4.3.0': No such file or directory
/nix/store/cn8rpx8wcfipllgcqa8jc66smgkvw5zl-aws-vault-4.3.0-bin

@srhb
Copy link
Contributor

srhb commented Sep 11, 2018

Thank you! :)

@srhb srhb merged commit 5984aae into NixOS:master Sep 11, 2018
srhb added a commit that referenced this pull request Sep 11, 2018
@srhb
Merge pull request #46503 from ento/aws-vault-4-3-0
c36aedb 
aws-vault: 4.1.0 -> 4.3.0, pass linker flag for specifying app version
(cherry picked from commit 5984aae)
@ento ento deleted the aws-vault-4-3-0 branch September 11, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ento @srhb @GrahamcOfBorg @Janik-Haag