Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texFunctions: Fix lhs2tex helper derivation #46513

Closed
wants to merge 1 commit into from
Closed

texFunctions: Fix lhs2tex helper derivation #46513

wants to merge 1 commit into from

Conversation

arianvp
Copy link
Member

@arianvp arianvp commented Sep 11, 2018

The package lhs2tex function was moved to haskellPackages.lhs2tex
quite some time ago, and stdenv.bash does not exist anymore either.
This simply seems to have been a case of code rot of code that
wasn't used in quite a long time.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@arianvp
texFunctions: Fix lhs2tex helper derivation
f92d0f2 
The package lhs2tex function was moved to haskellPackages.lhs2tex
quite some time ago, and  stdenv.bash does not exist anymore either.
This simply seems to have been a case of code rot of code that
wasn't used in quite a long time.
@arianvp
Copy link
Member Author

arianvp commented Sep 11, 2018

This is WIP, as the lhs2tex package actually seems broken on master :)

@arianvp
Copy link
Member Author

arianvp commented Sep 11, 2018

Coincidentally, a fix for this was pushed upstream here a few hours ago:

kosmikus/lhs2tex#69:

It wasn't caught because Hydra doesn't build lhs2tex:

b6b13e4

I'm not sure what 'assertion error' the commit seems to refer to, but I think it's safe to remove the dontDistribute stanza
However, I don't see a reason not to build it. lhs2tex is fully standalone, and doesn't depend on any texlive package.

@arianvp
Copy link
Member Author

arianvp commented Sep 11, 2018

How often does the hackage2nix script run? As this fix was pushed to hackage a few hours ago

@mmahut
Copy link
Member

mmahut commented Aug 7, 2019

Any updates on this pull request, please?

@arianvp
Copy link
Member Author

arianvp commented Aug 8, 2019

You could try rebase it on master and see if it works! I think it should. Then we can get this merged.

I currently don't actively use LaTeX anymore so I had totally forgotten about this pr

@mmahut
Copy link
Member

mmahut commented Aug 8, 2019

Thank you. If anyone is interested in this, feel free to re-open this pull request.

@mmahut mmahut closed this Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arianvp @mmahut @GrahamcOfBorg @xeji