Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pytestflakes: fix build #46500

Merged
merged 1 commit into from Sep 11, 2018
Merged

pythonPackages.pytestflakes: fix build #46500

merged 1 commit into from Sep 11, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 10, 2018

Motivation for this change

ZHF #45960

  • disable a failing test case that looks broken
  • remove pytestcache depencency that was dropped upstream
Things done
  • built on NixOS in a sandbox

@xeji xeji requested a review from FRidh as a code owner September 10, 2018 21:33
@xeji
Copy link
Contributor Author

xeji commented Sep 10, 2018

@GrahamcOfBorg build python27Packages.pytestflakes python36Packages.pytestflakes

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.pytestflakes, python36Packages.pytestflakes

Partial log (click to expand)

platform linux -- Python 3.6.6, pytest-3.7.4, py-1.5.4, pluggy-0.7.1
rootdir: /build/pytest-flakes-4.0.0, inifile: tox.ini
plugins: flakes-4.0.0, pep8-1.0.6
collected 6 items

test_flakes.py ......

=========================== 6 passed in 0.22 seconds ===========================
/nix/store/s56yrkpa5knf4ra519879yxb81rxw0hh-python2.7-pytest-flakes-4.0.0
/nix/store/gknxjf368g4cdnqbgnm0hrjsdxvwbsh5-python3.6-pytest-flakes-4.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.pytestflakes, python36Packages.pytestflakes

Partial log (click to expand)

collected 6 items

test_flakes.py ......

=========================== 6 passed in 0.22 seconds ===========================
test_flakes.py ......

=========================== 6 passed in 0.22 seconds ===========================
/nix/store/l9sy8yjxba5vacf54p24van4h3yy8340-python2.7-pytest-flakes-4.0.0
/nix/store/pgqfkbphjgbjfzrwwp3mylwkzxmbm2yb-python3.6-pytest-flakes-4.0.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.pytestflakes, python36Packages.pytestflakes

Partial log (click to expand)

platform linux -- Python 3.6.6, pytest-3.7.4, py-1.5.4, pluggy-0.7.1
rootdir: /build/pytest-flakes-4.0.0, inifile: tox.ini
plugins: flakes-4.0.0, pep8-1.0.6
collected 6 items

test_flakes.py ......

=========================== 6 passed in 1.04 seconds ===========================
/nix/store/dknqmkkykmwis5v8hjc1bsr8iiimz6gz-python2.7-pytest-flakes-4.0.0
/nix/store/xywpabmyrwj2waacggh4chnl5wvwam63-python3.6-pytest-flakes-4.0.0

Mic92
Mic92 reviewed Sep 11, 2018
View reviewed changes
pkgs/development/python-modules/pytest-flakes/default.nix Outdated
# disable one test case that looks broken
postPatch = ''
substituteInPlace test_flakes.py --replace "test_syntax_error" "notest_syntax_error"
'';

checkPhase = ''
py.test test_flakes.py
Copy link
Member

@Mic92 Mic92 Sep 11, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py.test tests -k 'not test_syntax_error' is preferred here over substituteInPlace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, done.

@xeji
pythonPackages.pytestflakes: fix build
d455ad6 
- disable a failing test case that looks broken
- remove pytestcache depencency that was dropped upstream
@xeji
Copy link
Contributor Author

xeji commented Sep 11, 2018

@GrahamcOfBorg build python27Packages.pytestflakes python36Packages.pytestflakes

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.pytestflakes, python36Packages.pytestflakes

Partial log (click to expand)

test_flakes.py ......

==================== 6 passed, 1 deselected in 0.22 seconds ====================
collected 7 items / 1 deselected

test_flakes.py ......

==================== 6 passed, 1 deselected in 0.21 seconds ====================
/nix/store/g6sg265xply0s99in4b0igbdxf6s42v0-python2.7-pytest-flakes-4.0.0
/nix/store/cwx5gamnmmwwjh7zp3ch40lzy3m6m31k-python3.6-pytest-flakes-4.0.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.pytestflakes, python36Packages.pytestflakes

Partial log (click to expand)

platform linux -- Python 3.6.6, pytest-3.7.4, py-1.5.4, pluggy-0.7.1
rootdir: /build/pytest-flakes-4.0.0, inifile: tox.ini
plugins: flakes-4.0.0, pep8-1.0.6
collected 7 items / 1 deselected

test_flakes.py ......

==================== 6 passed, 1 deselected in 1.04 seconds ====================
/nix/store/20y54w8f3c27hyfzwcw2a6630slgaly4-python2.7-pytest-flakes-4.0.0
/nix/store/6jc3r6jvhrb27v207fx9cb5lnl0wjic6-python3.6-pytest-flakes-4.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.pytestflakes, python36Packages.pytestflakes

Partial log (click to expand)

platform linux -- Python 3.6.6, pytest-3.7.4, py-1.5.4, pluggy-0.7.1
rootdir: /build/pytest-flakes-4.0.0, inifile: tox.ini
plugins: flakes-4.0.0, pep8-1.0.6
collected 7 items / 1 deselected

test_flakes.py ......

==================== 6 passed, 1 deselected in 0.25 seconds ====================
/nix/store/xfmhmlaqk5zfn9bcz6y841rqwhjk212k-python2.7-pytest-flakes-4.0.0
/nix/store/a49nb3dalma2c2xvgcn0prinpj78g3ql-python3.6-pytest-flakes-4.0.0

@xeji xeji merged commit f201f8c into NixOS:master Sep 11, 2018
@xeji xeji deleted the p/pytestflakes branch September 11, 2018 09:15
xeji added a commit that referenced this pull request Sep 11, 2018
@xeji
pythonPackages.pytestflakes: fix build (#46500)
dd13aed 
- disable a failing test case that looks broken
- remove pytestcache depencency that was dropped upstream

(cherry picked from commit f201f8c)
@xeji
Copy link
Contributor Author

xeji commented Sep 11, 2018

backported: dd13aed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @Mic92