Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PySolFC: 2.0 -> 2.6.4 #45347

Merged
merged 1 commit into from Dec 22, 2019
Merged

PySolFC: 2.0 -> 2.6.4 #45347

merged 1 commit into from Dec 22, 2019

Conversation

bignaux
Copy link
Contributor

@bignaux bignaux commented Aug 19, 2018 •
edited

Motivation for this change

2.0 was released in 2010-06-09 . It seems like an unmaintained derivation.
CC @kierdavis

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 19, 2018

@GrahamcOfBorg build pysolfc

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pysolfc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: pysolfc

Partial log (click to expand)

100   280  100   280    0     0    942      0 --:--:-- --:--:-- --:--:--   939
100   274  100   274    0     0    300      0 --:--:-- --:--:-- --:--:--   300
100   276  100   276    0     0    258      0  0:00:01  0:00:01 --:--:--     0
100   272  100   272    0     0    222      0  0:00:01  0:00:01 --:--:--   222
100   274  100   274    0     0    198      0  0:00:01  0:00:01 --:--:--   198
100  125k  100  125k    0     0  65215      0  0:00:01  0:00:01 --:--:-- 65215
fixed-output derivation produced path '/nix/store/d248z5jzi73906r0nnv2cfacq069bpv5-PySolFC-Cardsets-2.0.tar.bz2' with sha256 hash '05w9cwd0i2r7bfzng006wiknbydk6k0nwgjvxdgb22lwczskplda' instead of the expected hash '19vwykrj72bygli8a6krdv9kwkhc4rj5lknqcgjbgcwi04vdd263'
copying path '/nix/store/gk7b105bphmd8a984i2p17iy135zqqzv-python2.7-pygame-1.9.4' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/ams4y5y5kk5k8vwks2vkq3z6icg96wyy-PySolFC-2.4.0.drv': 2 dependencies couldn't be built
error: build of '/nix/store/ams4y5y5kk5k8vwks2vkq3z6icg96wyy-PySolFC-2.4.0.drv' failed

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: pysolfc

Partial log (click to expand)

100 15648  100 15648    0     0  20035      0 --:--:-- --:--:-- --:--:-- 20035
100 15648  100 15648    0     0  19807      0 --:--:-- --:--:-- --:--:-- 19807
100 15649  100 15649    0     0  18049      0 --:--:-- --:--:-- --:--:-- 18049
100 15649  100 15649    0     0  17864      0 --:--:-- --:--:-- --:--:-- 17864
100  143k  100  143k    0     0   127k      0  0:00:01  0:00:01 --:--:--  127k
100  143k  100  143k    0     0   126k      0  0:00:01  0:00:01 --:--:-- 47.5M
fixed-output derivation produced path '/nix/store/fdjx0lmaybln6vrl6mazb7v9261m59vi-PySolFC-Cardsets-2.0.tar.bz2' with sha256 hash '1yk5d59wc3bch32npsbyp54a8m92878d0815viln88mgxkm5nb2f' instead of the expected hash '19vwykrj72bygli8a6krdv9kwkhc4rj5lknqcgjbgcwi04vdd263'
fixed-output derivation produced path '/nix/store/86gf56x3wxdgpgsc7i65s3xbmi2ay5ip-PySolFC-2.4.0.tar.xz' with sha256 hash '1cvmvlp3ymxs7gyrgqjqcbjmsh1gp6n37j74nd2ddy0w2pcqj7z9' instead of the expected hash '0dcc8izmlqcl7swk4gidp3bvbmjxqppriyl4c9v3vb21v09kjsa4'
cannot build derivation '/nix/store/5x3ga3lc2hpq5l9f3j7w0bh1mrr9pgr6-PySolFC-2.4.0.drv': 2 dependencies couldn't be built
error: build of '/nix/store/5x3ga3lc2hpq5l9f3j7w0bh1mrr9pgr6-PySolFC-2.4.0.drv' failed

xeji
xeji suggested changes Aug 19, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix hash mismatches

@bignaux
Copy link
Contributor Author

bignaux commented Aug 19, 2018

the hash are good, sf is always a nightmare. i spent so many hours on such SF download issue, and have no good feedback from nixos maintainer, when i skip mirror:// syntax or others tricks.

@xeji
Copy link
Contributor

xeji commented Aug 19, 2018

This doesn't build on my local machine either - looks like I get a different hash every time I try.

@bignaux
Copy link
Contributor Author

bignaux commented Aug 19, 2018

yes it's ALwAYS the same known bug, lot of mirrors just give you an htlm error page. mirror:// syntax is a bad idea for SF, but i never sucess to convinct anyone. I can put a known working mirror but another maintainer would complain i'm too silly to not have using mirror:// syntax, it happens ...

@kierdavis
Copy link
Contributor

kierdavis commented Aug 19, 2018 via email

@bignaux
Copy link
Contributor Author

bignaux commented Aug 20, 2018

you can simply replace mirror by https://versaweb.dl.sourceforge.net . You can also restore a wrapProgram mecanism to avoid .py suffix as i'd temporary removed that.

@ofborg ofborg bot requested review from kierdavis and removed request for WilliButz and infinisil December 14, 2019 16:52
@bignaux bignaux requested review from xeji and removed request for Profpatsch December 14, 2019 17:02
@bignaux bignaux changed the title PySolFC: 2.0 -> 2.4.0 PySolFC: 2.0 -> 2.6.4 Dec 14, 2019
@bignaux
Copy link
Contributor Author

bignaux commented Dec 17, 2019

This derivation fix non-working desktop file, python 3 and so ...

@worldofpeace worldofpeace merged commit e7c568a into NixOS:master Dec 22, 2019
@bignaux bignaux deleted the pysolfc branch January 29, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

@alyssais alyssais Awaiting requested review from alyssais

@edolstra edolstra Awaiting requested review from edolstra

@edwtjo edwtjo Awaiting requested review from edwtjo

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@joachifm joachifm Awaiting requested review from joachifm

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

@peti peti Awaiting requested review from peti

@rycee rycee Awaiting requested review from rycee

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@ttuegel ttuegel Awaiting requested review from ttuegel

@kierdavis kierdavis Awaiting requested review from kierdavis

@xeji xeji Awaiting requested review from xeji

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bignaux @xeji @GrahamcOfBorg @kierdavis @infinisil @worldofpeace