Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wabt: init at 1.0.5 #45361

Merged
merged 1 commit into from Aug 24, 2018
Merged

wabt: init at 1.0.5 #45361

merged 1 commit into from Aug 24, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Aug 20, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: wabt

Partial log (click to expand)

shrinking /nix/store/4wmpa4zpiswk9yg9p3gyx1kzphfl9lx7-wabt-1.0.5/bin/wasm-opcodecnt
shrinking /nix/store/4wmpa4zpiswk9yg9p3gyx1kzphfl9lx7-wabt-1.0.5/bin/wasm2c
shrinking /nix/store/4wmpa4zpiswk9yg9p3gyx1kzphfl9lx7-wabt-1.0.5/bin/wasm2wat
shrinking /nix/store/4wmpa4zpiswk9yg9p3gyx1kzphfl9lx7-wabt-1.0.5/bin/wast2json
shrinking /nix/store/4wmpa4zpiswk9yg9p3gyx1kzphfl9lx7-wabt-1.0.5/bin/wat2wasm
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4wmpa4zpiswk9yg9p3gyx1kzphfl9lx7-wabt-1.0.5/bin
patching script interpreter paths in /nix/store/4wmpa4zpiswk9yg9p3gyx1kzphfl9lx7-wabt-1.0.5
checking for references to /build in /nix/store/4wmpa4zpiswk9yg9p3gyx1kzphfl9lx7-wabt-1.0.5...
/nix/store/4wmpa4zpiswk9yg9p3gyx1kzphfl9lx7-wabt-1.0.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wabt

Partial log (click to expand)

shrinking /nix/store/q1qn46x7f38ip27n4xyk1wxjzd2b0s9p-wabt-1.0.5/bin/wasm2c
shrinking /nix/store/q1qn46x7f38ip27n4xyk1wxjzd2b0s9p-wabt-1.0.5/bin/wasm-opcodecnt
shrinking /nix/store/q1qn46x7f38ip27n4xyk1wxjzd2b0s9p-wabt-1.0.5/bin/wat-desugar
shrinking /nix/store/q1qn46x7f38ip27n4xyk1wxjzd2b0s9p-wabt-1.0.5/bin/wasm2wat
shrinking /nix/store/q1qn46x7f38ip27n4xyk1wxjzd2b0s9p-wabt-1.0.5/bin/wasm-validate
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q1qn46x7f38ip27n4xyk1wxjzd2b0s9p-wabt-1.0.5/bin
patching script interpreter paths in /nix/store/q1qn46x7f38ip27n4xyk1wxjzd2b0s9p-wabt-1.0.5
checking for references to /build in /nix/store/q1qn46x7f38ip27n4xyk1wxjzd2b0s9p-wabt-1.0.5...
/nix/store/q1qn46x7f38ip27n4xyk1wxjzd2b0s9p-wabt-1.0.5

ryantm
ryantm requested changes Aug 24, 2018
View reviewed changes
pkgs/development/tools/wabt/default.nix Outdated
longDescription = ''
WABT (we pronounce it "wabbit") is a suite of tools for WebAssembly,
including:
<itemizedlist>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it valid to use docbook formatting here? Where does it get rendered in docbook format? I only see one other package pg_top that uses in its description.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh indeed! I was confusing longDescription with module options. Pushing an updated version, thanks!

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: wabt

Partial log (click to expand)

shrinking /nix/store/jz523nwaz8wmx5n0xpi1nxvjdg90j7fb-wabt-1.0.5/bin/wasm-opcodecnt
shrinking /nix/store/jz523nwaz8wmx5n0xpi1nxvjdg90j7fb-wabt-1.0.5/bin/wat2wasm
shrinking /nix/store/jz523nwaz8wmx5n0xpi1nxvjdg90j7fb-wabt-1.0.5/bin/spectest-interp
shrinking /nix/store/jz523nwaz8wmx5n0xpi1nxvjdg90j7fb-wabt-1.0.5/bin/wasm-interp
shrinking /nix/store/jz523nwaz8wmx5n0xpi1nxvjdg90j7fb-wabt-1.0.5/bin/wasm-objdump
/nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip is /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip
stripping (with command /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip and flags -S) in /nix/store/jz523nwaz8wmx5n0xpi1nxvjdg90j7fb-wabt-1.0.5/bin
patching script interpreter paths in /nix/store/jz523nwaz8wmx5n0xpi1nxvjdg90j7fb-wabt-1.0.5
checking for references to /build in /nix/store/jz523nwaz8wmx5n0xpi1nxvjdg90j7fb-wabt-1.0.5...
/nix/store/jz523nwaz8wmx5n0xpi1nxvjdg90j7fb-wabt-1.0.5

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: wabt

Partial log (click to expand)

shrinking /nix/store/mrnqq1rcqgylb31n2y7kir1wqih5wvs9-wabt-1.0.5/bin/wasm-opcodecnt
shrinking /nix/store/mrnqq1rcqgylb31n2y7kir1wqih5wvs9-wabt-1.0.5/bin/wasm2c
shrinking /nix/store/mrnqq1rcqgylb31n2y7kir1wqih5wvs9-wabt-1.0.5/bin/wasm2wat
shrinking /nix/store/mrnqq1rcqgylb31n2y7kir1wqih5wvs9-wabt-1.0.5/bin/wast2json
shrinking /nix/store/mrnqq1rcqgylb31n2y7kir1wqih5wvs9-wabt-1.0.5/bin/wat2wasm
/nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip is /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip
stripping (with command /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip and flags -S) in /nix/store/mrnqq1rcqgylb31n2y7kir1wqih5wvs9-wabt-1.0.5/bin
patching script interpreter paths in /nix/store/mrnqq1rcqgylb31n2y7kir1wqih5wvs9-wabt-1.0.5
checking for references to /build in /nix/store/mrnqq1rcqgylb31n2y7kir1wqih5wvs9-wabt-1.0.5...
/nix/store/mrnqq1rcqgylb31n2y7kir1wqih5wvs9-wabt-1.0.5

@ryantm ryantm merged commit 1bc48e6 into NixOS:master Aug 24, 2018
@Ekleog
Copy link
Member Author

Ekleog commented Aug 24, 2018

Thank you! Just in case, I've opened #45534 that just removes docbook formatting from pg_top, as it rendered indeed wrong on options.html :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ekleog @GrahamcOfBorg @ryantm