Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redmine: 2.5.2 -> 3.4.6 #45353

Merged
merged 4 commits into from Aug 21, 2018
Merged

redmine: 2.5.2 -> 3.4.6 #45353

merged 4 commits into from Aug 21, 2018

Conversation

aanderse
Copy link
Member

Motivation for this change

Redmine was marked as broken and abandoned.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

This should also solve issue #11560

@7c6f434c
Copy link
Member

Seems OK, better than broken…

Wishlist item: a NixOS test, maybe?

@7c6f434c 7c6f434c merged commit 980cbff into NixOS:master Aug 21, 2018
@aanderse
Copy link
Member Author

Thanks. I'll come back to this after I read up on NixOS tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants