Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfig: 3.2.5b -> 3.2.7a #45354

Merged
merged 1 commit into from
Aug 20, 2018
Merged

xfig: 3.2.5b -> 3.2.7a #45354

merged 1 commit into from
Aug 20, 2018
+59 −63

Conversation

markuskowa
Copy link
Member

Motivation for this change

A real classic. I was surprised that the code is still maintained (last version from May 2018).
Resolves the problem of dead links (#45076)

Things done
  • Build fig2dev as a seperate derivation
  • Removed the custom builder script. New build system is autoconf
  • The patches are obsolete
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 19, 2018
@markuskowa markuskowa changed the title [WIP] xfig: 3.2.5b -> 3.2.7a xfig: 3.2.5b -> 3.2.7a Aug 19, 2018
@GrahamcOfBorg GrahamcOfBorg removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 19, 2018
@markuskowa markuskowa force-pushed the xfig-pr branch 2 times, most recently from df1c42e to cb8066e Compare August 19, 2018 22:24
@markuskowa
xfig: 3.2.5b -> 3.2.7a

Verified

This commit was signed with the committer’s verified signature.
markuskowa Markus Kowalewski
GPG key ID: D865C8A91D7025EB
Verified
Learn about vigilant mode
6d95b55 
init fig2dev as separate package (3.2.7a).
fig2dev was included in xfig in the previous version.
@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 19, 2018
@7c6f434c
Copy link
Member

@GrahamcOfBorg build xfig

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: xfig

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xfig

Partial log (click to expand)

make[1]: Leaving directory '/build/xfig-3.2.7a'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6ach400m7pgdv9frcfsl7dd8ziznp93z-xfig-3.2.7a
shrinking /nix/store/6ach400m7pgdv9frcfsl7dd8ziznp93z-xfig-3.2.7a/bin/.xfig-wrapped
gzipping man pages under /nix/store/6ach400m7pgdv9frcfsl7dd8ziznp93z-xfig-3.2.7a/share/man/
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6ach400m7pgdv9frcfsl7dd8ziznp93z-xfig-3.2.7a/bin
patching script interpreter paths in /nix/store/6ach400m7pgdv9frcfsl7dd8ziznp93z-xfig-3.2.7a
checking for references to /build in /nix/store/6ach400m7pgdv9frcfsl7dd8ziznp93z-xfig-3.2.7a...
/nix/store/6ach400m7pgdv9frcfsl7dd8ziznp93z-xfig-3.2.7a

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xfig

Partial log (click to expand)

make[1]: Leaving directory '/build/xfig-3.2.7a'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i2b9lqwrfgh0xzsdhqcqrg3l5pc8xsb4-xfig-3.2.7a
shrinking /nix/store/i2b9lqwrfgh0xzsdhqcqrg3l5pc8xsb4-xfig-3.2.7a/bin/.xfig-wrapped
gzipping man pages under /nix/store/i2b9lqwrfgh0xzsdhqcqrg3l5pc8xsb4-xfig-3.2.7a/share/man/
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i2b9lqwrfgh0xzsdhqcqrg3l5pc8xsb4-xfig-3.2.7a/bin
patching script interpreter paths in /nix/store/i2b9lqwrfgh0xzsdhqcqrg3l5pc8xsb4-xfig-3.2.7a
checking for references to /build in /nix/store/i2b9lqwrfgh0xzsdhqcqrg3l5pc8xsb4-xfig-3.2.7a...
/nix/store/i2b9lqwrfgh0xzsdhqcqrg3l5pc8xsb4-xfig-3.2.7a

@7c6f434c 7c6f434c merged commit bc9082b into NixOS:master Aug 20, 2018
@markuskowa markuskowa deleted the xfig-pr branch August 20, 2018 07:07
@markuskowa
Copy link
Member Author

@ryantm Is it possible to add this package (xfig and fig2dev) to your auto updater? The new version of the derivation is much cleaner.

@ryantm
Copy link
Member

ryantm commented Aug 20, 2018

@markuskowa Neither of these packages are specifically blacklisted. My auto updater has been trying to update xfig. Here is the relevant error message from the last run

Looks like our inclusion of fig2dev hasn't been picked up by Repology yet when it is, my bot will try to update it.

@markuskowa
Copy link
Member Author

@r-ryantm Thanks for the explanation. If no automatic update appears that means that it failed and needs to be done manually. I'll keep that in mind.

@ryantm
Copy link
Member

ryantm commented Aug 21, 2018

@markuskowa You're welcome. If you want to look up a particular package, you can get a link to the latest logs here: nix-community/nixpkgs-update#62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markuskowa @7c6f434c @GrahamcOfBorg @ryantm