ldc: 1.10.0 -> 1.11.0, dmd: 2.081.1 -> 2.081.2, dtools: 2.081.1 -> 2.081.2 #45355

ThomasMader · 2018-08-19T22:02:10Z

Motivation for this change

Update to latest stable releases.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

GrahamcOfBorg · 2018-08-19T22:15:44Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: dmd, dtools, ldc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-08-19T22:37:45Z

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: dmd, dtools, ldc

Partial log (click to expand)


Total Test time (real) =  43.28 sec
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5wb6538z2g46wdzs62mjldw8za3ym41v-ldcUnittests-1.11.0
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/5wb6538z2g46wdzs62mjldw8za3ym41v-ldcUnittests-1.11.0
checking for references to /build in /nix/store/5wb6538z2g46wdzs62mjldw8za3ym41v-ldcUnittests-1.11.0...
warning: path '/nix/store/5wb6538z2g46wdzs62mjldw8za3ym41v-ldcUnittests-1.11.0' claims to be content-addressed but isn't
error: unexpected end-of-file

ThomasMader · 2018-08-19T22:49:15Z

The Linux build error can be ignored because there is something wrong with the build machine GrahamcOfBorg is running on.
The problem it's running into is documented in NixOS/nix#2155 and was last seen in #44904 (comment)

So this is ready to be merged.

Mic92 · 2018-08-20T11:33:36Z

While reviewing this I noticed that Literate is broken that was submitted by @RocketPuppy:

$ nix-shell --no-out-link --keep-going --max-jobs 4 --option build-use-sandbox true --run true -p Literate -p dmd -p dtools -p dub -p gtkd -p ldc -p tilix
these derivations will be built:
  /nix/store/x2i0rsa60hy3199c91jy7j0yd6hy6ckv-Literate-2017-05-28.drv
building '/nix/store/x2i0rsa60hy3199c91jy7j0yd6hy6ckv-Literate-2017-05-28.drv'...
unpacking sources
unpacking source archive /nix/store/nmh124f6x0b5hgs6z66s42x9jmvyhd50-Literate-23928d6
source root is Literate-23928d6
patching sources
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/79b6s2wql94lwk8dyib2jc4fq8ixl13f-bash-4.4-p23/bin/bash
dub --root=lit/tangle build
Performing "debug" build using dmd for x86_64.
tangle ~master: building configuration "application"...
lit/tangle/src/parser.d(212,14): Deprecation: package `std.regex` is not accessible here, perhaps add `static import std.regex;`
lit/tangle/src/util.d(48,25): Deprecation: `parser.matchAll` is not visible from module `util`
lit/tangle/src/util.d(48,45): Deprecation: `parser.regex` is not visible from module `util`
lit/tangle/src/util.d(48,68): Deprecation: `parser.matchAll` is not visible from module `util`
lit/tangle/src/util.d(48,88): Deprecation: `parser.regex` is not visible from module `util`
lit/tangle/src/util.d(50,29): Deprecation: `parser.matchAll` is not visible from module `util`
lit/tangle/src/util.d(50,49): Deprecation: `parser.regex` is not visible from module `util`
lit/tangle/src/util.d(54,41): Deprecation: `parser.canFind` is not visible from module `util`
lit/tangle/src/util.d(54,89): Deprecation: `parser.canFind` is not visible from module `util`
lit/tangle/src/util.d(69,24): Deprecation: `parser.canFind` is not visible from module `util`
lit/tangle/src/util.d(77,31): Deprecation: `parser.canFind` is not visible from module `util`
Linking...
bin/tangle -odir source lit/*.lit
dub build --build=release
Package dmarkdown not found in registry at https://code.dlang.org/ (fallback ["registry at http://code.dlang.org/", "registry at https://code-mirror.dlang.io/", "registry at https://code-mirr
or2.dlang.io/", "registry at https://dub-registry.herokuapp.com/"]): Couldn't resolve host name on handle D72200
Performing "release" build using dmd for x86_64.
dmarkdown ~master: building configuration "library"...
lit/markdown/source/dmarkdown/markdown.d(820,10): Deprecation: module `std.ascii` is not accessible here, perhaps add `static import std.ascii;`
literate ~master: building configuration "application"...
source/globals.d(19,1): Error: Implicit string concatenation is deprecated, use "Lit: Literate Programming System\x0a" ~ "\x0a" instead
source/globals.d(20,1): Error: Implicit string concatenation is deprecated, use "\x0a" ~ "Usage: lit [options] <inputs>\x0a" instead
source/globals.d(21,1): Error: Implicit string concatenation is deprecated, use "Usage: lit [options] <inputs>\x0a" ~ "\x0a" instead
source/globals.d(22,1): Error: Implicit string concatenation is deprecated, use "\x0a" ~ "Options:\x0a" instead
source/globals.d(23,1): Error: Implicit string concatenation is deprecated, use "Options:\x0a" ~ "--help       -h         Show this help text\x0a" instead
source/globals.d(24,1): Error: Implicit string concatenation is deprecated, use "--help       -h         Show this help text\x0a" ~ "--tangle     -t         Only compile code files\x0a" inste
ad
source/globals.d(25,1): Error: Implicit string concatenation is deprecated, use "--tangle     -t         Only compile code files\x0a" ~ "--weave      -w         Only compile HTML files\x0a" i
nstead
source/globals.d(26,1): Error: Implicit string concatenation is deprecated, use "--weave      -w         Only compile HTML files\x0a" ~ "--no-output  -no        Do not generate any output fil
es\x0a" instead
source/globals.d(27,1): Error: Implicit string concatenation is deprecated, use "--no-output  -no        Do not generate any output files\x0a" ~ "--out-dir    -odir DIR  Put the generated fil
es in DIR\x0a" instead
source/globals.d(28,1): Error: Implicit string concatenation is deprecated, use "--out-dir    -odir DIR  Put the generated files in DIR\x0a" ~ "--compiler   -c         Report compiler errors
(needs @compiler to be defined)\x0a" instead
source/globals.d(29,1): Error: Implicit string concatenation is deprecated, use "--compiler   -c         Report compiler errors (needs @compiler to be defined)\x0a" ~ "--linenums   -l    STR
 Write line numbers prepended with STR to the output file\x0a" instead
source/globals.d(30,1): Error: Implicit string concatenation is deprecated, use "--linenums   -l    STR  Write line numbers prepended with STR to the output file\x0a" ~ "--md-compiler COMPILE
R  Use COMPILER as the markdown compiler instead of the built-in one\x0a" instead
source/globals.d(31,1): Error: Implicit string concatenation is deprecated, use "--md-compiler COMPILER  Use COMPILER as the markdown compiler instead of the built-in one\x0a" ~ "--version
 -v         Show the version number and compiler information" instead
source/weaver.d(299,18): Error: Implicit string concatenation is deprecated, use "<!DOCTYPE html>\x0a" ~ "<html>\x0a" instead
source/weaver.d(300,18): Error: Implicit string concatenation is deprecated, use "<html>\x0a" ~ "<head>\x0a" instead
source/weaver.d(301,18): Error: Implicit string concatenation is deprecated, use "<head>\x0a" ~ "<meta charset=\"utf-8\">\x0a" instead
source/weaver.d(302,18): Error: Implicit string concatenation is deprecated, use "<meta charset=\"utf-8\">\x0a" ~ "<title>" instead
source/weaver.d(307,18): Error: Implicit string concatenation is deprecated, use "</style>\x0a" ~ "</head>\x0a" instead
source/weaver.d(311,15): Error: Implicit string concatenation is deprecated, use "<body onload=\"prettyPrint()\">\x0a" ~ "<section>\x0a" instead
dmd failed with exit code 1.
make: *** [Makefile:3: release] Error 2
builder for '/nix/store/x2i0rsa60hy3199c91jy7j0yd6hy6ckv-Literate-2017-05-28.drv' failed with exit code 2

ThomasMader · 2018-08-20T12:49:36Z

While reviewing this I noticed that Literate is broken that was submitted by @RocketPuppy:

There are only 4 new commits to the repo at https://github.com/zyedidia/Literate/commits/master.
Current Nix package is at zyedidia/Literate@23928d6.
The 4 new commits don't seem to be fixing any of the deprecation errors.

@zyedidia Could you please fix the compilation with newest compilers upstream?

Mic92 · 2018-08-20T12:53:15Z

We could mark it as broken in the meantime.

ThomasMader · 2018-08-20T12:54:54Z

Yes that's the way to go.

Mic92 · 2018-08-20T13:08:25Z

done in bbf5f23

Incompatible with our dlang compiler, see #45355 (comment)

zyedidia · 2018-08-20T19:44:24Z

I believe these errors have been fixed with the latest commit to zyedidia/Literate.

ThomasMader · 2018-08-20T20:16:56Z

Yes that fixes the build, thanks.
There are still some deprecation warnings though:

lit/tangle/src/parser.d(212,14): Deprecation: package std.regex is not accessible here, perhaps add static import std.regex;
lit/tangle/src/util.d(48,25): Deprecation: parser.matchAll is not visible from module util
lit/tangle/src/util.d(48,45): Deprecation: parser.regex is not visible from module util
lit/tangle/src/util.d(48,68): Deprecation: parser.matchAll is not visible from module util
lit/tangle/src/util.d(48,88): Deprecation: parser.regex is not visible from module util
lit/tangle/src/util.d(50,29): Deprecation: parser.matchAll is not visible from module util
lit/tangle/src/util.d(50,49): Deprecation: parser.regex is not visible from module util
lit/tangle/src/util.d(54,41): Deprecation: parser.canFind is not visible from module util
lit/tangle/src/util.d(54,89): Deprecation: parser.canFind is not visible from module util
lit/tangle/src/util.d(69,24): Deprecation: parser.canFind is not visible from module util
lit/tangle/src/util.d(77,31): Deprecation: parser.canFind is not visible from module util

I might update the package in another PR.

ThomasMader added 3 commits August 19, 2018 21:52

ldc: 1.10.0 -> 1.11.0

ed5b194

dmd: 2.081.1 -> 2.081.2

89e4834

dtools: 2.081.1 -> 2.081.2

4d0203d

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 19, 2018

Mic92 merged commit 439c90b into NixOS:master Aug 20, 2018

Mic92 added a commit that referenced this pull request Aug 20, 2018

Literate: mark as broken

bbf5f23

Incompatible with our dlang compiler, see #45355 (comment)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ldc: 1.10.0 -> 1.11.0, dmd: 2.081.1 -> 2.081.2, dtools: 2.081.1 -> 2.081.2 #45355

ldc: 1.10.0 -> 1.11.0, dmd: 2.081.1 -> 2.081.2, dtools: 2.081.1 -> 2.081.2 #45355

ThomasMader commented Aug 19, 2018

GrahamcOfBorg commented Aug 19, 2018

GrahamcOfBorg commented Aug 19, 2018

ThomasMader commented Aug 19, 2018

Mic92 commented Aug 20, 2018 •

edited

ThomasMader commented Aug 20, 2018

Mic92 commented Aug 20, 2018

ThomasMader commented Aug 20, 2018

Mic92 commented Aug 20, 2018

zyedidia commented Aug 20, 2018

ThomasMader commented Aug 20, 2018

ldc: 1.10.0 -> 1.11.0, dmd: 2.081.1 -> 2.081.2, dtools: 2.081.1 -> 2.081.2 #45355

ldc: 1.10.0 -> 1.11.0, dmd: 2.081.1 -> 2.081.2, dtools: 2.081.1 -> 2.081.2 #45355

Conversation

ThomasMader commented Aug 19, 2018

Motivation for this change

Things done

GrahamcOfBorg commented Aug 19, 2018

GrahamcOfBorg commented Aug 19, 2018

ThomasMader commented Aug 19, 2018

Mic92 commented Aug 20, 2018 • edited

ThomasMader commented Aug 20, 2018

Mic92 commented Aug 20, 2018

ThomasMader commented Aug 20, 2018

Mic92 commented Aug 20, 2018

zyedidia commented Aug 20, 2018

ThomasMader commented Aug 20, 2018

Mic92 commented Aug 20, 2018 •

edited