Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testdisk-photorec: init at 7.0 #45329

Merged
merged 1 commit into from Aug 23, 2018
Merged

testdisk-photorec: init at 7.0 #45329

merged 1 commit into from Aug 23, 2018

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Aug 19, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@fgaz
Copy link
Member Author

fgaz commented Aug 19, 2018

@GrahamcOfBorg build testdisk-photorec

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: testdisk-photorec

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/40wcvhv5r3ybch1bx6q4vy2wfkl5a2yc-testdisk-photorec-7.0
shrinking /nix/store/40wcvhv5r3ybch1bx6q4vy2wfkl5a2yc-testdisk-photorec-7.0/bin/testdisk
shrinking /nix/store/40wcvhv5r3ybch1bx6q4vy2wfkl5a2yc-testdisk-photorec-7.0/bin/fidentify
shrinking /nix/store/40wcvhv5r3ybch1bx6q4vy2wfkl5a2yc-testdisk-photorec-7.0/bin/photorec
gzipping man pages under /nix/store/40wcvhv5r3ybch1bx6q4vy2wfkl5a2yc-testdisk-photorec-7.0/share/man/
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/40wcvhv5r3ybch1bx6q4vy2wfkl5a2yc-testdisk-photorec-7.0/bin
patching script interpreter paths in /nix/store/40wcvhv5r3ybch1bx6q4vy2wfkl5a2yc-testdisk-photorec-7.0
checking for references to /build in /nix/store/40wcvhv5r3ybch1bx6q4vy2wfkl5a2yc-testdisk-photorec-7.0...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: testdisk-photorec

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/r1007qsd2zrpdmn1bzqiihyj45lqkyjy-testdisk-photorec-7.0
shrinking /nix/store/r1007qsd2zrpdmn1bzqiihyj45lqkyjy-testdisk-photorec-7.0/bin/fidentify
shrinking /nix/store/r1007qsd2zrpdmn1bzqiihyj45lqkyjy-testdisk-photorec-7.0/bin/photorec
shrinking /nix/store/r1007qsd2zrpdmn1bzqiihyj45lqkyjy-testdisk-photorec-7.0/bin/testdisk
gzipping man pages under /nix/store/r1007qsd2zrpdmn1bzqiihyj45lqkyjy-testdisk-photorec-7.0/share/man/
strip is /nix/store/4md2i310zklkkl5j41yw70gcwgn4kav5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r1007qsd2zrpdmn1bzqiihyj45lqkyjy-testdisk-photorec-7.0/bin
patching script interpreter paths in /nix/store/r1007qsd2zrpdmn1bzqiihyj45lqkyjy-testdisk-photorec-7.0
checking for references to /build in /nix/store/r1007qsd2zrpdmn1bzqiihyj45lqkyjy-testdisk-photorec-7.0...
/nix/store/r1007qsd2zrpdmn1bzqiihyj45lqkyjy-testdisk-photorec-7.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: testdisk-photorec

Partial log (click to expand)

/nix/store/r1007qsd2zrpdmn1bzqiihyj45lqkyjy-testdisk-photorec-7.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: testdisk-photorec

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/40wcvhv5r3ybch1bx6q4vy2wfkl5a2yc-testdisk-photorec-7.0
shrinking /nix/store/40wcvhv5r3ybch1bx6q4vy2wfkl5a2yc-testdisk-photorec-7.0/bin/testdisk
shrinking /nix/store/40wcvhv5r3ybch1bx6q4vy2wfkl5a2yc-testdisk-photorec-7.0/bin/photorec
shrinking /nix/store/40wcvhv5r3ybch1bx6q4vy2wfkl5a2yc-testdisk-photorec-7.0/bin/fidentify
gzipping man pages under /nix/store/40wcvhv5r3ybch1bx6q4vy2wfkl5a2yc-testdisk-photorec-7.0/share/man/
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/40wcvhv5r3ybch1bx6q4vy2wfkl5a2yc-testdisk-photorec-7.0/bin
patching script interpreter paths in /nix/store/40wcvhv5r3ybch1bx6q4vy2wfkl5a2yc-testdisk-photorec-7.0
checking for references to /build in /nix/store/40wcvhv5r3ybch1bx6q4vy2wfkl5a2yc-testdisk-photorec-7.0...
/nix/store/40wcvhv5r3ybch1bx6q4vy2wfkl5a2yc-testdisk-photorec-7.0

@fgaz
Copy link
Member Author

fgaz commented Aug 19, 2018 •
edited

@grahamc I think ofborg has a bug... I told it to build before the eval was complete and it built two times (though the second was a no-op). One before and one after the eval. Or maybe someone else told it to build too and deleted their comment afterwards.

edit: the arm one was a noop, but the x86 one wasn't... wat.
editedit: oh I get it, the x86 one got built on two different machines/clusters
editeditedit: reported: NixOS/ofborg#227

@fgaz fgaz mentioned this pull request Aug 20, 2018
Closed
@grahamc
Copy link
Member

grahamc commented Aug 20, 2018

@fgaz because you are a known or trusted user, and your commit message started with a valid attribute name followed by a colon, (ie: testdisk-photorec:) the evaluation triggered the automatic build feature of OfBorg: https://github.com/nixos/ofborg#automatic-building. Thusly, the first set of builds were due to your request, the second set of builds were due to the commit message being well formed.

@xeji xeji merged commit 599963c into NixOS:master Aug 23, 2018
@fgaz fgaz deleted the testdisk-photorec/init branch August 26, 2018 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fgaz @GrahamcOfBorg @grahamc @xeji