Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eunomia-font: init at 0.200 #45358

Merged
merged 9 commits into from Aug 23, 2018
Merged

eunomia-font: init at 0.200 #45358

merged 9 commits into from Aug 23, 2018

Conversation

leenaars
Copy link
Contributor

@leenaars leenaars commented Aug 19, 2018 •
edited

Motivation for this change

Nine excellent open source fonts by same creator as Vegur font (already in Nixpkgs).

Things done
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 21, 2018

These expressions have a lot of repetitive code. May I suggest to move them all into a common directory and attribute set like dotcolon-fonts, and refactor the common code into a generic function, like in https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/admin/ansible/default.nix and many similar examples.

@leenaars
Copy link
Contributor Author

Hi @xeji, thanks for having a look. I don't think there will be many bites shaved off, while increasing complexity. The fonts are distinct and independent, unlike (for instance) ansible which is about creating multiple instances of the same. There are even two different licenses. The 'code' is already much boilerplate - unzip file from URL, put into fonts directory, done. The description and longDescription are unique for each as well. Would it be okay to leave it as is?

Note that I agree having a generic fontsUnwrapper abstraction for this kind of data asset would be nice. Fonts unpacking is either looking into a folder or parsing extensions (.otf -> put into $out/shared/opentype/$fontFamilyName}, .ttf -> put into $out/shared/truetype/$fontFamilyName}, etcetera). However, writing that kind of handler is beyond my nix powers right now ... would be something to look into in the future though.

@xeji
Copy link
Contributor

xeji commented Aug 22, 2018

Would it be okay to leave it as is?

Fine with me, it was just a suggestion to think about.

@xeji
Copy link
Contributor

xeji commented Aug 23, 2018

@GrahamcOfBorg build eunomia f5_6 ferrum aileron route159 penna seshat medio tenderness

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: eunomia, f5_6, ferrum, aileron, route159, penna, seshat, medio, tenderness

Partial log (click to expand)

  inflating: /nix/store/yc429q010vq0qnvv8jjar7vf7jmqxgi3-route159-font-1.10/share/fonts/opentype/route159/Route159-UltraLightItalic.otf
/nix/store/78ylai83mmshqdhzfh6n6r20h6b4kr6w-eunomia-font-0.200
/nix/store/90hw3qfv4iy951sch6hp1agv9s9nkjjs-f5_6-font-0.110
/nix/store/4vb6dk0iwsvaks147awyyf5a4mmmwrq3-ferrum-font-0.200
/nix/store/hzncrdx20mcfnx901q14crshzdffsxzb-aileron-font-0.102
/nix/store/yc429q010vq0qnvv8jjar7vf7jmqxgi3-route159-font-1.10
/nix/store/xbsp217n9zs329cpmy035ysl9212jxdy-penna-font-0.10
/nix/store/8xr0y18q6p0ani5a1cvn6cbnx829aa6i-seshat-font-0.100
/nix/store/j0mvh6f6bkhy4jsw19jdizpfkhyyzssq-medio-font-0.200
/nix/store/pywndlibqpz5nzawhvijhfv6af8w9idl-tenderness-font-0.601

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: eunomia, f5_6, ferrum, aileron, route159, penna, seshat, medio, tenderness

Partial log (click to expand)

  inflating: /nix/store/yc429q010vq0qnvv8jjar7vf7jmqxgi3-route159-font-1.10/share/fonts/opentype/route159/Route159-UltraLightItalic.otf
/nix/store/78ylai83mmshqdhzfh6n6r20h6b4kr6w-eunomia-font-0.200
/nix/store/90hw3qfv4iy951sch6hp1agv9s9nkjjs-f5_6-font-0.110
/nix/store/4vb6dk0iwsvaks147awyyf5a4mmmwrq3-ferrum-font-0.200
/nix/store/hzncrdx20mcfnx901q14crshzdffsxzb-aileron-font-0.102
/nix/store/yc429q010vq0qnvv8jjar7vf7jmqxgi3-route159-font-1.10
/nix/store/xbsp217n9zs329cpmy035ysl9212jxdy-penna-font-0.10
/nix/store/8xr0y18q6p0ani5a1cvn6cbnx829aa6i-seshat-font-0.100
/nix/store/j0mvh6f6bkhy4jsw19jdizpfkhyyzssq-medio-font-0.200
/nix/store/pywndlibqpz5nzawhvijhfv6af8w9idl-tenderness-font-0.601

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: eunomia, f5_6, ferrum, aileron, route159, penna, seshat, medio, tenderness

Partial log (click to expand)

  inflating: /nix/store/pywndlibqpz5nzawhvijhfv6af8w9idl-tenderness-font-0.601/share/fonts/opentype/tenderness/Tenderness-Regular.otf
/nix/store/78ylai83mmshqdhzfh6n6r20h6b4kr6w-eunomia-font-0.200
/nix/store/90hw3qfv4iy951sch6hp1agv9s9nkjjs-f5_6-font-0.110
/nix/store/4vb6dk0iwsvaks147awyyf5a4mmmwrq3-ferrum-font-0.200
/nix/store/hzncrdx20mcfnx901q14crshzdffsxzb-aileron-font-0.102
/nix/store/yc429q010vq0qnvv8jjar7vf7jmqxgi3-route159-font-1.10
/nix/store/xbsp217n9zs329cpmy035ysl9212jxdy-penna-font-0.10
/nix/store/8xr0y18q6p0ani5a1cvn6cbnx829aa6i-seshat-font-0.100
/nix/store/j0mvh6f6bkhy4jsw19jdizpfkhyyzssq-medio-font-0.200
/nix/store/pywndlibqpz5nzawhvijhfv6af8w9idl-tenderness-font-0.601

@xeji xeji merged commit 2df53de into NixOS:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leenaars @xeji @GrahamcOfBorg