New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nwjs-sdk: init at 0.33.4 #45320
nwjs-sdk: init at 0.33.4 #45320
Conversation
@@ -32,11 +33,16 @@ in stdenv.mkDerivation rec { | |||
name = "nwjs-${version}"; | |||
version = "0.32.1"; | |||
|
|||
src = fetchurl { | |||
src = if sdk then fetchurl { | |||
url = "https://dl.nwjs.io/v${version}/nwjs-v${version}-linux-${bits}.tar.gz"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now sdk=true
downloads the normal version and sdk=false
the sdk version. You sure? 😄
Oops :) will update with a revised patch as soon as I to my computer.
…On Fri, Aug 24, 2018, 4:58 AM xeji ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/development/tools/nwjs/default.nix
<#45320 (comment)>:
> @@ -32,11 +33,16 @@ in stdenv.mkDerivation rec {
name = "nwjs-${version}";
version = "0.32.1";
- src = fetchurl {
+ src = if sdk then fetchurl {
url = "https://dl.nwjs.io/v${version}/nwjs-v${version}-linux-${bits}.tar.gz";
Now sdk=true downloads the normal version and sdk=false the sdk version.
You sure? 😄
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#45320 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAABxFGrB5WRNihEDibdbetp5xtm83Qvks5uTxeNgaJpZM4WCzyE>
.
|
@xeji I updated the PR |
@GrahamcOfBorg build nwjs nwjs-sdk |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: nwjs, nwjs-sdk Partial log (click to expand)
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: nwjs, nwjs-sdk Partial log (click to expand)
|
Unexpected error: command failed with exit code 1 on x86_64-linux (full log) Attempted: nwjs, nwjs-sdk Partial log (click to expand)
|
Hash mismatch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix source hashes
@xeji I apologize, I was travelling in September a lot and let this get forgotten. I've updated the hashes and also used this as an opportunity to bump the version. |
@GrahamcOfBorg build nwjs-sdk |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: nwjs-sdk Partial log (click to expand)
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: nwjs-sdk Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: nwjs-sdk Partial log (click to expand)
|
@GrahamcOfBorg build nwjs |
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: nwjs Partial log (click to expand)
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: nwjs Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: nwjs Partial log (click to expand)
|
Motivation for this change
Some applications require SDK version of NWJS
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)