nwjs-sdk: init at 0.33.4 #45320

yrashk · 2018-08-19T03:19:44Z

Motivation for this change

Some applications require SDK version of NWJS

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

xeji · 2018-08-23T20:58:48Z

pkgs/development/tools/nwjs/default.nix

@@ -32,11 +33,16 @@ in stdenv.mkDerivation rec {
  name = "nwjs-${version}";
  version = "0.32.1";

-  src = fetchurl {
+  src = if sdk then fetchurl {
    url = "https://dl.nwjs.io/v${version}/nwjs-v${version}-linux-${bits}.tar.gz";


Now sdk=true downloads the normal version and sdk=false the sdk version. You sure? 😄

yrashk · 2018-08-24T01:33:01Z

Oops :) will update with a revised patch as soon as I to my computer.

…

On Fri, Aug 24, 2018, 4:58 AM xeji ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pkgs/development/tools/nwjs/default.nix <#45320 (comment)>: > @@ -32,11 +33,16 @@ in stdenv.mkDerivation rec { name = "nwjs-${version}"; version = "0.32.1"; - src = fetchurl { + src = if sdk then fetchurl { url = "https://dl.nwjs.io/v${version}/nwjs-v${version}-linux-${bits}.tar.gz"; Now sdk=true downloads the normal version and sdk=false the sdk version. You sure? 😄 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#45320 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAABxFGrB5WRNihEDibdbetp5xtm83Qvks5uTxeNgaJpZM4WCzyE> .

yrashk · 2018-08-24T15:12:02Z

@xeji I updated the PR

xeji · 2018-08-24T16:08:15Z

@GrahamcOfBorg build nwjs nwjs-sdk

GrahamcOfBorg · 2018-08-24T16:08:38Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: nwjs, nwjs-sdk

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-08-24T16:08:44Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: nwjs, nwjs-sdk

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-08-24T16:09:28Z

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: nwjs, nwjs-sdk

Partial log (click to expand)

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 91.1M  100 91.1M    0     0  6293k      0  0:00:14  0:00:14 --:--:-- 8346k
fixed-output derivation produced path '/nix/store/3ra8028g8fq37qmc4f4lgfi07a0mvpjw-nwjs-sdk-v0.32.2-linux-x64.tar.gz' with sha256 hash '14fpyaj3p4v0sxmapfwwrdny4nipxhmv1zh1fv2d0zqpkgyyl2s5' instead of the expected hash '0w2clqp3r25931cdbzil2hsld88hjhgv9d470bk735mk9sraikxz'
copying path '/nix/store/lfq10zskhanl9k7f65my03b5hv5090xn-ffmpeg-3.4.4' from 'https://cache.nixos.org'...
copying path '/nix/store/lylymzsvx53s97ly52zjfwjiqjaly4iw-ffmpeg-3.4.4-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/aprarwrl2jd7qi7apprhjfwq1chzqy85-nwjs-env' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/m42n4is3xnxi71b7i08hlscb0m2hkfzh-nwjs-0.32.2.drv': 1 dependencies couldn't be built
copying path '/nix/store/gdacy0j8izkzcivp4crznzm9bklvrpn5-nwjs-0.32.2' from 'https://cache.nixos.org'...
error: build of '/nix/store/m42n4is3xnxi71b7i08hlscb0m2hkfzh-nwjs-0.32.2.drv' failed

xeji · 2018-08-24T16:19:57Z

Hash mismatch.

xeji

fix source hashes

yrashk · 2018-10-02T04:26:55Z

@xeji I apologize, I was travelling in September a lot and let this get forgotten. I've updated the hashes and also used this as an opportunity to bump the version.

xeji · 2018-10-02T08:05:36Z

@GrahamcOfBorg build nwjs-sdk

GrahamcOfBorg · 2018-10-02T08:05:48Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: nwjs-sdk

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-02T08:05:51Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: nwjs-sdk

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-02T08:06:51Z

Success on x86_64-linux (full log)

Attempted: nwjs-sdk

Partial log (click to expand)

/nix/store/3p3frkywsn6qsk24abarkxpdmnsa5h8y-nwjs-0.33.4/share/nwjs/payload
/nix/store/3p3frkywsn6qsk24abarkxpdmnsa5h8y-nwjs-0.33.4/share/nwjs/credits.html
/nix/store/3p3frkywsn6qsk24abarkxpdmnsa5h8y-nwjs-0.33.4/share/nwjs/nw
/nix/store/3p3frkywsn6qsk24abarkxpdmnsa5h8y-nwjs-0.33.4/share/nwjs/lib
/nix/store/3p3frkywsn6qsk24abarkxpdmnsa5h8y-nwjs-0.33.4/share/nwjs/lib/libnode.so
/nix/store/3p3frkywsn6qsk24abarkxpdmnsa5h8y-nwjs-0.33.4/share/nwjs/lib/libnw.so
/nix/store/3p3frkywsn6qsk24abarkxpdmnsa5h8y-nwjs-0.33.4/share/nwjs/lib/libffmpeg.so
/nix/store/3p3frkywsn6qsk24abarkxpdmnsa5h8y-nwjs-0.33.4/share/nwjs/icudtl.dat
warning: working around a Linux kernel bug by creating a hole of 4096 bytes in ‘/nix/store/3p3frkywsn6qsk24abarkxpdmnsa5h8y-nwjs-0.33.4/share/nwjs/nw’
/nix/store/3p3frkywsn6qsk24abarkxpdmnsa5h8y-nwjs-0.33.4

xeji · 2018-10-02T08:21:24Z

@GrahamcOfBorg build nwjs

GrahamcOfBorg · 2018-10-02T08:21:37Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: nwjs

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-02T08:21:38Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: nwjs

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-10-02T08:22:52Z

Success on x86_64-linux (full log)

Attempted: nwjs

Partial log (click to expand)

/nix/store/wdzlwyw8rdmaqbhv2cladan9pmihh9bj-nwjs-0.33.4/share/nwjs/nw_100_percent.pak
/nix/store/wdzlwyw8rdmaqbhv2cladan9pmihh9bj-nwjs-0.33.4/share/nwjs/resources.pak
/nix/store/wdzlwyw8rdmaqbhv2cladan9pmihh9bj-nwjs-0.33.4/share/nwjs/nw_200_percent.pak
/nix/store/wdzlwyw8rdmaqbhv2cladan9pmihh9bj-nwjs-0.33.4/share/nwjs/nw
/nix/store/wdzlwyw8rdmaqbhv2cladan9pmihh9bj-nwjs-0.33.4/share/nwjs/swiftshader
/nix/store/wdzlwyw8rdmaqbhv2cladan9pmihh9bj-nwjs-0.33.4/share/nwjs/swiftshader/libGLESv2.so
/nix/store/wdzlwyw8rdmaqbhv2cladan9pmihh9bj-nwjs-0.33.4/share/nwjs/swiftshader/libEGL.so
/nix/store/wdzlwyw8rdmaqbhv2cladan9pmihh9bj-nwjs-0.33.4/share/nwjs/credits.html
warning: working around a Linux kernel bug by creating a hole of 4096 bytes in ‘/nix/store/wdzlwyw8rdmaqbhv2cladan9pmihh9bj-nwjs-0.33.4/share/nwjs/nw’
/nix/store/wdzlwyw8rdmaqbhv2cladan9pmihh9bj-nwjs-0.33.4

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Aug 19, 2018

xeji reviewed Aug 23, 2018

View reviewed changes

yrashk force-pushed the nwjs-sdk branch from 6055434 to bb998e8 Compare August 24, 2018 15:11

xeji suggested changes Sep 1, 2018

View reviewed changes

yrashk force-pushed the nwjs-sdk branch from bb998e8 to 0a0d4b6 Compare October 2, 2018 04:24

nwjs-sdk: init at 0.33.4

af2ad8f

yrashk force-pushed the nwjs-sdk branch from 0a0d4b6 to af2ad8f Compare October 2, 2018 04:26

xeji changed the title ~~nwjs-sdk: init at 0.32.1~~ nwjs-sdk: init at 0.33.4 Oct 2, 2018

xeji approved these changes Oct 2, 2018

View reviewed changes

xeji merged commit 34f2009 into NixOS:master Oct 2, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nwjs-sdk: init at 0.33.4 #45320

nwjs-sdk: init at 0.33.4 #45320

yrashk commented Aug 19, 2018 •

edited

xeji Aug 23, 2018

yrashk commented Aug 24, 2018 via email

yrashk commented Aug 24, 2018

xeji commented Aug 24, 2018

GrahamcOfBorg commented Aug 24, 2018

GrahamcOfBorg commented Aug 24, 2018

GrahamcOfBorg commented Aug 24, 2018

xeji commented Aug 24, 2018

xeji left a comment

yrashk commented Oct 2, 2018

xeji commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

xeji commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

nwjs-sdk: init at 0.33.4 #45320

nwjs-sdk: init at 0.33.4 #45320

Conversation

yrashk commented Aug 19, 2018 • edited

Motivation for this change

Things done

xeji Aug 23, 2018

Choose a reason for hiding this comment

yrashk commented Aug 24, 2018 via email

yrashk commented Aug 24, 2018

xeji commented Aug 24, 2018

GrahamcOfBorg commented Aug 24, 2018

GrahamcOfBorg commented Aug 24, 2018

GrahamcOfBorg commented Aug 24, 2018

xeji commented Aug 24, 2018

xeji left a comment

Choose a reason for hiding this comment

yrashk commented Oct 2, 2018

xeji commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

xeji commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

GrahamcOfBorg commented Oct 2, 2018

yrashk commented Aug 19, 2018 •

edited