Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql: Fix cross compilation #45370

Merged
merged 1 commit into from Aug 20, 2018
Merged

postgresql: Fix cross compilation #45370

merged 1 commit into from Aug 20, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

b1548ce dropped the C compiler prefix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

vcunat
vcunat approved these changes Aug 20, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I focused on non-cross first, not knowing cross that well.

@vcunat vcunat changed the base branch from staging to staging-next August 20, 2018 08:10
@vcunat
Copy link
Member

vcunat commented Aug 20, 2018

Uh, oops, let me redo the history.

@vcunat
postgresql: Fix cross compilation
440ac01 
b1548ce dropped the C compiler prefix
@Ericson2314
Copy link
Member Author

Ericson2314 commented Aug 20, 2018 •
edited

No worries. Thanks again to unbreaking the builds. It's a lucky case where no-rebuild-inducing fix for cross isn't unpleasant, too :).

Feel free to fold in #45371. I did both from the web GUI...because I was tired.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: stdenv Standard environment label Aug 20, 2018
@vcunat vcunat merged commit 440ac01 into staging-next Aug 20, 2018
@vcunat vcunat deleted the postgresql-cross branch August 20, 2018 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @vcunat @GrahamcOfBorg