Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.nixpart0: fix nixops deploy #45349

Merged
merged 1 commit into from Aug 20, 2018

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Aug 19, 2018

re-introduce the unused "udevSoMajor" variable for nixops
backward-compatibilty (nixops master still uses it unlike claimed by previous comment).

This was removed by the treewide 52f53c6 cleanup

Motivation for this change

Fix nixops deployments

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

re-introduce the unused "udevSoMajor" variable for nixops
backward-compatibilty.

This was removed by the treewide 52f53c6 cleanup
@Mic92
Copy link
Member

Mic92 commented Aug 20, 2018

Is there also a pull request hat removes the override from NixOps?

@zimbatm
Copy link
Member Author

zimbatm commented Aug 20, 2018

There is this closed PR: NixOS/nixops#347

Since nixpart0 is legacy I think it's fine to keep this around. NixOps should be upgraded to the latest nixpart instead.

@Mic92 Mic92 merged commit d73e7ef into NixOS:master Aug 20, 2018
@zimbatm zimbatm deleted the fix-nixpart0-nixops branch August 20, 2018 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants