Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tdlib: init at 2018-03-20 #45359

Closed
wants to merge 1 commit into from
Closed

Conversation

andrey-komarov
Copy link
Contributor

Motivation for this change

This PR adds library to call Telegram API.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

src = fetchFromGitHub {
owner = "tdlib";
repo = "td";
rev = "cfe4d9bdcee9305632eb228a46a95407d05b5c7a";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for not using a released version?

Copy link
Member

@samueldr samueldr Nov 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Furthermore, they themselves have tagged it as v1.2.0 which probably should be the version instead of the date.

Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a version instead of a commit hash.

@vyorkin
Copy link
Member

vyorkin commented Jul 19, 2019

I think this could be closed since we already have tdlib. See #64685

@ryantm ryantm closed this Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants