Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel-headers: 4.15 -> 4.18.3 #45337

Merged
merged 1 commit into from Sep 14, 2018
Merged

kernel-headers: 4.15 -> 4.18.3 #45337

merged 1 commit into from Sep 14, 2018

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

4.15 is entirely unsupported

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Can't build this locally, I don't have 32-bit emulation. Somehow, the busybox binary used by stdenvNoCC is 32-bit and I don't know why.

@NeQuissimus
Copy link
Member Author

@GrahamcOfBorg build linuxHeaders

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxHeaders

Partial log (click to expand)

Cannot nix-instantiate `linuxHeaders' because:
error: while evaluating 'callPackagesWith' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:118:36, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:13820:12:
while evaluating anonymous function at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/attrsets.nix:199:9, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:125:8:
while evaluating anonymous function at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel-headers/default.nix:1:1, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:123:14:
assertion failed at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel-headers/default.nix:6:1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: linuxHeaders

Partial log (click to expand)

  INSTALL include/scsi/fc (4 files)
  INSTALL include/sound (16 files)
  INSTALL include/video (3 files)
  INSTALL include/xen (4 files)
  INSTALL include/asm (36 files)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1009wg8r3f7wavmp8jp0lvnl9k67hs3g-linux-headers-4.18.3
patching script interpreter paths in /nix/store/1009wg8r3f7wavmp8jp0lvnl9k67hs3g-linux-headers-4.18.3
checking for references to /build in /nix/store/1009wg8r3f7wavmp8jp0lvnl9k67hs3g-linux-headers-4.18.3...
/nix/store/1009wg8r3f7wavmp8jp0lvnl9k67hs3g-linux-headers-4.18.3

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: linuxHeaders

Partial log (click to expand)

cannot build derivation '/nix/store/1nyasw4d08y7wbw0cfz3sy7jacwl85qi-findutils-4.6.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/3jvaq0407k3f5airwza8pw1i1l1ajzyh-libtool-2.4.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/apv3ijn07h2442avhwcznm3nirfwq8jr-gcc-wrapper-7.3.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/xi931k6sgz7n4dkm2pj6i2jjmyfdxyh9-hook.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/ahrh7lfypjx89ipl61azc2zng8d9cszy-patch-2.7.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/s03hlryfbm897vndprsbcnpvwx90j9p0-stdenv-linux.drv': 24 dependencies couldn't be built
cannot build derivation '/nix/store/wh3pp5rshjyvnwqq3bbi7k5cqa20sp19-stdenv-linux.drv': 24 dependencies couldn't be built
cannot build derivation '/nix/store/n5b21sdxm0hc2ga3x5l5z4v1rvmcwa9y-perl-5.28.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/kv5nbgxpdf243zrk8sa7d0rzv71wl5k8-linux-headers-4.18.3.drv': 4 dependencies couldn't be built
error: build of '/nix/store/kv5nbgxpdf243zrk8sa7d0rzv71wl5k8-linux-headers-4.18.3.drv' failed

@xeji
Copy link
Contributor

xeji commented Aug 21, 2018

@GrahamcOfBorg build linuxHeaders

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxHeaders

Partial log (click to expand)

Cannot nix-instantiate `linuxHeaders' because:
error: while evaluating 'callPackagesWith' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:118:36, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:13834:12:
while evaluating anonymous function at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel-headers/default.nix:1:1, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:123:14:
assertion failed at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel-headers/default.nix:6:1

@xeji
Copy link
Contributor

xeji commented Aug 21, 2018

This should probably go to staging.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: linuxHeaders

Partial log (click to expand)

cannot build derivation '/nix/store/8cbvnk109kqmz24g28mqdihpq38kwk37-findutils-4.6.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/a7fc9rfn18lprlsz7gpxn5la5gwjsdhs-libtool-2.4.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/wf3vpl8xswy57vadcsya9ld69h9pdd11-gcc-wrapper-7.3.0.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/95c4awyr7l0jq84wpvbb2dlj3qrmlazm-hook.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/fzjf9yivnbqn7dp58ahpayj75lz14ga0-patch-2.7.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/1fk9dwifvr37mhl2y6gyh63qb2rr1027-stdenv-linux.drv': 29 dependencies couldn't be built
cannot build derivation '/nix/store/45c96bxrwqyb1lg08jfiykflap930cpr-stdenv-linux.drv': 29 dependencies couldn't be built
cannot build derivation '/nix/store/rq4h4dy4ni7pciwxwz0sqhkxchznxgqd-perl-5.28.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/a8ikxsximjsi5yl81gpw5nh0v0vamkyf-linux-headers-4.18.3.drv': 4 dependencies couldn't be built
error: build of '/nix/store/a8ikxsximjsi5yl81gpw5nh0v0vamkyf-linux-headers-4.18.3.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: linuxHeaders

Partial log (click to expand)

cannot build derivation '/nix/store/1nyasw4d08y7wbw0cfz3sy7jacwl85qi-findutils-4.6.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/3jvaq0407k3f5airwza8pw1i1l1ajzyh-libtool-2.4.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/apv3ijn07h2442avhwcznm3nirfwq8jr-gcc-wrapper-7.3.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/xi931k6sgz7n4dkm2pj6i2jjmyfdxyh9-hook.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/ahrh7lfypjx89ipl61azc2zng8d9cszy-patch-2.7.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/s03hlryfbm897vndprsbcnpvwx90j9p0-stdenv-linux.drv': 24 dependencies couldn't be built
cannot build derivation '/nix/store/wh3pp5rshjyvnwqq3bbi7k5cqa20sp19-stdenv-linux.drv': 24 dependencies couldn't be built
cannot build derivation '/nix/store/n5b21sdxm0hc2ga3x5l5z4v1rvmcwa9y-perl-5.28.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/kv5nbgxpdf243zrk8sa7d0rzv71wl5k8-linux-headers-4.18.3.drv': 4 dependencies couldn't be built
error: build of '/nix/store/kv5nbgxpdf243zrk8sa7d0rzv71wl5k8-linux-headers-4.18.3.drv' failed

@dezgeg
Copy link
Contributor

dezgeg commented Aug 21, 2018

I don't think it really matters whether the version used for userspace headers is unsupported or not.

@xeji
Copy link
Contributor

xeji commented Aug 27, 2018

But since we're shipping kernels up to 4.18, we should have at least 4.18 headers too.
Let's try the build again
@GrahamcOfBorg build linuxHeaders

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linuxHeaders

Partial log (click to expand)

Cannot nix-instantiate `linuxHeaders' because:
error: while evaluating 'callPackagesWith' at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:118:36, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/top-level/all-packages.nix:13917:12:
while evaluating anonymous function at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel-headers/default.nix:1:1, called from /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/lib/customisation.nix:123:14:
assertion failed at /private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/linux/kernel-headers/default.nix:6:1

@dezgeg
Copy link
Contributor

dezgeg commented Aug 27, 2018

No, there's really no need to do that, until some/many packages start to use such bleeding edge features. And probably many apps will just copy-paste the definitions from the headers anyway.

@xeji
Copy link
Contributor

xeji commented Aug 27, 2018

No, there's really no need to do that, until some/many packages start to use such bleeding edge features.

Probably true. But it shouldn't hurt either...

Anyway, if we want to merge this it should go to staging.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: linuxHeaders

Partial log (click to expand)

  INSTALL include/scsi/fc (4 files)
  INSTALL include/sound (16 files)
  INSTALL include/video (3 files)
  INSTALL include/xen (4 files)
  INSTALL include/asm (36 files)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4if443ivyk2kd9lcqaa361y8flzwbrvg-linux-headers-4.18.3
patching script interpreter paths in /nix/store/4if443ivyk2kd9lcqaa361y8flzwbrvg-linux-headers-4.18.3
checking for references to /build in /nix/store/4if443ivyk2kd9lcqaa361y8flzwbrvg-linux-headers-4.18.3...
/nix/store/4if443ivyk2kd9lcqaa361y8flzwbrvg-linux-headers-4.18.3

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: linuxHeaders

Partial log (click to expand)

cannot build derivation '/nix/store/z808inz90s68kdjn6zwhcxziq2nxrmbk-findutils-4.6.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/r0drq6lhm63jwxmnb2z95wif9lxl2f78-libtool-2.4.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/c3199gfg6dc42ch33qqww3slzzdmz65z-gcc-wrapper-7.3.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/4d6k1xlkm0hgjz0777whg87yypcf5zc2-hook.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/lb3sgf3icvp5kaa18gy3pf1sbvx88n6v-patch-2.7.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/q771p1g1l7chyv6rqm9iprhjq5i9prii-stdenv-linux.drv': 23 dependencies couldn't be built
cannot build derivation '/nix/store/wvkva3k3i1drh65b3vkriiw37525l3w2-stdenv-linux.drv': 23 dependencies couldn't be built
cannot build derivation '/nix/store/shd4shxdr95rmlfh36igvn3578yjlz56-perl-5.28.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/jrrh5fmhav6503a89h2cvfy8ji67q2h1-linux-headers-4.18.3.drv': 4 dependencies couldn't be built
error: build of '/nix/store/jrrh5fmhav6503a89h2cvfy8ji67q2h1-linux-headers-4.18.3.drv' failed

@vcunat vcunat changed the base branch from master to staging August 30, 2018 11:54
@vcunat
Copy link
Member

vcunat commented Aug 30, 2018 •
edited

There's something very wrong about our linuxHeaders derivation. Tools for the build aren't in binary cache (not even on the nixos-unstable channel), and you need to start from gcc.

@vcunat
Copy link
Member

vcunat commented Aug 30, 2018

My bad, it's used during stdenv bootstrapping, so rebuilding all is inevitable...

@xeji
Copy link
Contributor

xeji commented Sep 1, 2018

Builds locally on x86_64-linux. I didn't check anything except that the result actually contains some kernel headers 😄

@xeji xeji merged commit b93f423 into NixOS:staging Sep 14, 2018
@NeQuissimus NeQuissimus deleted the headers_4_18 branch September 15, 2018 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@NeQuissimus @GrahamcOfBorg @xeji @dezgeg @vcunat