ydiff: init at 1.1 #45323
Merged
ydiff: init at 1.1 #45323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no homepage (in meta) ? |
|
Added the GitHub page. With fetchFromGitHub that would have been automatic, but of course that doesn't hold. |
|
@GrahamcOfBorg build ydiff |
|
Success on x86_64-linux (full log) Attempted: ydiff Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: ydiff Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: ydiff Partial log (click to expand)
|
Are you sure the tests get run? |
|
The tests weren't being run, and for completeness sake I've added them. |
infinisil
requested changes
Aug 19, 2018
| checkInputs = [ coverage coreutils git subversion which ]; | ||
|
|
||
| checkPhase = lib.optional (!isPy3k) "make test" ++ | ||
| lib.optional (isPy3k) "make test3"; |
There was a problem hiding this comment.
You can just use
checkPhase = if isPy3k then ''
make test3
'' else ''
make test
''There was a problem hiding this comment.
Now using checkTarget, as suggested.
|
@GrahamcOfBorg build ydiff |
|
Failure on aarch64-linux (full log) Attempted: ydiff Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: ydiff Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: ydiff Partial log (click to expand)
|
leenaars
force-pushed
the
ydiff
branch
3 times, most recently
from
f379c61
to
82d80c7
Compare
infinisil
reviewed
Aug 19, 2018
| propagatedBuildInputs = [ less patchutils ]; | ||
| checkInputs = [ coverage coreutils git subversion which ]; | ||
|
|
||
| checkPhase = if isPy3k then ''make test3'' else ''make test''; |
There was a problem hiding this comment.
Sorry to nitpick, but if it's in a single line, then the '' quotes aren't needed:
{
checkPhase = if isPy3k then "make test3" else "make test";
}:D
There was a problem hiding this comment.
Indeed, so let's shave off those two extra characters...
There was a problem hiding this comment.
BTW: There is something rewarding with a tool that you can use on the commit itself.
ydiff -l -s
|
@GrahamcOfBorg build ydiff |
|
Failure on aarch64-linux (full log) Attempted: ydiff Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: ydiff Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: ydiff Partial log (click to expand)
|
leenaars
force-pushed
the
ydiff
branch
3 times, most recently
from
86aef4f
to
e71cff0
Compare
|
Can't you test this locally? |
|
Annoyingly, it builds on my system - I only push when it does that. But then there is different behaviour on the CI I'm trying to fix. Apologies! |
|
Try enabling the sandbox for your builds |
| propagatedBuildInputs = [ less patchutils ]; | ||
| checkInputs = [ coverage coreutils git subversion which ]; | ||
|
|
||
| checkPhase = if isPy3k then "make test3" else "make test"; |
There was a problem hiding this comment.
You can use checkTarget instead of checkPhase here.
There was a problem hiding this comment.
@matthewbauer: thanks, didn't know about that. Did that.
infinisil
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Handy tool for working with diffs.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)